[BlueZ,0/3] Code re-org and clean up

Message

Stotland, Inga July 13, 2020, 11:05 p.m. UTC

This patch set is part of the on-going  clean up effort that targets some
of more convoluted areas of meshd source code.
The patchset provides better functional separation, smaller function
granularity and better memory handling.

Inga Stotland (3):
  mesh: Use static array to hold config server response
  mesh: Add size checks for every opcode in config server
  mesh: move model functionality out of node.c to model.c

 mesh/cfgmod-server.c    |  99 ++++++-----
 mesh/cfgmod.h           |   4 +-
 mesh/mesh-config-json.c |   5 +-
 mesh/model.c            | 359 +++++++++++++++++++++++++++++++++-------
 mesh/model.h            |  32 ++--
 mesh/node.c             | 286 ++++----------------------------
 6 files changed, 403 insertions(+), 382 deletions(-)

Comments

Brian Gix July 16, 2020, 5:20 p.m. UTC | #1

Applied first two of patchset.

Holding off on the 3rd until I can more test more completely.

On Mon, 2020-07-13 at 16:05 -0700, Inga Stotland wrote:
> This patch set is part of the on-going  clean up effort that targets some
> of more convoluted areas of meshd source code.
> The patchset provides better functional separation, smaller function
> granularity and better memory handling.
> 
> Inga Stotland (3):
>   mesh: Use static array to hold config server response
>   mesh: Add size checks for every opcode in config server
>   mesh: move model functionality out of node.c to model.c
> 
>  mesh/cfgmod-server.c    |  99 ++++++-----
>  mesh/cfgmod.h           |   4 +-
>  mesh/mesh-config-json.c |   5 +-
>  mesh/model.c            | 359 +++++++++++++++++++++++++++++++++-------
>  mesh/model.h            |  32 ++--
>  mesh/node.c             | 286 ++++----------------------------
>  6 files changed, 403 insertions(+), 382 deletions(-)
>