| Message ID | 20200702191322.2639681-3-helen.koike@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | move Rockchip ISP bindings out of staging / add ISP DT nodes for RK3399 | expand |
On Thu, Jul 2, 2020 at 1:13 PM Helen Koike <helen.koike@collabora.com> wrote: > > Add missing required items in Rockchip ISP1 dt-bindings example for > a complete i2c node. > > Signed-off-by: Helen Koike <helen.koike@collabora.com> > --- > > Changes in v2: > - new patch in the series > --- > .../devicetree/bindings/media/rockchip-isp1.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml b/drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml > index a77b6ec500c95..8c7904845788d 100644 > --- a/drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml > +++ b/drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml > @@ -169,6 +169,11 @@ examples: > }; > > i2c7: i2c@ff160000 { > + compatible = "rockchip,rk3399-i2c"; > + reg = <0x0 0xff160000 0x0 0x1000>; This will give a warning now as the default cell sizes are 1. > + interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH 0>; > + clocks = <&cru SCLK_I2C7>, <&cru PCLK_I2C7>; > + clock-names = "i2c", "pclk"; Just drop the unit address rather than adding all this. > clock-frequency = <400000>; > #address-cells = <1>; > #size-cells = <0>; > -- > 2.26.0 >
diff --git a/drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml b/drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml index a77b6ec500c95..8c7904845788d 100644 --- a/drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml +++ b/drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml @@ -169,6 +169,11 @@ examples: }; i2c7: i2c@ff160000 { + compatible = "rockchip,rk3399-i2c"; + reg = <0x0 0xff160000 0x0 0x1000>; + interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH 0>; + clocks = <&cru SCLK_I2C7>, <&cru PCLK_I2C7>; + clock-names = "i2c", "pclk"; clock-frequency = <400000>; #address-cells = <1>; #size-cells = <0>;
Add missing required items in Rockchip ISP1 dt-bindings example for a complete i2c node. Signed-off-by: Helen Koike <helen.koike@collabora.com> --- Changes in v2: - new patch in the series --- .../devicetree/bindings/media/rockchip-isp1.yaml | 5 +++++ 1 file changed, 5 insertions(+)