[v7,0/5] dma: Add Xilinx ZynqMP DPDMA driver

Message

Laurent Pinchart July 17, 2020, 1:33 a.m. UTC

Hello,

This patch series adds a new driver for the DPDMA engine found in the
Xilinx ZynqMP.

The previous version can be found at [1]. All review comments have been
taken into account. The main changes are in the DPDMA driver, with
cleanups in the debugfs support, and handling of the !LOAD_EOT case when
preparing transactions.

The driver has been successfully tested with the ZynqMP DisplayPort
subsystem DRM driver.

As I would like to merge both this series and the DRM driver that
depends on it for v5.9 (if still possible), I have based those patches
on top of v5.8-rc1. There's unfortunately a conflict with the DMA engine
next branch, which is easy to resolve.

Vinod, if you're fine with the series, I can propose two ways forward:

- You can apply the patches on top of v5.8-rc1, push that to a base
  branch, merge it into the dmaengine -next branch, and push the base
  branch to a public git tree to let me base the DRM driver on it.

- I can perform that work if you give me a Reviewed-by tag for the
  series (at for patches 2/5 to 4/5), providing you with two signed
  tags, one for the base branch and one for the merged branch. You could
  then just pull the merged branch (please make sure not to rebase it or
  otherwise modify it in that case).

What's your preference ?

[1] https://lore.kernel.org/dmaengine/[e-mail]/

Hyun Kwon (1):
  dmaengine: xilinx: dpdma: Add the Xilinx DisplayPort DMA engine driver

Laurent Pinchart (4):
  dt: bindings: dma: xilinx: dpdma: DT bindings for Xilinx DPDMA
  dmaengine: Add support for repeating transactions
  dmaengine: xilinx: dpdma: Add debugfs support
  arm64: dts: zynqmp: Add DPDMA node

 .../dma/xilinx/xlnx,zynqmp-dpdma.yaml         |   68 +
 Documentation/driver-api/dmaengine/client.rst |    4 +-
 .../driver-api/dmaengine/provider.rst         |   49 +
 MAINTAINERS                                   |    9 +
 .../arm64/boot/dts/xilinx/zynqmp-clk-ccf.dtsi |    4 +
 arch/arm64/boot/dts/xilinx/zynqmp.dtsi        |   10 +
 drivers/dma/Kconfig                           |   10 +
 drivers/dma/xilinx/Makefile                   |    1 +
 drivers/dma/xilinx/xilinx_dpdma.c             | 1771 +++++++++++++++++
 include/dt-bindings/dma/xlnx-zynqmp-dpdma.h   |   16 +
 include/linux/dmaengine.h                     |   17 +
 11 files changed, 1958 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.yaml
 create mode 100644 drivers/dma/xilinx/xilinx_dpdma.c
 create mode 100644 include/dt-bindings/dma/xlnx-zynqmp-dpdma.h

Comments

Vinod Koul July 17, 2020, 6:11 a.m. UTC | #1

On 17-07-20, 04:33, Laurent Pinchart wrote:
> Hello,
> 
> This patch series adds a new driver for the DPDMA engine found in the
> Xilinx ZynqMP.
> 
> The previous version can be found at [1]. All review comments have been
> taken into account. The main changes are in the DPDMA driver, with
> cleanups in the debugfs support, and handling of the !LOAD_EOT case when
> preparing transactions.
> 
> The driver has been successfully tested with the ZynqMP DisplayPort
> subsystem DRM driver.
> 
> As I would like to merge both this series and the DRM driver that
> depends on it for v5.9 (if still possible), I have based those patches
> on top of v5.8-rc1. There's unfortunately a conflict with the DMA engine
> next branch, which is easy to resolve.
> 
> Vinod, if you're fine with the series, I can propose two ways forward:
> 
> - You can apply the patches on top of v5.8-rc1, push that to a base
>   branch, merge it into the dmaengine -next branch, and push the base
>   branch to a public git tree to let me base the DRM driver on it.

Applied 1-3 to dmaengine.git topic/xilinx, it should show up in -next
later in the day

Thanks

Laurent Pinchart July 18, 2020, 12:24 a.m. UTC | #2

Hi Vinod,

On Fri, Jul 17, 2020 at 11:41:20AM +0530, Vinod Koul wrote:
> On 17-07-20, 04:33, Laurent Pinchart wrote:
> > Hello,
> > 
> > This patch series adds a new driver for the DPDMA engine found in the
> > Xilinx ZynqMP.
> > 
> > The previous version can be found at [1]. All review comments have been
> > taken into account. The main changes are in the DPDMA driver, with
> > cleanups in the debugfs support, and handling of the !LOAD_EOT case when
> > preparing transactions.
> > 
> > The driver has been successfully tested with the ZynqMP DisplayPort
> > subsystem DRM driver.
> > 
> > As I would like to merge both this series and the DRM driver that
> > depends on it for v5.9 (if still possible), I have based those patches
> > on top of v5.8-rc1. There's unfortunately a conflict with the DMA engine
> > next branch, which is easy to resolve.
> > 
> > Vinod, if you're fine with the series, I can propose two ways forward:
> > 
> > - You can apply the patches on top of v5.8-rc1, push that to a base
> >   branch, merge it into the dmaengine -next branch, and push the base
> >   branch to a public git tree to let me base the DRM driver on it.
> 
> Applied 1-3 to dmaengine.git topic/xilinx, it should show up in -next
> later in the day

Thank you!