| Message ID | 20200716091606.38316-1-johannes.thumshirn@wdc.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | b9245385f73c11c908e0f652b7c5b9bda3b36374 |
| Headers | show |
| Series | scsi: sd_zbc: don't check max zone append sectors for max hw sectors | expand |
On 2020/07/16 18:16, Johannes Thumshirn wrote: > Don't check for the maximum zone append sectors to be not bigger than the > maximum hardware sectors in sd, as the block layer is already enforcing > this limit when setting the max zone append sectors. > > Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> > --- > drivers/scsi/sd_zbc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/scsi/sd_zbc.c b/drivers/scsi/sd_zbc.c > index 6f7eba66687e..4c90911545b6 100644 > --- a/drivers/scsi/sd_zbc.c > +++ b/drivers/scsi/sd_zbc.c > @@ -736,7 +736,6 @@ int sd_zbc_read_zones(struct scsi_disk *sdkp, unsigned char *buf) > > max_append = min_t(u32, logical_to_sectors(sdkp->device, zone_blocks), > q->limits.max_segments << (PAGE_SHIFT - 9)); > - max_append = min_t(u32, max_append, queue_max_hw_sectors(q)); > > blk_queue_max_zone_append_sectors(q, max_append); > > Looks good. Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
On Thu, 16 Jul 2020 18:16:06 +0900, Johannes Thumshirn wrote: > Don't check for the maximum zone append sectors to be not bigger than the > maximum hardware sectors in sd, as the block layer is already enforcing > this limit when setting the max zone append sectors. Applied to 5.9/scsi-queue, thanks! [1/1] scsi: sd_zbc: Don't limit max_zone_append sectors to max_hw_sectors https://git.kernel.org/mkp/scsi/c/eb3e9de0c932
diff --git a/drivers/scsi/sd_zbc.c b/drivers/scsi/sd_zbc.c index 6f7eba66687e..4c90911545b6 100644 --- a/drivers/scsi/sd_zbc.c +++ b/drivers/scsi/sd_zbc.c @@ -736,7 +736,6 @@ int sd_zbc_read_zones(struct scsi_disk *sdkp, unsigned char *buf) max_append = min_t(u32, logical_to_sectors(sdkp->device, zone_blocks), q->limits.max_segments << (PAGE_SHIFT - 9)); - max_append = min_t(u32, max_append, queue_max_hw_sectors(q)); blk_queue_max_zone_append_sectors(q, max_append);
Don't check for the maximum zone append sectors to be not bigger than the maximum hardware sectors in sd, as the block layer is already enforcing this limit when setting the max zone append sectors. Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> --- drivers/scsi/sd_zbc.c | 1 - 1 file changed, 1 deletion(-)