| Message ID | 20200716022817.30439-2-ansuelsmth@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add support for ipq8064 tsens | expand |
On Thu, Jul 16, 2020 at 7:58 AM Ansuel Smith <ansuelsmth@gmail.com> wrote: > > Add support for child probing needed for tsens driver that share the > seme regs of gcc for this platform. Typo: same > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> > --- > drivers/clk/qcom/gcc-ipq806x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/qcom/gcc-ipq806x.c b/drivers/clk/qcom/gcc-ipq806x.c > index a8456e09c44d..d6b7adb4be38 100644 > --- a/drivers/clk/qcom/gcc-ipq806x.c > +++ b/drivers/clk/qcom/gcc-ipq806x.c > @@ -3089,7 +3089,7 @@ static int gcc_ipq806x_probe(struct platform_device *pdev) > regmap_write(regmap, 0x3cf8, 8); > regmap_write(regmap, 0x3d18, 8); > > - return 0; > + return of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev); > } > > static struct platform_driver gcc_ipq806x_driver = { > -- > 2.27.0 >
Quoting Amit Kucheria (2020-07-20 02:41:44) > On Thu, Jul 16, 2020 at 7:58 AM Ansuel Smith <ansuelsmth@gmail.com> wrote: > > > > Add support for child probing needed for tsens driver that share the > > seme regs of gcc for this platform. > > Typo: same > Otherwise reviewed-by? Because I can throw this into the clk tree with the typo fixed.
On Tue, Jul 21, 2020 at 11:27 AM Amit Kucheria <amit.kucheria@linaro.org> wrote: > > > > On Tue, 21 Jul, 2020, 05:06 Stephen Boyd, <sboyd@kernel.org> wrote: >> >> Quoting Amit Kucheria (2020-07-20 02:41:44) >> > On Thu, Jul 16, 2020 at 7:58 AM Ansuel Smith <ansuelsmth@gmail.com> wrote: >> > > >> > > Add support for child probing needed for tsens driver that share the >> > > seme regs of gcc for this platform. >> > >> > Typo: same >> > >> >> Otherwise reviewed-by? Because I can throw this into the clk tree with >> the typo fixed. > > > Yes, the rest of the series need work imo, but this patch looks ok to populate the child nodes in OF. > > Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org> Replied earlier from a phone, which resulted in HTML email. Resending. The rest of the series need work imo, but this patch looks ok to populate the child nodes in OF. Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>
Quoting Ansuel Smith (2020-07-15 19:28:10) > Add support for child probing needed for tsens driver that share the > seme regs of gcc for this platform. > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> > --- Applied to clk-next with the typo fix and tag.
diff --git a/drivers/clk/qcom/gcc-ipq806x.c b/drivers/clk/qcom/gcc-ipq806x.c index a8456e09c44d..d6b7adb4be38 100644 --- a/drivers/clk/qcom/gcc-ipq806x.c +++ b/drivers/clk/qcom/gcc-ipq806x.c @@ -3089,7 +3089,7 @@ static int gcc_ipq806x_probe(struct platform_device *pdev) regmap_write(regmap, 0x3cf8, 8); regmap_write(regmap, 0x3d18, 8); - return 0; + return of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev); } static struct platform_driver gcc_ipq806x_driver = {
Add support for child probing needed for tsens driver that share the seme regs of gcc for this platform. Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> --- drivers/clk/qcom/gcc-ipq806x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)