| Message ID | 20200624131045.14512-5-kraxel@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | build some devices as modules. | expand |
On 2020-06-24 at 15:10 CEST, Gerd Hoffmann wrote... > See comment. Feels quite hackish. Better ideas anyone? > > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> > --- > Makefile.target | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Makefile.target b/Makefile.target > index 8ed1eba95b9c..c70325df5796 100644 > --- a/Makefile.target > +++ b/Makefile.target > @@ -179,6 +179,13 @@ endif # CONFIG_SOFTMMU > dummy := $(call unnest-vars,,obj-y) > all-obj-y := $(obj-y) > > +# > +# common-obj-m has some crap here, probably as side effect from > +# filling obj-y. Clear it. Fixes suspious dependency errors when Typo: suspicious > +# building devices as modules. > +# (As an aside: I'm also not filled with confidence by this comment ;-) > +common-obj-m := > + > include $(SRC_PATH)/Makefile.objs > dummy := $(call unnest-vars,.., \ > authz-obj-y \ -- Cheers, Christophe de Dinechin (IRC c3d)
Hi, > > +# filling obj-y. Clear it. Fixes suspious dependency errors when > > Typo: suspicious Fixed. thanks, Gerd
diff --git a/Makefile.target b/Makefile.target index 8ed1eba95b9c..c70325df5796 100644 --- a/Makefile.target +++ b/Makefile.target @@ -179,6 +179,13 @@ endif # CONFIG_SOFTMMU dummy := $(call unnest-vars,,obj-y) all-obj-y := $(obj-y) +# +# common-obj-m has some crap here, probably as side effect from +# filling obj-y. Clear it. Fixes suspious dependency errors when +# building devices as modules. +# +common-obj-m := + include $(SRC_PATH)/Makefile.objs dummy := $(call unnest-vars,.., \ authz-obj-y \
See comment. Feels quite hackish. Better ideas anyone? Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> --- Makefile.target | 7 +++++++ 1 file changed, 7 insertions(+)