| Message ID | 20200709135251.643-1-jonathan@marek.ca (mailing list archive) |
|---|---|
| Headers | show |
| Series | Enable GPU for SM8150 and SM8250 | expand |
Quoting Jonathan Marek (2020-07-09 06:52:31) > This series adds the missing clock drivers and dts nodes to enable > the GPU on both SM8150 and SM8250. > > Note an extra drm/msm patch [1] is required for SM8250. > > As noted by Dmitry, GMU init fails with newer firmware, needs this patch [2]. > > [1] https://patchwork.freedesktop.org/series/78968/ > [2] https://git.linaro.org/landing-teams/working/qualcomm/kernel.git/commit/?h=tracking-qcomlt-sm8250&id=01331f2ccbe7e6c4719dbe038a5fb496db32646d Vinod, can you test this patch series? And Taniya, can you review it?
On 21/07/2020 10:54, Stephen Boyd wrote: > Quoting Jonathan Marek (2020-07-09 06:52:31) >> This series adds the missing clock drivers and dts nodes to enable >> the GPU on both SM8150 and SM8250. >> >> Note an extra drm/msm patch [1] is required for SM8250. >> >> As noted by Dmitry, GMU init fails with newer firmware, needs this patch [2]. >> >> [1] https://patchwork.freedesktop.org/series/78968/ >> [2] https://git.linaro.org/landing-teams/working/qualcomm/kernel.git/commit/?h=tracking-qcomlt-sm8250&id=01331f2ccbe7e6c4719dbe038a5fb496db32646d > > Vinod, can you test this patch series? And Taniya, can you review it? On SM8250: Tested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
This series adds the missing clock drivers and dts nodes to enable the GPU on both SM8150 and SM8250. Note an extra drm/msm patch [1] is required for SM8250. As noted by Dmitry, GMU init fails with newer firmware, needs this patch [2]. [1] https://patchwork.freedesktop.org/series/78968/ [2] https://git.linaro.org/landing-teams/working/qualcomm/kernel.git/commit/?h=tracking-qcomlt-sm8250&id=01331f2ccbe7e6c4719dbe038a5fb496db32646d Changes in V2: * Added "clk: qcom: gcc: fix sm8150 GPU and NPU clocks" to fix the newly added SM8150 GPU gcc clocks * Added "Fixes:" tag to "clk: qcom: clk-alpha-pll: remove unused/incorrect PLL_CAL_VAL" * Added yaml schemas to gpucc dt-bindings patches * Added "clk: qcom: add common gdsc_gx_do_nothing_enable for gpucc drivers" and changed gpucc patches to use it. * Removed CLK_IS_CRITICAL from gpu_cc_ahb_clk * Added missing rpmh regulator level for sm8250 GPU clock levels * Use sm8150/sm8250 iommu compatibles in dts * Add gcc_gpu_gpll0_clk_src/gcc_gpu_gpll0_div_clk_src to gpucc clocks in dts Changes in V3: * Combined gpucc yaml bindings into one * Removed some unused clocks from gpucc drivers to move closely match other gpucc * Use parent_data instead of parent_names Jonathan Marek (14): clk: qcom: gcc: fix sm8150 GPU and NPU clocks clk: qcom: clk-alpha-pll: remove unused/incorrect PLL_CAL_VAL clk: qcom: clk-alpha-pll: same regs and ops for trion and lucid clk: qcom: clk-alpha-pll: use the right PCAL_DONE value for lucid pll clk: qcom: gcc: remove unnecessary vco_table from SM8150 dt-bindings: clock: combine qcom,sdm845-gpucc and qcom,sc7180-gpucc dt-bindings: clock: add SM8150 QCOM Graphics clock bindings dt-bindings: clock: add SM8250 QCOM Graphics clock bindings clk: qcom: add common gdsc_gx_do_nothing_enable for gpucc drivers clk: qcom: Add graphics clock controller driver for SM8150 clk: qcom: Add graphics clock controller driver for SM8250 dt-bindings: power: Add missing rpmpd rpmh regulator level arm64: dts: qcom: add sm8150 GPU nodes arm64: dts: qcom: add sm8250 GPU nodes ...qcom,sdm845-gpucc.yaml => qcom,gpucc.yaml} | 18 +- .../bindings/clock/qcom,sc7180-gpucc.yaml | 74 ---- arch/arm64/boot/dts/qcom/sm8150.dtsi | 136 +++++++ arch/arm64/boot/dts/qcom/sm8250.dtsi | 143 +++++++ drivers/clk/qcom/Kconfig | 16 + drivers/clk/qcom/Makefile | 2 + drivers/clk/qcom/clk-alpha-pll.c | 70 ++-- drivers/clk/qcom/clk-alpha-pll.h | 15 +- drivers/clk/qcom/gcc-sm8150.c | 26 +- drivers/clk/qcom/gdsc.c | 25 ++ drivers/clk/qcom/gdsc.h | 1 + drivers/clk/qcom/gpucc-sc7180.c | 27 +- drivers/clk/qcom/gpucc-sdm845.c | 27 +- drivers/clk/qcom/gpucc-sm8150.c | 320 ++++++++++++++++ drivers/clk/qcom/gpucc-sm8250.c | 348 ++++++++++++++++++ include/dt-bindings/clock/qcom,gpucc-sm8150.h | 33 ++ include/dt-bindings/clock/qcom,gpucc-sm8250.h | 34 ++ include/dt-bindings/power/qcom-rpmpd.h | 1 + 18 files changed, 1128 insertions(+), 188 deletions(-) rename Documentation/devicetree/bindings/clock/{qcom,sdm845-gpucc.yaml => qcom,gpucc.yaml} (75%) delete mode 100644 Documentation/devicetree/bindings/clock/qcom,sc7180-gpucc.yaml create mode 100644 drivers/clk/qcom/gpucc-sm8150.c create mode 100644 drivers/clk/qcom/gpucc-sm8250.c create mode 100644 include/dt-bindings/clock/qcom,gpucc-sm8150.h create mode 100644 include/dt-bindings/clock/qcom,gpucc-sm8250.h