| Message ID | 20200717185118.3640219-1-erik@kryo.se (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | d2a4309c1ab6df424b2239fe2920d6f26f808d17 |
| Headers | show |
| Series | USB: serial: qcserial: add EM7305 QDL product ID | expand |
On Fri, Jul 17, 2020 at 08:51:18PM +0200, Erik Ekman wrote: > When running qmi-firmware-update on the Sierra Wireless EM7305 in a Toshiba > laptop, it changed product ID to 0x9062 when entering QDL mode: > > usb 2-4: new high-speed USB device number 78 using xhci_hcd > usb 2-4: New USB device found, idVendor=1199, idProduct=9062, bcdDevice= 0.00 > usb 2-4: New USB device strings: Mfr=1, Product=2, SerialNumber=0 > usb 2-4: Product: EM7305 > usb 2-4: Manufacturer: Sierra Wireless, Incorporated > > The upgrade could complete after running > # echo 1199 9062 > /sys/bus/usb-serial/drivers/qcserial/new_id > > qcserial 2-4:1.0: Qualcomm USB modem converter detected > usb 2-4: Qualcomm USB modem converter now attached to ttyUSB0 > > Signed-off-by: Erik Ekman <erik@kryo.se> Applied, thanks. Would you mind posting the output of "usb-devices" (or "lsusb -v") for this device for completeness? Johan
On Tue, 21 Jul 2020 at 09:23, Johan Hovold <johan@kernel.org> wrote: > > On Fri, Jul 17, 2020 at 08:51:18PM +0200, Erik Ekman wrote: > > When running qmi-firmware-update on the Sierra Wireless EM7305 in a Toshiba > > laptop, it changed product ID to 0x9062 when entering QDL mode: > > > > usb 2-4: new high-speed USB device number 78 using xhci_hcd > > usb 2-4: New USB device found, idVendor=1199, idProduct=9062, bcdDevice= 0.00 > > usb 2-4: New USB device strings: Mfr=1, Product=2, SerialNumber=0 > > usb 2-4: Product: EM7305 > > usb 2-4: Manufacturer: Sierra Wireless, Incorporated > > > > The upgrade could complete after running > > # echo 1199 9062 > /sys/bus/usb-serial/drivers/qcserial/new_id > > > > qcserial 2-4:1.0: Qualcomm USB modem converter detected > > usb 2-4: Qualcomm USB modem converter now attached to ttyUSB0 > > > > Signed-off-by: Erik Ekman <erik@kryo.se> > > Applied, thanks. > > Would you mind posting the output of "usb-devices" (or "lsusb -v") for > this device for completeness? > (resend as plain text) from usb-devices: T: Bus=02 Lev=01 Prnt=01 Port=03 Cnt=03 Dev#= 30 Spd=480 MxCh= 0 D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 P: Vendor=1199 ProdID=9062 Rev=00.00 S: Manufacturer=Sierra Wireless, Incorporated S: Product=EM7305 C: #Ifs= 1 Cfg#= 1 Atr=80 MxPwr=2mA I: If#=0x0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) and with the driver it instead ends with: I: If#=0x0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=qcserial as expected. Cheers /Erik > > Johan
On Tue, Jul 21, 2020 at 08:15:04PM +0200, Erik Ekman wrote: > On Tue, 21 Jul 2020 at 09:23, Johan Hovold <johan@kernel.org> wrote: > > Would you mind posting the output of "usb-devices" (or "lsusb -v") for > > this device for completeness? > from usb-devices: > > T: Bus=02 Lev=01 Prnt=01 Port=03 Cnt=03 Dev#= 30 Spd=480 MxCh= 0 > D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 > P: Vendor=1199 ProdID=9062 Rev=00.00 > S: Manufacturer=Sierra Wireless, Incorporated > S: Product=EM7305 > C: #Ifs= 1 Cfg#= 1 Atr=80 MxPwr=2mA > I: If#=0x0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) Thanks! Johan
diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c index d147feae83e6..0f60363c1bbc 100644 --- a/drivers/usb/serial/qcserial.c +++ b/drivers/usb/serial/qcserial.c @@ -155,6 +155,7 @@ static const struct usb_device_id id_table[] = { {DEVICE_SWI(0x1199, 0x9056)}, /* Sierra Wireless Modem */ {DEVICE_SWI(0x1199, 0x9060)}, /* Sierra Wireless Modem */ {DEVICE_SWI(0x1199, 0x9061)}, /* Sierra Wireless Modem */ + {DEVICE_SWI(0x1199, 0x9062)}, /* Sierra Wireless EM7305 QDL */ {DEVICE_SWI(0x1199, 0x9063)}, /* Sierra Wireless EM7305 */ {DEVICE_SWI(0x1199, 0x9070)}, /* Sierra Wireless MC74xx */ {DEVICE_SWI(0x1199, 0x9071)}, /* Sierra Wireless MC74xx */
When running qmi-firmware-update on the Sierra Wireless EM7305 in a Toshiba laptop, it changed product ID to 0x9062 when entering QDL mode: usb 2-4: new high-speed USB device number 78 using xhci_hcd usb 2-4: New USB device found, idVendor=1199, idProduct=9062, bcdDevice= 0.00 usb 2-4: New USB device strings: Mfr=1, Product=2, SerialNumber=0 usb 2-4: Product: EM7305 usb 2-4: Manufacturer: Sierra Wireless, Incorporated The upgrade could complete after running # echo 1199 9062 > /sys/bus/usb-serial/drivers/qcserial/new_id qcserial 2-4:1.0: Qualcomm USB modem converter detected usb 2-4: Qualcomm USB modem converter now attached to ttyUSB0 Signed-off-by: Erik Ekman <erik@kryo.se> --- drivers/usb/serial/qcserial.c | 1 + 1 file changed, 1 insertion(+)