| Message ID | 20200722004707.779601-1-masahiroy@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | xtensa: add boot subdirectories build artifacts to 'targets' | expand |
On Tue, Jul 21, 2020 at 5:47 PM Masahiro Yamada <masahiroy@kernel.org> wrote: > > Xtensa always rebuilds the following even if nothing in the source code > has been changed. Passing V=2 shows the reason. > > AS arch/xtensa/boot/boot-elf/bootstrap.o - due to bootstrap.o not in $(targets) > LDS arch/xtensa/boot/boot-elf/boot.lds - due to boot.lds not in $(targets) > > They are built by if_changed(_dep). Add them to 'targets' so .*.cmd files > are included. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > --- > > arch/xtensa/boot/boot-elf/Makefile | 1 + > arch/xtensa/boot/boot-redboot/Makefile | 1 + > 2 files changed, 2 insertions(+) Acked-by: Max Filippov <jcmvbkbc@gmail.com>
On Wed, Jul 22, 2020 at 12:57 PM Max Filippov <jcmvbkbc@gmail.com> wrote: > > On Tue, Jul 21, 2020 at 5:47 PM Masahiro Yamada <masahiroy@kernel.org> wrote: > > > > Xtensa always rebuilds the following even if nothing in the source code > > has been changed. Passing V=2 shows the reason. > > > > AS arch/xtensa/boot/boot-elf/bootstrap.o - due to bootstrap.o not in $(targets) > > LDS arch/xtensa/boot/boot-elf/boot.lds - due to boot.lds not in $(targets) > > > > They are built by if_changed(_dep). Add them to 'targets' so .*.cmd files > > are included. > > > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > > --- > > > > arch/xtensa/boot/boot-elf/Makefile | 1 + > > arch/xtensa/boot/boot-redboot/Makefile | 1 + > > 2 files changed, 2 insertions(+) > > Acked-by: Max Filippov <jcmvbkbc@gmail.com> > > -- > Thanks. > -- Max Applied to linux-kbuild.
diff --git a/arch/xtensa/boot/boot-elf/Makefile b/arch/xtensa/boot/boot-elf/Makefile index 12ae1e91cb75..badee63dae27 100644 --- a/arch/xtensa/boot/boot-elf/Makefile +++ b/arch/xtensa/boot/boot-elf/Makefile @@ -15,6 +15,7 @@ export CPPFLAGS_boot.lds += -P -C export KBUILD_AFLAGS += -mtext-section-literals boot-y := bootstrap.o +targets += $(boot-y) boot.lds OBJS := $(addprefix $(obj)/,$(boot-y)) diff --git a/arch/xtensa/boot/boot-redboot/Makefile b/arch/xtensa/boot/boot-redboot/Makefile index 8632473ad319..1a277dd57b2a 100644 --- a/arch/xtensa/boot/boot-redboot/Makefile +++ b/arch/xtensa/boot/boot-redboot/Makefile @@ -13,6 +13,7 @@ endif LD_ARGS = -T $(srctree)/$(obj)/boot.ld boot-y := bootstrap.o +targets += $(boot-y) OBJS := $(addprefix $(obj)/,$(boot-y)) LIBS := arch/xtensa/boot/lib/lib.a arch/xtensa/lib/lib.a
Xtensa always rebuilds the following even if nothing in the source code has been changed. Passing V=2 shows the reason. AS arch/xtensa/boot/boot-elf/bootstrap.o - due to bootstrap.o not in $(targets) LDS arch/xtensa/boot/boot-elf/boot.lds - due to boot.lds not in $(targets) They are built by if_changed(_dep). Add them to 'targets' so .*.cmd files are included. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> --- arch/xtensa/boot/boot-elf/Makefile | 1 + arch/xtensa/boot/boot-redboot/Makefile | 1 + 2 files changed, 2 insertions(+)