mbox series

[RFC,PATH,i-g-t,00/15] tests/core_hotunplug: Fixes and enhancements

Message ID 20200720121908.28124-1-janusz.krzysztofik@linux.intel.com (mailing list archive)
Headers show
Series tests/core_hotunplug: Fixes and enhancements | expand

Message

Janusz Krzysztofik July 20, 2020, 12:18 p.m. UTC 
Since the test is still blocklisted due to driver issues and won't be
executed on CI, I'm providing a link where results obtained from a 
rybot run with the test removed from the blocklist can be found:
https://patchwork.freedesktop.org/series/79662/
Failures reported there come from driver and not test issues, I
believe.

Thanks,
Janusz

Janusz Krzysztofik (15):
  tests/core_hotunplug: Use igt_assert_fd()
  tests/core_hotunplug: Constify dev_bus_addr string
  tests/core_hotunplug: Consolidate duplicated debug messages
  tests/core_hotunplug: Assert successful device filter application
  tests/core_hotunplug: Fix missing newline
  tests/core_hotunplug: Maintain a single data structure instance
  tests/core_hotunplug: Pass errors via a data structure field
  tests/core_hotunplug: Handle device close errors
  tests/core_hotunplug: Prepare invariant data once per test run
  tests/core_hotunplug: Skip selectively on sysfs close errors
  tests/core_hotunplug: Follow failed subtests with health checks
  tests/core_hotunplug: Fail subtests on device close errors
  tests/core_hotunplug: Process return values of sysfs operations
  tests/core_hotunplug: Assert expected device presence/absence
  tests/core_hotunplug: Explicitly ignore unused return values

 tests/core_hotunplug.c | 333 +++++++++++++++++++++++++----------------
 1 file changed, 202 insertions(+), 131 deletions(-)

Comments

Michał Winiarski July 22, 2020, 4:47 p.m. UTC | #1 
Quoting Janusz Krzysztofik (2020-07-20 14:18:53)
> Since the test is still blocklisted due to driver issues and won't be
> executed on CI, I'm providing a link where results obtained from a 
> rybot run with the test removed from the blocklist can be found:
> https://patchwork.freedesktop.org/series/79662/
> Failures reported there come from driver and not test issues, I
> believe.
> 
> Thanks,
> Janusz

I'd probably squash some of the patches (e.g. 06/15 with 07/15, maybe more),
but that's just a matter of opinion (and I guess such fine-grained split makes
it easier to review).

LGTM.

Reviewed-by: Michał Winiarski <michal.winiarski@intel.com>

-Michał

> 
> Janusz Krzysztofik (15):
>   tests/core_hotunplug: Use igt_assert_fd()
>   tests/core_hotunplug: Constify dev_bus_addr string
>   tests/core_hotunplug: Consolidate duplicated debug messages
>   tests/core_hotunplug: Assert successful device filter application
>   tests/core_hotunplug: Fix missing newline
>   tests/core_hotunplug: Maintain a single data structure instance
>   tests/core_hotunplug: Pass errors via a data structure field
>   tests/core_hotunplug: Handle device close errors
>   tests/core_hotunplug: Prepare invariant data once per test run
>   tests/core_hotunplug: Skip selectively on sysfs close errors
>   tests/core_hotunplug: Follow failed subtests with health checks
>   tests/core_hotunplug: Fail subtests on device close errors
>   tests/core_hotunplug: Process return values of sysfs operations
>   tests/core_hotunplug: Assert expected device presence/absence
>   tests/core_hotunplug: Explicitly ignore unused return values
> 
>  tests/core_hotunplug.c | 333 +++++++++++++++++++++++++----------------
>  1 file changed, 202 insertions(+), 131 deletions(-)
> 
> -- 
> 2.21.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx