| Message ID | 20200723090731.4482-5-seiya.wang@mediatek.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add basic node support for Mediatek MT8192 SoC | expand |
On Thu, Jul 23, 2020 at 05:07:31PM +0800, Seiya Wang wrote: > From: Crystal Guo <crystal.guo@mediatek.com> > > update mtk-wdt document for MT8192 platform > > Signed-off-by: Crystal Guo <crystal.guo@mediatek.com> > --- > Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt > index 4dd36bd3f1ad..d760ca8a630e 100644 > --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt > +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt > @@ -12,6 +12,8 @@ Required properties: > "mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629 > "mediatek,mt8183-wdt", "mediatek,mt6589-wdt": for MT8183 > "mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516 > + "mediatek,mt8192-wdt": for MT8192 > + So, not compatible with "mediatek,mt6589-wdt"? Is so, perhaps summarize what the differences are. > > - reg : Specifies base physical address and size of the registers. > > -- > 2.14.1
On 23/07/2020 23:29, Rob Herring wrote: > On Thu, Jul 23, 2020 at 05:07:31PM +0800, Seiya Wang wrote: >> From: Crystal Guo <crystal.guo@mediatek.com> >> >> update mtk-wdt document for MT8192 platform >> >> Signed-off-by: Crystal Guo <crystal.guo@mediatek.com> >> --- >> Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt >> index 4dd36bd3f1ad..d760ca8a630e 100644 >> --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt >> +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt >> @@ -12,6 +12,8 @@ Required properties: >> "mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629 >> "mediatek,mt8183-wdt", "mediatek,mt6589-wdt": for MT8183 >> "mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516 >> + "mediatek,mt8192-wdt": for MT8192 >> + > > So, not compatible with "mediatek,mt6589-wdt"? Is so, perhaps summarize > what the differences are. > Hm, looks to me as if the binding description for mt2712 and mt8183 isn't correct, as we have a OF data just as we have for mt8192 now. Could you fix this in a separate patch? Regards, Matthias >> >> - reg : Specifies base physical address and size of the registers. >> >> -- >> 2.14.1
On Fri, 2020-07-24 at 06:02 +0800, Matthias Brugger wrote: > > On 23/07/2020 23:29, Rob Herring wrote: > > On Thu, Jul 23, 2020 at 05:07:31PM +0800, Seiya Wang wrote: > >> From: Crystal Guo <crystal.guo@mediatek.com> > >> > >> update mtk-wdt document for MT8192 platform > >> > >> Signed-off-by: Crystal Guo <crystal.guo@mediatek.com> > >> --- > >> Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt > >> index 4dd36bd3f1ad..d760ca8a630e 100644 > >> --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt > >> +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt > >> @@ -12,6 +12,8 @@ Required properties: > >> "mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629 > >> "mediatek,mt8183-wdt", "mediatek,mt6589-wdt": for MT8183 > >> "mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516 > >> + "mediatek,mt8192-wdt": for MT8192 > >> + > > > > So, not compatible with "mediatek,mt6589-wdt"? Is so, perhaps summarize > > what the differences are. > > > > Hm, looks to me as if the binding description for mt2712 and mt8183 isn't > correct, as we have a OF data just as we have for mt8192 now. Could you fix this > in a separate patch? > > Regards, > Matthias > > Besides watchdog, mt8192 toprgu module also provide sub-system software reset features. > mt2712 and mt8183 are same as mt8192. But mt6589 not support sub-system software reset. > > >> > >> - reg : Specifies base physical address and size of the registers. > >> > >> -- > >> 2.14.1
diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt index 4dd36bd3f1ad..d760ca8a630e 100644 --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt @@ -12,6 +12,8 @@ Required properties: "mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629 "mediatek,mt8183-wdt", "mediatek,mt6589-wdt": for MT8183 "mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516 + "mediatek,mt8192-wdt": for MT8192 + - reg : Specifies base physical address and size of the registers.