| Message ID | 20200724074038.5597-15-krzk@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | *memory: Cleanup, improve and compile test memory drivers | expand |
On Fri, Jul 24, 2020 at 09:40:23AM +0200, Krzysztof Kozlowski wrote: > The platform_get_irq() already prints error message so there is no need > to do it again in the driver. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > drivers/memory/emif.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > Applied (and part of pull request to arm-soc). Best regards, Krzysztof
diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c index 1241a87081f8..1bf0656d5e9a 100644 --- a/drivers/memory/emif.c +++ b/drivers/memory/emif.c @@ -1561,11 +1561,8 @@ static int __init_or_module emif_probe(struct platform_device *pdev) goto error; irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(emif->dev, "%s: error getting IRQ resource - %d\n", - __func__, irq); + if (irq < 0) goto error; - } emif_onetime_settings(emif); emif_debugfs_init(emif);
The platform_get_irq() already prints error message so there is no need to do it again in the driver. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/memory/emif.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)