diff mbox series

net: cdc_ncm: USB_NET_CDC_NCM selects USB_NET_CDCETHER

Message ID 20200723142210.21274-1-trix@redhat.com (mailing list archive)
State Accepted
Commit 5fd99b5d9950d6300467ded18ff4e44af0b4ae55
Headers show
Series net: cdc_ncm: USB_NET_CDC_NCM selects USB_NET_CDCETHER | expand

Commit Message

Tom Rix July 23, 2020, 2:22 p.m. UTC
From: Tom Rix <trix@redhat.com>

A link error

ld: drivers/net/usb/cdc_ncm.o:
  undefined reference to `usbnet_cdc_update_filter'

usbnet_cdc_update_filter is defined in cdc_ether.c
Building of cdc_ether.o is controlled by USB_NET_CDCETHER

Building of cdc_ncm.o is controlled by USB_NET_CDC_NCM

So add a select USB_NET_CDCETHER to USB_NET_CDC_NCM

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/net/usb/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

David Miller July 25, 2020, 2:54 a.m. UTC | #1
From: trix@redhat.com
Date: Thu, 23 Jul 2020 07:22:10 -0700

> From: Tom Rix <trix@redhat.com>
> 
> A link error
> 
> ld: drivers/net/usb/cdc_ncm.o:
>   undefined reference to `usbnet_cdc_update_filter'
> 
> usbnet_cdc_update_filter is defined in cdc_ether.c
> Building of cdc_ether.o is controlled by USB_NET_CDCETHER
> 
> Building of cdc_ncm.o is controlled by USB_NET_CDC_NCM
> 
> So add a select USB_NET_CDCETHER to USB_NET_CDC_NCM
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

Please indicate the appropriate target tree ('net' or 'net-next') in
your Subject line f.e. "[PATCH net-next] ..."

Please provide an appropriate and properly formatted Fixes: tag.

Thank you.
diff mbox series

Patch

diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
index a7fbc3ccd29e..c7bcfca7d70b 100644
--- a/drivers/net/usb/Kconfig
+++ b/drivers/net/usb/Kconfig
@@ -252,6 +252,7 @@  config USB_NET_CDC_EEM
 config USB_NET_CDC_NCM
 	tristate "CDC NCM support"
 	depends on USB_USBNET
+	select USB_NET_CDCETHER
 	default y
 	help
 	  This driver provides support for CDC NCM (Network Control Model