diff mbox series

[v5,6/7] io: Document thread-safety of qio_channel_shutdown

Message ID 8d567c499f0d778501d57007b90ec3450aba9947.1592923201.git.lukasstraub2@web.de (mailing list archive)
State New, archived
Headers show
Series Introduce 'yank' oob qmp command to recover from hanging qemu | expand

Commit Message

Lukas Straub June 23, 2020, 2:42 p.m. UTC 
Migration and yank code assume that qio_channel_shutdown is thread
-safe. Document this after checking the code.

Signed-off-by: Lukas Straub <lukasstraub2@web.de>
---
 include/io/channel.h | 2 ++
 1 file changed, 2 insertions(+)

--
2.20.1

Comments

Daniel P. Berrangé July 28, 2020, 11:39 a.m. UTC | #1 
On Tue, Jun 23, 2020 at 04:42:59PM +0200, Lukas Straub wrote:
> Migration and yank code assume that qio_channel_shutdown is thread
> -safe. Document this after checking the code.
> 
> Signed-off-by: Lukas Straub <lukasstraub2@web.de>
> ---
>  include/io/channel.h | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
diff mbox series

Patch

diff --git a/include/io/channel.h b/include/io/channel.h
index d4557f0930..6b8a2b87b8 100644
--- a/include/io/channel.h
+++ b/include/io/channel.h
@@ -516,6 +516,8 @@  int qio_channel_close(QIOChannel *ioc,
  * QIO_CHANNEL_FEATURE_SHUTDOWN prior to calling
  * this method.
  *
+ * This function is thread-safe.
+ *
  * Returns: 0 on success, -1 on error
  */
 int qio_channel_shutdown(QIOChannel *ioc,