| Message ID | 20200729034436.24267-1-lihao2018.fnst@cn.fujitsu.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 49688e654e48ae176b5bfda33d2416b68e607ce8 |
| Headers | show |
| Series | dax: Fix wrong error-number passed into xas_set_err() | expand |
> The error-number passed into xas_set_err() should be negative. Otherwise, > the xas_error() will return 0, and grab_mapping_entry() will return the > found entry instead of a SIGBUS error when the entry is not a value. > And then, the subsequent code path would be wrong. > > Signed-off-by: Hao Li <lihao2018.fnst@cn.fujitsu.com> > --- > fs/dax.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/dax.c b/fs/dax.c > index 11b16729b86f..acac675fe7a6 100644 > --- a/fs/dax.c > +++ b/fs/dax.c > @@ -488,7 +488,7 @@ static void *grab_mapping_entry(struct xa_state *xas, > if (dax_is_conflict(entry)) > goto fallback; > if (!xa_is_value(entry)) { > - xas_set_err(xas, EIO); > + xas_set_err(xas, -EIO); > goto out_unlock; > } > Reviewed-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com> > -- > 2.28.0 > >
> The error-number passed into xas_set_err() should be negative. Otherwise, > the xas_error() will return 0, and grab_mapping_entry() will return the > found entry instead of a SIGBUS error when the entry is not a value. > And then, the subsequent code path would be wrong. > > Signed-off-by: Hao Li <lihao2018.fnst@cn.fujitsu.com> > --- > fs/dax.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/dax.c b/fs/dax.c > index 11b16729b86f..acac675fe7a6 100644 > --- a/fs/dax.c > +++ b/fs/dax.c > @@ -488,7 +488,7 @@ static void *grab_mapping_entry(struct xa_state *xas, > if (dax_is_conflict(entry)) > goto fallback; > if (!xa_is_value(entry)) { > - xas_set_err(xas, EIO); > + xas_set_err(xas, -EIO); > goto out_unlock; > } > > -- Reviewed-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com> > 2.28.0 > > > _______________________________________________ > Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org > To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
diff --git a/fs/dax.c b/fs/dax.c index 11b16729b86f..acac675fe7a6 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -488,7 +488,7 @@ static void *grab_mapping_entry(struct xa_state *xas, if (dax_is_conflict(entry)) goto fallback; if (!xa_is_value(entry)) { - xas_set_err(xas, EIO); + xas_set_err(xas, -EIO); goto out_unlock; }
The error-number passed into xas_set_err() should be negative. Otherwise, the xas_error() will return 0, and grab_mapping_entry() will return the found entry instead of a SIGBUS error when the entry is not a value. And then, the subsequent code path would be wrong. Signed-off-by: Hao Li <lihao2018.fnst@cn.fujitsu.com> --- fs/dax.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)