| Message ID | 20200728051153.1590-10-rppt@kernel.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | memblock: seasonal cleaning^w cleanup | expand |
On 07/28/20 at 08:11am, Mike Rapoport wrote: > From: Mike Rapoport <rppt@linux.ibm.com> > > for_each_memblock_type() is not used outside mm/memblock.c, move it there > from include/linux/memblock.h > > --- > include/linux/memblock.h | 5 ----- > mm/memblock.c | 5 +++++ > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/include/linux/memblock.h b/include/linux/memblock.h > index 017fae833d4a..220b5f0dad42 100644 > --- a/include/linux/memblock.h > +++ b/include/linux/memblock.h > @@ -532,11 +532,6 @@ static inline unsigned long memblock_region_reserved_end_pfn(const struct memblo > region < (memblock.memblock_type.regions + memblock.memblock_type.cnt); \ > region++) > > -#define for_each_memblock_type(i, memblock_type, rgn) \ > - for (i = 0, rgn = &memblock_type->regions[0]; \ > - i < memblock_type->cnt; \ > - i++, rgn = &memblock_type->regions[i]) > - > extern void *alloc_large_system_hash(const char *tablename, > unsigned long bucketsize, > unsigned long numentries, > diff --git a/mm/memblock.c b/mm/memblock.c > index 39aceafc57f6..a5b9b3df81fc 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -129,6 +129,11 @@ struct memblock memblock __initdata_memblock = { > .current_limit = MEMBLOCK_ALLOC_ANYWHERE, > }; > > +#define for_each_memblock_type(i, memblock_type, rgn) \ > + for (i = 0, rgn = &memblock_type->regions[0]; \ > + i < memblock_type->cnt; \ > + i++, rgn = &memblock_type->regions[i]) > + Reviewed-by: Baoquan He <bhe@redhat.com>
diff --git a/include/linux/memblock.h b/include/linux/memblock.h index 017fae833d4a..220b5f0dad42 100644 --- a/include/linux/memblock.h +++ b/include/linux/memblock.h @@ -532,11 +532,6 @@ static inline unsigned long memblock_region_reserved_end_pfn(const struct memblo region < (memblock.memblock_type.regions + memblock.memblock_type.cnt); \ region++) -#define for_each_memblock_type(i, memblock_type, rgn) \ - for (i = 0, rgn = &memblock_type->regions[0]; \ - i < memblock_type->cnt; \ - i++, rgn = &memblock_type->regions[i]) - extern void *alloc_large_system_hash(const char *tablename, unsigned long bucketsize, unsigned long numentries, diff --git a/mm/memblock.c b/mm/memblock.c index 39aceafc57f6..a5b9b3df81fc 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -129,6 +129,11 @@ struct memblock memblock __initdata_memblock = { .current_limit = MEMBLOCK_ALLOC_ANYWHERE, }; +#define for_each_memblock_type(i, memblock_type, rgn) \ + for (i = 0, rgn = &memblock_type->regions[0]; \ + i < memblock_type->cnt; \ + i++, rgn = &memblock_type->regions[i]) + int memblock_debug __initdata_memblock; static bool system_has_some_mirror __initdata_memblock = false; static int memblock_can_resize __initdata_memblock;