| Message ID | bb8884e4-ef88-90cc-5ab6-0af639452696@monstr.eu (mailing list archive) |
|---|---|
| State | Changes Requested |
| Commit | d2b8ae385c153cc0ea32ce6db0537f35271e09fa |
| Headers | show |
| Series | [GIT,PULL] ARM: soc: Xilinx SOC changes for v5.9 | expand |
On Thu, Jul 30, 2020 at 7:39 AM Michal Simek <monstr@monstr.eu> wrote: > > Rajan Vaja (1): > drivers: soc: xilinx: Call InitFinalize from late_initcall_sync instead of probe I looked at the contents and decided not to pull this one branch, as it looks like this patch would introduce a regression on all non-zynq machines. Rajan, please check this patch again and make sure that we do not call a zynq specific interface without ensuring that the kernel is actually running on zynq. That check might be there, but I could not see how it is ensured. Generally speaking, initcall() needs be used very carefully. Arnd
Hi Arnd, > -----Original Message----- > From: Arnd Bergmann <arnd@arndb.de> > Sent: 31 July 2020 01:57 PM > To: monstr@monstr.eu > Cc: arm-soc <arm@kernel.org>; SoC Team <soc@kernel.org>; linux-arm-kernel > <linux-arm-kernel@lists.infradead.org>; Rajan Vaja <RAJANV@xilinx.com> > Subject: Re: [GIT PULL] ARM: soc: Xilinx SOC changes for v5.9 > > CAUTION: This message has originated from an External Source. Please use proper > judgment and caution when opening attachments, clicking links, or responding to > this email. > > > On Thu, Jul 30, 2020 at 7:39 AM Michal Simek <monstr@monstr.eu> wrote: > > > > > Rajan Vaja (1): > > drivers: soc: xilinx: Call InitFinalize from late_initcall_sync instead of probe > > I looked at the contents and decided not to pull this one branch, as it looks > like this patch would introduce a regression on all non-zynq machines. > > Rajan, please check this patch again and make sure that we do not > call a zynq specific interface without ensuring that the kernel is actually > running on zynq. That check might be there, but I could not see how it > is ensured. Generally speaking, initcall() needs be used very carefully. [Rajan] Yes. I will update and fix it in new version. Thanks for catching it. Thanks, Rajan [Rajan] > > Arnd
Hi, On 31. 07. 20 10:27, Arnd Bergmann wrote: > On Thu, Jul 30, 2020 at 7:39 AM Michal Simek <monstr@monstr.eu> wrote: > >> >> Rajan Vaja (1): >> drivers: soc: xilinx: Call InitFinalize from late_initcall_sync instead of probe > > I looked at the contents and decided not to pull this one branch, as it looks > like this patch would introduce a regression on all non-zynq machines. > > Rajan, please check this patch again and make sure that we do not > call a zynq specific interface without ensuring that the kernel is actually > running on zynq. That check might be there, but I could not see how it > is ensured. Generally speaking, initcall() needs be used very carefully. ok. Let me send a pull request with only that patch from Dan. Or if you want to take it directly I am also fine with it. Thanks, Michal
Hi, please pull these two patches to your tree. I know it is kind of late that's why feel free to take it after rc1. Thanks, Michal The following changes since commit b3a9e3b9622ae10064826dccb4f7a52bd88c7407: Linux 5.8-rc1 (2020-06-14 12:45:04 -0700) are available in the Git repository at: https://github.com/Xilinx/linux-xlnx.git tags/zynqmp-soc-for-v5.9 for you to fetch changes up to aa0962ab91e1a13ad650cfd590ddb16c7ab0acf7: drivers: soc: xilinx: Call InitFinalize from late_initcall_sync instead of probe (2020-07-30 07:30:38 +0200) ---------------------------------------------------------------- arm64: soc: ZynqMP SoC changes for v5.9 - Fix error code - Power down unused devices later in boot process ---------------------------------------------------------------- Dan Carpenter (1): soc: xilinx: Fix error code in zynqmp_pm_probe() Rajan Vaja (1): drivers: soc: xilinx: Call InitFinalize from late_initcall_sync instead of probe drivers/soc/xilinx/zynqmp_power.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)