[OSSTEST,v2,19/41] Executive: Drop redundant AND clause

Commit Message

Ian Jackson July 31, 2020, 11:37 a.m. UTC

In "Executive: Use index for report__find_test" we changed an EXISTS
subquery into a JOIN.

Now, the condition r.flight=f.flight is redundant because this is the
join column (from USING).

No functional change.

CC: George Dunlap <[e-mail]>
Signed-off-by: Ian Jackson <[e-mail]>
---
 Osstest/Executive.pm | 1 -
 1 file changed, 1 deletion(-)

Comments

George Dunlap July 31, 2020, 2:17 p.m. UTC | #1

> On Jul 31, 2020, at 12:37 PM, Ian Jackson <[e-mail]> wrote:
> 
> In "Executive: Use index for report__find_test" we changed an EXISTS
> subquery into a JOIN.
> 
> Now, the condition r.flight=f.flight is redundant because this is the
> join column (from USING).
> 
> No functional change.
> 
> CC: George Dunlap <[e-mail]>
> Signed-off-by: Ian Jackson <[e-mail]>

Reviewed-by: George Dunlap <[e-mail]>

Patch

diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm
index 684cafc3..2f81e89d 100644
--- a/Osstest/Executive.pm
+++ b/Osstest/Executive.pm
@@ -433,7 +433,6 @@  END
 		   WHERE name=?
                      AND name LIKE 'revision\_%'
 		     AND val=?
-		     AND r.flight=f.flight
                      AND ${\ main_revision_job_cond('r.job') }
 END
             push @params, "revision_$tree", $revision;