| Message ID | 20200731165140.29197-2-alban.gruin@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | stash: drop usage of a second index | expand |
Alban Gruin <alban.gruin@gmail.com> writes: > In reset_tree(), the value pointed by `i_tree' is not modified. In a This helper function is about "reset the working tree and the index to match this given tree object" and it is clear that it is an input-only parameter, so that alone is a good justification for code hygiene. Good. > latter commit, it will be provided with `the_hash_algo->empty_tree', > which is a constant. Hence, this changes `i_tree' to be a constant. > > Signed-off-by: Alban Gruin <alban.gruin@gmail.com> > --- > builtin/stash.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/builtin/stash.c b/builtin/stash.c > index 0c52a3b849..9baa8b379e 100644 > --- a/builtin/stash.c > +++ b/builtin/stash.c > @@ -228,7 +228,7 @@ static int clear_stash(int argc, const char **argv, const char *prefix) > return do_clear_stash(); > } > > -static int reset_tree(struct object_id *i_tree, int update, int reset) > +static int reset_tree(const struct object_id *i_tree, int update, int reset) > { > int nr_trees = 1; > struct unpack_trees_options opts;
diff --git a/builtin/stash.c b/builtin/stash.c index 0c52a3b849..9baa8b379e 100644 --- a/builtin/stash.c +++ b/builtin/stash.c @@ -228,7 +228,7 @@ static int clear_stash(int argc, const char **argv, const char *prefix) return do_clear_stash(); } -static int reset_tree(struct object_id *i_tree, int update, int reset) +static int reset_tree(const struct object_id *i_tree, int update, int reset) { int nr_trees = 1; struct unpack_trees_options opts;
In reset_tree(), the value pointed by `i_tree' is not modified. In a latter commit, it will be provided with `the_hash_algo->empty_tree', which is a constant. Hence, this changes `i_tree' to be a constant. Signed-off-by: Alban Gruin <alban.gruin@gmail.com> --- builtin/stash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)