| Message ID | 20200731104555.v3.15.I4c344a6793007001bbb3c1c08e96d3acf893b36b@changeid (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | sx9310 iio driver updates | expand |
On Fri, Jul 31, 2020 at 7:49 PM Daniel Campello <campello@chromium.org> wrote: > > From: Stephen Boyd <swboyd@chromium.org> > > We shouldn't need to set default irq trigger flags here as the firmware > should have properly indicated the trigger type, i.e. level low, in the > DT or ACPI tables. Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > Signed-off-by: Daniel Campello <campello@chromium.org> > --- > > Changes in v3: > - Added irq trigger flags commit to the series. > > Changes in v2: None > > drivers/iio/proximity/sx9310.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/proximity/sx9310.c b/drivers/iio/proximity/sx9310.c > index a20cd6a4dad729..c41fa7f6558e3f 100644 > --- a/drivers/iio/proximity/sx9310.c > +++ b/drivers/iio/proximity/sx9310.c > @@ -951,7 +951,7 @@ static int sx9310_probe(struct i2c_client *client) > ret = devm_request_threaded_irq(dev, client->irq, > sx9310_irq_handler, > sx9310_irq_thread_handler, > - IRQF_TRIGGER_LOW | IRQF_ONESHOT, > + IRQF_ONESHOT, > "sx9310_event", indio_dev); > if (ret) > return ret; > -- > 2.28.0.163.g6104cc2f0b6-goog >
On Fri, 31 Jul 2020 22:46:55 +0300 Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Fri, Jul 31, 2020 at 7:49 PM Daniel Campello <campello@chromium.org> wrote: > > > > From: Stephen Boyd <swboyd@chromium.org> > > > > We shouldn't need to set default irq trigger flags here as the firmware > > should have properly indicated the trigger type, i.e. level low, in the > > DT or ACPI tables. > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Other than the two patches I replied to the rest look good to me. Thanks, Jonathan > > > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > > Signed-off-by: Daniel Campello <campello@chromium.org> > > --- > > > > Changes in v3: > > - Added irq trigger flags commit to the series. > > > > Changes in v2: None > > > > drivers/iio/proximity/sx9310.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/iio/proximity/sx9310.c b/drivers/iio/proximity/sx9310.c > > index a20cd6a4dad729..c41fa7f6558e3f 100644 > > --- a/drivers/iio/proximity/sx9310.c > > +++ b/drivers/iio/proximity/sx9310.c > > @@ -951,7 +951,7 @@ static int sx9310_probe(struct i2c_client *client) > > ret = devm_request_threaded_irq(dev, client->irq, > > sx9310_irq_handler, > > sx9310_irq_thread_handler, > > - IRQF_TRIGGER_LOW | IRQF_ONESHOT, > > + IRQF_ONESHOT, > > "sx9310_event", indio_dev); > > if (ret) > > return ret; > > -- > > 2.28.0.163.g6104cc2f0b6-goog > > > >
diff --git a/drivers/iio/proximity/sx9310.c b/drivers/iio/proximity/sx9310.c index a20cd6a4dad729..c41fa7f6558e3f 100644 --- a/drivers/iio/proximity/sx9310.c +++ b/drivers/iio/proximity/sx9310.c @@ -951,7 +951,7 @@ static int sx9310_probe(struct i2c_client *client) ret = devm_request_threaded_irq(dev, client->irq, sx9310_irq_handler, sx9310_irq_thread_handler, - IRQF_TRIGGER_LOW | IRQF_ONESHOT, + IRQF_ONESHOT, "sx9310_event", indio_dev); if (ret) return ret;