diff mbox series

[4.4.y-cip] ARM: dts: iwg22d-sodimm: Enable touchscreen

Message ID 20200729105621.8242-1-biju.das.jz@bp.renesas.com (mailing list archive)
State Accepted
Delegated to: Nobuhiro Iwamatsu
Headers show
Series [4.4.y-cip] ARM: dts: iwg22d-sodimm: Enable touchscreen | expand

Commit Message

Biju Das July 29, 2020, 10:56 a.m. UTC 
From: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>

commit 99ae78f1fc3a73c88fe726c676ae963ce722bf20 upstream.

In one of the iWave-G22D development board variants, called Generic SODIMM
Development Platform, we have an LCD with touchscreen. The resistive touch
controller, STMPE811 is on the development board and is connected through
the i2c5 of the RZ-G1E.

Additionally, this controller should generate an interrupt to the CPU and
it is connected through GPIO4,4 to the GIC.

Touch was tested with one of our iW-RainboW-G22D-SODIMM RZ/G1E development
platforms.

More details on the iWave website:
https://www.iwavesystems.com/rz-g1e-sodimm-development-kit.html

Signed-off-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
Link: https://lore.kernel.org/r/1583336650-25848-1-git-send-email-marian-cristian.rotariu.rb@bp.renesas.com
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts | 33 +++++++++++++++++++++
 1 file changed, 33 insertions(+)

Comments

Nobuhiro Iwamatsu July 30, 2020, 1:12 a.m. UTC | #1 
Hi,

> -----Original Message-----
> From: Biju Das [mailto:biju.das.jz@bp.renesas.com]
> Sent: Wednesday, July 29, 2020 7:56 PM
> To: cip-dev@lists.cip-project.org; iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ)
> <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de>
> Cc: Chris Paterson <chris.paterson2@renesas.com>; Biju Das <biju.das.jz@bp.renesas.com>; Prabhakar Mahadev Lad
> <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Subject: [PATCH 4.4.y-cip] ARM: dts: iwg22d-sodimm: Enable touchscreen
> 
> From: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> 
> commit 99ae78f1fc3a73c88fe726c676ae963ce722bf20 upstream.
> 
> In one of the iWave-G22D development board variants, called Generic SODIMM
> Development Platform, we have an LCD with touchscreen. The resistive touch
> controller, STMPE811 is on the development board and is connected through
> the i2c5 of the RZ-G1E.
> 
> Additionally, this controller should generate an interrupt to the CPU and
> it is connected through GPIO4,4 to the GIC.
> 
> Touch was tested with one of our iW-RainboW-G22D-SODIMM RZ/G1E development
> platforms.
> 
> More details on the iWave website:
> https://www.iwavesystems.com/rz-g1e-sodimm-development-kit.html
> 
> Signed-off-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> Link: https://lore.kernel.org/r/1583336650-25848-1-git-send-email-marian-cristian.rotariu.rb@bp.renesas.com
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

There seems to be no issue with this patch, but we also need to update defcofnig.
If there is no other objection, I will apply this.

Best regards,
  Nobuhiro


> ---
>  arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts | 33 +++++++++++++++++++++
>  1 file changed, 33 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
> index 1e331d1e414b..5cd989556b60 100644
> --- a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
> +++ b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
> @@ -149,6 +149,39 @@
>  	status = "okay";
>  	clock-frequency = <400000>;
> 
> +	stmpe811@44 {
> +		compatible = "st,stmpe811";
> +		reg = <0x44>;
> +		interrupt-parent = <&gpio4>;
> +		interrupts = <4 IRQ_TYPE_LEVEL_LOW>;
> +
> +		/* 3.25 MHz ADC clock speed */
> +		st,adc-freq = <1>;
> +		/* ADC converstion time: 80 clocks */
> +		st,sample-time = <4>;
> +		/* 12-bit ADC */
> +		st,mod-12b = <1>;
> +		/* internal ADC reference */
> +		st,ref-sel = <0>;
> +
> +		stmpe_touchscreen {
> +			compatible = "st,stmpe-ts";
> +			/* 8 sample average control */
> +			st,ave-ctrl = <3>;
> +			/* 7 length fractional part in z */
> +			st,fraction-z = <7>;
> +			/*
> +			 * 50 mA typical 80 mA max touchscreen drivers
> +			 * current limit value
> +			 */
> +			st,i-drive = <1>;
> +			/* 1 ms panel driver settling time */
> +			st,settling = <3>;
> +			/* 5 ms touch detect interrupt delay */
> +			st,touch-det-delay = <5>;
> +		};
> +	};
> +
>  	sgtl5000: codec@a {
>  		compatible = "fsl,sgtl5000";
>  		#sound-dai-cells = <0>;
> --
> 2.17.1
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#5055): https://lists.cip-project.org/g/cip-dev/message/5055
Mute This Topic: https://lists.cip-project.org/mt/75862490/4520428
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129116/1171672734/xyzzy  [patchwork-cip-dev@patchwork.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
Biju Das July 30, 2020, 7:10 a.m. UTC | #2 
Hi Nobuhiro-san,

Thanks for the feedback.

> Subject: RE: [PATCH 4.4.y-cip] ARM: dts: iwg22d-sodimm: Enable touchscreen
>
> Hi,
>
> > -----Original Message-----
> > From: Biju Das [mailto:biju.das.jz@bp.renesas.com]
> > Sent: Wednesday, July 29, 2020 7:56 PM
> > To: cip-dev@lists.cip-project.org; iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ
> ◯ＡＣＴ)
> > <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de>
> > Cc: Chris Paterson <chris.paterson2@renesas.com>; Biju Das
> > <biju.das.jz@bp.renesas.com>; Prabhakar Mahadev Lad
> > <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > Subject: [PATCH 4.4.y-cip] ARM: dts: iwg22d-sodimm: Enable touchscreen
> >
> > From: Marian-Cristian Rotariu
> > <marian-cristian.rotariu.rb@bp.renesas.com>
> >
> > commit 99ae78f1fc3a73c88fe726c676ae963ce722bf20 upstream.
> >
> > In one of the iWave-G22D development board variants, called Generic
> > SODIMM Development Platform, we have an LCD with touchscreen. The
> > resistive touch controller, STMPE811 is on the development board and
> > is connected through the i2c5 of the RZ-G1E.
> >
> > Additionally, this controller should generate an interrupt to the CPU
> > and it is connected through GPIO4,4 to the GIC.
> >
> > Touch was tested with one of our iW-RainboW-G22D-SODIMM RZ/G1E
> > development platforms.
> >
> > More details on the iWave website:
> > https://www.iwavesystems.com/rz-g1e-sodimm-development-kit.html
> >
> > Signed-off-by: Marian-Cristian Rotariu
> > <marian-cristian.rotariu.rb@bp.renesas.com>
> > Link:
> > https://lore.kernel.org/r/1583336650-25848-1-git-send-email-marian-cri
> > stian.rotariu.rb@bp.renesas.com
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
>
> There seems to be no issue with this patch, but we also need to update
> defcofnig.

We need to enable the below configs in shmobile_defconfig. Currently this configs are not enabled in
Mainline. Not sure we should upstream this  and backport it or Just enable it in cip-kernel-config? Please let me know.

CONFIG_MFD_STMPE=y
CONFIG_STMPE_I2C=y
CONFIG_TOUCHSCREEN_STMPE=y

Cheers,
Biju


Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#5076): https://lists.cip-project.org/g/cip-dev/message/5076
Mute This Topic: https://lists.cip-project.org/mt/75862490/4520428
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129116/1171672734/xyzzy  [patchwork-cip-dev@patchwork.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
Pavel Machek July 30, 2020, 9:47 a.m. UTC | #3 
Hi!

> > Subject: [PATCH 4.4.y-cip] ARM: dts: iwg22d-sodimm: Enable touchscreen
> > 
> > From: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> > 
> > commit 99ae78f1fc3a73c88fe726c676ae963ce722bf20 upstream.
> 
> There seems to be no issue with this patch, but we also need to update defcofnig.
> If there is no other objection, I will apply this.
>

Patch looks good to me, too.

Best regards,
								Pavel
Nobuhiro Iwamatsu July 31, 2020, 8:03 p.m. UTC | #4 
Hi,

> -----Original Message-----
> From: Biju Das [mailto:biju.das.jz@bp.renesas.com]
> Sent: Thursday, July 30, 2020 4:11 PM
> To: iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ) <nobuhiro1.iwamatsu@toshiba.co.jp>; cip-dev@lists.cip-project.org
> Cc: Chris Paterson <Chris.Paterson2@renesas.com>; Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Subject: RE: [PATCH 4.4.y-cip] ARM: dts: iwg22d-sodimm: Enable touchscreen
> 
> Hi Nobuhiro-san,
> 
> Thanks for the feedback.
> 
> > Subject: RE: [PATCH 4.4.y-cip] ARM: dts: iwg22d-sodimm: Enable touchscreen
> >
> > Hi,
> >
> > > -----Original Message-----
> > > From: Biju Das [mailto:biju.das.jz@bp.renesas.com]
> > > Sent: Wednesday, July 29, 2020 7:56 PM
> > > To: cip-dev@lists.cip-project.org; iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ
> > ◯ＡＣＴ)
> > > <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de>
> > > Cc: Chris Paterson <chris.paterson2@renesas.com>; Biju Das
> > > <biju.das.jz@bp.renesas.com>; Prabhakar Mahadev Lad
> > > <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > Subject: [PATCH 4.4.y-cip] ARM: dts: iwg22d-sodimm: Enable touchscreen
> > >
> > > From: Marian-Cristian Rotariu
> > > <marian-cristian.rotariu.rb@bp.renesas.com>
> > >
> > > commit 99ae78f1fc3a73c88fe726c676ae963ce722bf20 upstream.
> > >
> > > In one of the iWave-G22D development board variants, called Generic
> > > SODIMM Development Platform, we have an LCD with touchscreen. The
> > > resistive touch controller, STMPE811 is on the development board and
> > > is connected through the i2c5 of the RZ-G1E.
> > >
> > > Additionally, this controller should generate an interrupt to the CPU
> > > and it is connected through GPIO4,4 to the GIC.
> > >
> > > Touch was tested with one of our iW-RainboW-G22D-SODIMM RZ/G1E
> > > development platforms.
> > >
> > > More details on the iWave website:
> > > https://www.iwavesystems.com/rz-g1e-sodimm-development-kit.html
> > >
> > > Signed-off-by: Marian-Cristian Rotariu
> > > <marian-cristian.rotariu.rb@bp.renesas.com>
> > > Link:
> > > https://lore.kernel.org/r/1583336650-25848-1-git-send-email-marian-cri
> > > stian.rotariu.rb@bp.renesas.com
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> >
> > There seems to be no issue with this patch, but we also need to update
> > defcofnig.
> 
> We need to enable the below configs in shmobile_defconfig. Currently this configs are not enabled in
> Mainline. Not sure we should upstream this  and backport it or Just enable it in cip-kernel-config? Please let me know.
> 
> CONFIG_MFD_STMPE=y
> CONFIG_STMPE_I2C=y
> CONFIG_TOUCHSCREEN_STMPE=y

First, I think it's a good to post the patch to enable this to Upstream.

Best regards,
  Nobuhirio

> 
> Cheers,
> Biju
> 
> 
> Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office:
> Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708
> USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#5077): https://lists.cip-project.org/g/cip-dev/message/5077
Mute This Topic: https://lists.cip-project.org/mt/75862490/4520428
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129116/1171672734/xyzzy  [patchwork-cip-dev@patchwork.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
Nobuhiro Iwamatsu July 31, 2020, 8:04 p.m. UTC | #5 
Hi,

> -----Original Message-----
> From: cip-dev@lists.cip-project.org [mailto:cip-dev@lists.cip-project.org] On Behalf Of Pavel Machek
> Sent: Thursday, July 30, 2020 6:47 PM
> To: iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ) <nobuhiro1.iwamatsu@toshiba.co.jp>
> Cc: biju.das.jz@bp.renesas.com; cip-dev@lists.cip-project.org; pavel@denx.de; chris.paterson2@renesas.com;
> prabhakar.mahadev-lad.rj@bp.renesas.com
> Subject: Re: [cip-dev] [PATCH 4.4.y-cip] ARM: dts: iwg22d-sodimm: Enable touchscreen
> 
> Hi!
> 
> > > Subject: [PATCH 4.4.y-cip] ARM: dts: iwg22d-sodimm: Enable touchscreen
> > >
> > > From: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> > >
> > > commit 99ae78f1fc3a73c88fe726c676ae963ce722bf20 upstream.
> >
> > There seems to be no issue with this patch, but we also need to update defcofnig.
> > If there is no other objection, I will apply this.
> >
> 
> Patch looks good to me, too.
> 
Applied, thanks.

> Best regards,
> 								Pavel

Best regards,
  Nobuhiro

> --
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#5078): https://lists.cip-project.org/g/cip-dev/message/5078
Mute This Topic: https://lists.cip-project.org/mt/75862490/4520428
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129116/1171672734/xyzzy  [patchwork-cip-dev@patchwork.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
Biju Das Aug. 1, 2020, 9:55 a.m. UTC | #6 
Hi Nobuhiro-San,

Thanks for the feedback.

> Subject: RE: [PATCH 4.4.y-cip] ARM: dts: iwg22d-sodimm: Enable touchscreen
>
> > Subject: RE: [PATCH 4.4.y-cip] ARM: dts: iwg22d-sodimm: Enable
> > touchscreen
> >
> > Hi Nobuhiro-san,
> >
> > Thanks for the feedback.
> >
> > > Subject: RE: [PATCH 4.4.y-cip] ARM: dts: iwg22d-sodimm: Enable
> > > touchscreen
> > >
> > > Hi,
> > >
> > > > -----Original Message-----
> > > > From: Biju Das [mailto:biju.das.jz@bp.renesas.com]
> > > > Sent: Wednesday, July 29, 2020 7:56 PM
> > > > To: cip-dev@lists.cip-project.org; iwamatsu nobuhiro(岩松 信洋 □Ｓ
> ＷＣ
> > > ◯ＡＣＴ)
> > > > <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek
> <pavel@denx.de>
> > > > Cc: Chris Paterson <chris.paterson2@renesas.com>; Biju Das
> > > > <biju.das.jz@bp.renesas.com>; Prabhakar Mahadev Lad
> > > > <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > > Subject: [PATCH 4.4.y-cip] ARM: dts: iwg22d-sodimm: Enable
> > > > touchscreen
> > > >
> > > > From: Marian-Cristian Rotariu
> > > > <marian-cristian.rotariu.rb@bp.renesas.com>
> > > >
> > > > commit 99ae78f1fc3a73c88fe726c676ae963ce722bf20 upstream.
> > > >
> > > > In one of the iWave-G22D development board variants, called
> > > > Generic SODIMM Development Platform, we have an LCD with
> > > > touchscreen. The resistive touch controller, STMPE811 is on the
> > > > development board and is connected through the i2c5 of the RZ-G1E.
> > > >
> > > > Additionally, this controller should generate an interrupt to the
> > > > CPU and it is connected through GPIO4,4 to the GIC.
> > > >
> > > > Touch was tested with one of our iW-RainboW-G22D-SODIMM RZ/G1E
> > > > development platforms.
> > > >
> > > > More details on the iWave website:
> > > > https://www.iwavesystems.com/rz-g1e-sodimm-development-
> kit.html
> > > >
> > > > Signed-off-by: Marian-Cristian Rotariu
> > > > <marian-cristian.rotariu.rb@bp.renesas.com>
> > > > Link:
> > > > https://lore.kernel.org/r/1583336650-25848-1-git-send-email-marian
> > > > -cri
> > > > stian.rotariu.rb@bp.renesas.com
> > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > >
> > > There seems to be no issue with this patch, but we also need to
> > > update defcofnig.
> >
> > We need to enable the below configs in shmobile_defconfig. Currently
> > this configs are not enabled in Mainline. Not sure we should upstream this
> and backport it or Just enable it in cip-kernel-config? Please let me know.
> >
> > CONFIG_MFD_STMPE=y
> > CONFIG_STMPE_I2C=y
> > CONFIG_TOUCHSCREEN_STMPE=y
>
> First, I think it's a good to post the patch to enable this to Upstream.

Sure will  do.

Cheers,
Biju


Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#5080): https://lists.cip-project.org/g/cip-dev/message/5080
Mute This Topic: https://lists.cip-project.org/mt/75862490/4520428
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129116/1171672734/xyzzy  [patchwork-cip-dev@patchwork.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
index 1e331d1e414b..5cd989556b60 100644
--- a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
+++ b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
@@ -149,6 +149,39 @@ 
 	status = "okay";
 	clock-frequency = <400000>;
 
+	stmpe811@44 {
+		compatible = "st,stmpe811";
+		reg = <0x44>;
+		interrupt-parent = <&gpio4>;
+		interrupts = <4 IRQ_TYPE_LEVEL_LOW>;
+
+		/* 3.25 MHz ADC clock speed */
+		st,adc-freq = <1>;
+		/* ADC converstion time: 80 clocks */
+		st,sample-time = <4>;
+		/* 12-bit ADC */
+		st,mod-12b = <1>;
+		/* internal ADC reference */
+		st,ref-sel = <0>;
+
+		stmpe_touchscreen {
+			compatible = "st,stmpe-ts";
+			/* 8 sample average control */
+			st,ave-ctrl = <3>;
+			/* 7 length fractional part in z */
+			st,fraction-z = <7>;
+			/*
+			 * 50 mA typical 80 mA max touchscreen drivers
+			 * current limit value
+			 */
+			st,i-drive = <1>;
+			/* 1 ms panel driver settling time */
+			st,settling = <3>;
+			/* 5 ms touch detect interrupt delay */
+			st,touch-det-delay = <5>;
+		};
+	};
+
 	sgtl5000: codec@a {
 		compatible = "fsl,sgtl5000";
 		#sound-dai-cells = <0>;