| Message ID | 20200804065158.21049-1-tzimmermann@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/mgag200: Set PCI option register in G200SE models | expand |
On Tue, 4 Aug 2020 at 16:52, Thomas Zimmermann <tzimmermann@suse.de> wrote: > > The initial value of the PCI option register got lost while refactoring > the driver init code. Restore the setting. > Ooops, Reviewed-by: Dave Airlie <airlied@redhat.com> > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > Reported-by: kernel test robot <lkp@intel.com> > Fixes: 2021708e0d6e ("drm/mgag200: Initialize PCI registers early during device setup") > Cc: Lyude Paul <lyude@redhat.com> > Cc: Dave Airlie <airlied@redhat.com> > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: Gerd Hoffmann <kraxel@redhat.com> > Cc: Emil Velikov <emil.velikov@collabora.com> > --- > drivers/gpu/drm/mgag200/mgag200_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c > index 5c854bc7dc86..09170d46aa53 100644 > --- a/drivers/gpu/drm/mgag200/mgag200_drv.c > +++ b/drivers/gpu/drm/mgag200/mgag200_drv.c > @@ -74,6 +74,7 @@ static int mgag200_regs_init(struct mga_device *mdev) > break; > case G200_SE_A: > case G200_SE_B: > + option = 0x40049120; > if (mgag200_has_sgram(mdev)) > option |= PCI_MGA_OPTION_HARDPWMSK; > option2 = 0x00008000; > -- > 2.28.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c index 5c854bc7dc86..09170d46aa53 100644 --- a/drivers/gpu/drm/mgag200/mgag200_drv.c +++ b/drivers/gpu/drm/mgag200/mgag200_drv.c @@ -74,6 +74,7 @@ static int mgag200_regs_init(struct mga_device *mdev) break; case G200_SE_A: case G200_SE_B: + option = 0x40049120; if (mgag200_has_sgram(mdev)) option |= PCI_MGA_OPTION_HARDPWMSK; option2 = 0x00008000;
The initial value of the PCI option register got lost while refactoring the driver init code. Restore the setting. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Reported-by: kernel test robot <lkp@intel.com> Fixes: 2021708e0d6e ("drm/mgag200: Initialize PCI registers early during device setup") Cc: Lyude Paul <lyude@redhat.com> Cc: Dave Airlie <airlied@redhat.com> Cc: Sam Ravnborg <sam@ravnborg.org> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Gerd Hoffmann <kraxel@redhat.com> Cc: Emil Velikov <emil.velikov@collabora.com> --- drivers/gpu/drm/mgag200/mgag200_drv.c | 1 + 1 file changed, 1 insertion(+)