| Message ID | 20200803042944.26465-1-marcos@mpdesouza.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [btrfs-progs] Documentation: btrfs-man5: Remove nonexistent nousebackuproot option | expand |
On Mon, Aug 3, 2020 at 1:05 AM Marcos Paulo de Souza <marcos@mpdesouza.com> wrote: > > From: Marcos Paulo de Souza <mpdesouza@suse.com> > > Since it's inclusion in b3751c131 ("btrfs-progs: docs: update > btrfs-man5"), this option was never available in kernel, we can only > enable this option using usebackuproot. > > Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com> > --- > Documentation/btrfs-man5.asciidoc | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Documentation/btrfs-man5.asciidoc b/Documentation/btrfs-man5.asciidoc > index 064312ed..2edf721c 100644 > --- a/Documentation/btrfs-man5.asciidoc > +++ b/Documentation/btrfs-man5.asciidoc > @@ -471,7 +471,6 @@ The tree log could contain new files/directories, these would not exist on > a mounted filesystem if the log is not replayed. > > *usebackuproot*:: > -*nousebackuproot*:: > (since: 4.6, default: off) > + > Enable autorecovery attempts if a bad tree root is found at mount time. > -- > 2.27.0 > Shouldn't this option be plumbed through instead?
On Mon, 2020-08-03 at 21:24 -0400, Neal Gompa wrote: > On Mon, Aug 3, 2020 at 1:05 AM Marcos Paulo de Souza > <marcos@mpdesouza.com> wrote: > > > > From: Marcos Paulo de Souza <mpdesouza@suse.com> > > > > Since it's inclusion in b3751c131 ("btrfs-progs: docs: update > > btrfs-man5"), this option was never available in kernel, we can > only > > enable this option using usebackuproot. > > > > Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com> > > --- > > Documentation/btrfs-man5.asciidoc | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/Documentation/btrfs-man5.asciidoc > b/Documentation/btrfs-man5.asciidoc > > index 064312ed..2edf721c 100644 > > --- a/Documentation/btrfs-man5.asciidoc > > +++ b/Documentation/btrfs-man5.asciidoc > > @@ -471,7 +471,6 @@ The tree log could contain new > files/directories, these would not exist on > > a mounted filesystem if the log is not replayed. > > > > *usebackuproot*:: > > -*nousebackuproot*:: > > (since: 4.6, default: off) > > + > > Enable autorecovery attempts if a bad tree root is found at mount > time. > > -- > > 2.27.0 > > > > Shouldn't this option be plumbed through instead? As this option is only used at mount time, I don't see why we should be able to disable using remount for example. Am I missing something? Thanks, Marcos
On 4.08.20 г. 5:57 ч., Marcos Paulo de Souza wrote: > On Mon, 2020-08-03 at 21:24 -0400, Neal Gompa wrote: >> On Mon, Aug 3, 2020 at 1:05 AM Marcos Paulo de Souza >> <marcos@mpdesouza.com> wrote: >>> >>> From: Marcos Paulo de Souza <mpdesouza@suse.com> >>> >>> Since it's inclusion in b3751c131 ("btrfs-progs: docs: update >>> btrfs-man5"), this option was never available in kernel, we can >> only >>> enable this option using usebackuproot. >>> >>> Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com> >>> --- >>> Documentation/btrfs-man5.asciidoc | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/Documentation/btrfs-man5.asciidoc >> b/Documentation/btrfs-man5.asciidoc >>> index 064312ed..2edf721c 100644 >>> --- a/Documentation/btrfs-man5.asciidoc >>> +++ b/Documentation/btrfs-man5.asciidoc >>> @@ -471,7 +471,6 @@ The tree log could contain new >> files/directories, these would not exist on >>> a mounted filesystem if the log is not replayed. >>> >>> *usebackuproot*:: >>> -*nousebackuproot*:: >>> (since: 4.6, default: off) >>> + >>> Enable autorecovery attempts if a bad tree root is found at mount >> time. >>> -- >>> 2.27.0 >>> >> >> Shouldn't this option be plumbed through instead? > > As this option is only used at mount time, I don't see why we should be > able to disable using remount for example. Am I missing something? > The default is to not use backup roots, so there's no point in having it as an explicit option. > Thanks, > Marcos >
On 3.08.20 г. 7:29 ч., Marcos Paulo de Souza wrote: > From: Marcos Paulo de Souza <mpdesouza@suse.com> > > Since it's inclusion in b3751c131 ("btrfs-progs: docs: update > btrfs-man5"), this option was never available in kernel, we can only > enable this option using usebackuproot. > > Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com> Reviewed-by: Nikolay Borisov <nborisov@suse.com>
On Mon, Aug 3, 2020 at 1:05 AM Marcos Paulo de Souza <marcos@mpdesouza.com> wrote: > > From: Marcos Paulo de Souza <mpdesouza@suse.com> > > Since it's inclusion in b3751c131 ("btrfs-progs: docs: update > btrfs-man5"), this option was never available in kernel, we can only > enable this option using usebackuproot. > > Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com> > --- > Documentation/btrfs-man5.asciidoc | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Documentation/btrfs-man5.asciidoc b/Documentation/btrfs-man5.asciidoc > index 064312ed..2edf721c 100644 > --- a/Documentation/btrfs-man5.asciidoc > +++ b/Documentation/btrfs-man5.asciidoc > @@ -471,7 +471,6 @@ The tree log could contain new files/directories, these would not exist on > a mounted filesystem if the log is not replayed. > > *usebackuproot*:: > -*nousebackuproot*:: > (since: 4.6, default: off) > + > Enable autorecovery attempts if a bad tree root is found at mount time. > -- > 2.27.0 > Reviewed-by: Neal Gompa <ngompa13@gmail.com>
On Mon, Aug 03, 2020 at 01:29:44AM -0300, Marcos Paulo de Souza wrote: > From: Marcos Paulo de Souza <mpdesouza@suse.com> > > Since it's inclusion in b3751c131 ("btrfs-progs: docs: update > btrfs-man5"), this option was never available in kernel, we can only > enable this option using usebackuproot. > > Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com> Added to devel, thanks.
diff --git a/Documentation/btrfs-man5.asciidoc b/Documentation/btrfs-man5.asciidoc index 064312ed..2edf721c 100644 --- a/Documentation/btrfs-man5.asciidoc +++ b/Documentation/btrfs-man5.asciidoc @@ -471,7 +471,6 @@ The tree log could contain new files/directories, these would not exist on a mounted filesystem if the log is not replayed. *usebackuproot*:: -*nousebackuproot*:: (since: 4.6, default: off) + Enable autorecovery attempts if a bad tree root is found at mount time.