diff mbox series

[-next] scsi: ufs: Fix 'unmet direct dependencies' config warning

Message ID 20200721172021.28922-1-alim.akhtar@samsung.com (mailing list archive)
State Accepted
Commit 7f1c8efd28f70ad73c4d6f6b7f836b484137ed5c
Headers show
Series [-next] scsi: ufs: Fix 'unmet direct dependencies' config warning | expand

Commit Message

Alim Akhtar July 21, 2020, 5:20 p.m. UTC 
With !CONFIG_OF and SCSI_UFS_EXYNOS selected, the below
warning is given:

WARNING: unmet direct dependencies detected for PHY_SAMSUNG_UFS
  Depends on [n]: OF [=n] && (ARCH_EXYNOS || COMPILE_TEST [=y])
  Selected by [y]:
  - SCSI_UFS_EXYNOS [=y] && SCSI_LOWLEVEL [=y] && SCSI [=y] && SCSI_UFSHCD_PLATFORM [=y] && (ARCH_EXYNOS || COMPILE_TEST [=y])

Fix it by removing PHY_SAMSUNG_UFS dependency.

Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
---
 drivers/scsi/ufs/Kconfig | 1 -
 1 file changed, 1 deletion(-)


base-commit: ab8be66e724ecf4bffb2895c9c91bbd44fa687c7

Comments

Randy Dunlap July 21, 2020, 5:57 p.m. UTC | #1 
On 7/21/20 10:20 AM, Alim Akhtar wrote:
> With !CONFIG_OF and SCSI_UFS_EXYNOS selected, the below
> warning is given:
> 
> WARNING: unmet direct dependencies detected for PHY_SAMSUNG_UFS
>   Depends on [n]: OF [=n] && (ARCH_EXYNOS || COMPILE_TEST [=y])
>   Selected by [y]:
>   - SCSI_UFS_EXYNOS [=y] && SCSI_LOWLEVEL [=y] && SCSI [=y] && SCSI_UFSHCD_PLATFORM [=y] && (ARCH_EXYNOS || COMPILE_TEST [=y])
> 
> Fix it by removing PHY_SAMSUNG_UFS dependency.
> 
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>

Looks good. Thanks.

Acked-by: Randy Dunlap <rdunlap@infradead.org>

> ---
>  drivers/scsi/ufs/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig
> index 46a4542f37eb..590768758fc6 100644
> --- a/drivers/scsi/ufs/Kconfig
> +++ b/drivers/scsi/ufs/Kconfig
> @@ -164,7 +164,6 @@ config SCSI_UFS_BSG
>  config SCSI_UFS_EXYNOS
>  	tristate "EXYNOS specific hooks to UFS controller platform driver"
>  	depends on SCSI_UFSHCD_PLATFORM && (ARCH_EXYNOS || COMPILE_TEST)
> -	select PHY_SAMSUNG_UFS
>  	help
>  	  This selects the EXYNOS specific additions to UFSHCD platform driver.
>  	  UFS host on EXYNOS includes HCI and UNIPRO layer, and associates with
> 
> base-commit: ab8be66e724ecf4bffb2895c9c91bbd44fa687c7
>
Martin K. Petersen July 22, 2020, 4:28 a.m. UTC | #2 
On Tue, 21 Jul 2020 22:50:21 +0530, Alim Akhtar wrote:

> With !CONFIG_OF and SCSI_UFS_EXYNOS selected, the below
> warning is given:
> 
> WARNING: unmet direct dependencies detected for PHY_SAMSUNG_UFS
>   Depends on [n]: OF [=n] && (ARCH_EXYNOS || COMPILE_TEST [=y])
>   Selected by [y]:
>   - SCSI_UFS_EXYNOS [=y] && SCSI_LOWLEVEL [=y] && SCSI [=y] && SCSI_UFSHCD_PLATFORM [=y] && (ARCH_EXYNOS || COMPILE_TEST [=y])
> 
> [...]

Applied to 5.9/scsi-queue, thanks!

[1/1] scsi: ufs: Fix 'unmet direct dependencies' config warning
      https://git.kernel.org/mkp/scsi/c/7f1c8efd28f7
Alim Akhtar Aug. 5, 2020, 1:32 a.m. UTC | #3 
Hi Martin,

> On 7/21/20 10:20 AM, Alim Akhtar wrote:
> > With !CONFIG_OF and SCSI_UFS_EXYNOS selected, the below warning is
> > given:
> >
> > WARNING: unmet direct dependencies detected for PHY_SAMSUNG_UFS
> >   Depends on [n]: OF [=n] && (ARCH_EXYNOS || COMPILE_TEST [=y])
> >   Selected by [y]:
> >   - SCSI_UFS_EXYNOS [=y] && SCSI_LOWLEVEL [=y] && SCSI [=y] &&
> > SCSI_UFSHCD_PLATFORM [=y] && (ARCH_EXYNOS || COMPILE_TEST [=y])
> >
> > Fix it by removing PHY_SAMSUNG_UFS dependency.
> >
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> 
> Looks good. Thanks.
> 
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
> 
I don’t see this patch in your tree, let me know if I need to -resend this.
Thanks!

> > ---
> >  drivers/scsi/ufs/Kconfig | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig index
> > 46a4542f37eb..590768758fc6 100644
> > --- a/drivers/scsi/ufs/Kconfig
> > +++ b/drivers/scsi/ufs/Kconfig
> > @@ -164,7 +164,6 @@ config SCSI_UFS_BSG  config SCSI_UFS_EXYNOS
> >  	tristate "EXYNOS specific hooks to UFS controller platform driver"
> >  	depends on SCSI_UFSHCD_PLATFORM && (ARCH_EXYNOS ||
> COMPILE_TEST)
> > -	select PHY_SAMSUNG_UFS
> >  	help
> >  	  This selects the EXYNOS specific additions to UFSHCD platform driver.
> >  	  UFS host on EXYNOS includes HCI and UNIPRO layer, and associates
> > with
> >
> > base-commit: ab8be66e724ecf4bffb2895c9c91bbd44fa687c7
> >
> 
> 
> --
> ~Randy
Martin K. Petersen Aug. 5, 2020, 1:37 a.m. UTC | #4 
Alim,

> I don’t see this patch in your tree, let me know if I need to -resend
> this.

I postponed the Exynos update to 5.10 since there were a few zeroday
warnings and it looked like the 5.8 release was imminent.
Alim Akhtar Aug. 5, 2020, 1:48 a.m. UTC | #5 
> -----Original Message-----
> From: Martin K. Petersen <martin.petersen@oracle.com>
> Sent: 05 August 2020 07:07
> To: Alim Akhtar <alim.akhtar@samsung.com>
> Cc: 'Randy Dunlap' <rdunlap@infradead.org>; martin.petersen@oracle.com;
> avri.altman@wdc.com; linux-scsi@vger.kernel.org; sfr@canb.auug.org.au
> Subject: Re: [PATCH -next] scsi: ufs: Fix 'unmet direct dependencies' config
> warning
> 
> 
> Alim,
> 
> > I don’t see this patch in your tree, let me know if I need to -resend
> > this.
> 
> I postponed the Exynos update to 5.10 since there were a few zeroday warnings
> and it looked like the 5.8 release was imminent.
> 
I suppose all fixes where sent on time for ufs-exynos driver. Anyway let me know in case
I need to re-send any patches.
The $SUBJECT patch is needed to fix a build warning.
Thank you!

> --
> Martin K. Petersen	Oracle Linux Engineering
Martin K. Petersen Sept. 15, 2020, 8:16 p.m. UTC | #6 
On Tue, 21 Jul 2020 22:50:21 +0530, Alim Akhtar wrote:

> With !CONFIG_OF and SCSI_UFS_EXYNOS selected, the below
> warning is given:
> 
> WARNING: unmet direct dependencies detected for PHY_SAMSUNG_UFS
>   Depends on [n]: OF [=n] && (ARCH_EXYNOS || COMPILE_TEST [=y])
>   Selected by [y]:
>   - SCSI_UFS_EXYNOS [=y] && SCSI_LOWLEVEL [=y] && SCSI [=y] && SCSI_UFSHCD_PLATFORM [=y] && (ARCH_EXYNOS || COMPILE_TEST [=y])
> 
> [...]

Applied to 5.10/scsi-queue, thanks!

[1/1] scsi: ufs: Fix 'unmet direct dependencies' config warning
      https://git.kernel.org/mkp/scsi/c/09fd5f0ddf32
diff mbox series

Patch

diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig
index 46a4542f37eb..590768758fc6 100644
--- a/drivers/scsi/ufs/Kconfig
+++ b/drivers/scsi/ufs/Kconfig
@@ -164,7 +164,6 @@  config SCSI_UFS_BSG
 config SCSI_UFS_EXYNOS
 	tristate "EXYNOS specific hooks to UFS controller platform driver"
 	depends on SCSI_UFSHCD_PLATFORM && (ARCH_EXYNOS || COMPILE_TEST)
-	select PHY_SAMSUNG_UFS
 	help
 	  This selects the EXYNOS specific additions to UFSHCD platform driver.
 	  UFS host on EXYNOS includes HCI and UNIPRO layer, and associates with