| Message ID | 159664891296.638781.18417631893299150932.stgit@bahia.lan (mailing list archive) |
|---|---|
| Headers | show |
| Series | spapr: Cleanups for XIVE and PHB | expand |
Patchew URL: https://patchew.org/QEMU/159664891296.638781.18417631893299150932.stgit@bahia.lan/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #! /bin/bash export ARCH=x86_64 make docker-image-fedora V=1 NETWORK=1 time make docker-test-mingw@fedora J=14 NETWORK=1 === TEST SCRIPT END === The full log is available at http://patchew.org/logs/159664891296.638781.18417631893299150932.stgit@bahia.lan/testing.docker-mingw@fedora/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Recent cleanup patch "spapr: Simplify error handling in spapr_phb_realize" had to be dropped from ppc-for-5.2 because it would cause QEMU to crash at init time on some POWER9 setups (eg. Boston systems), as reported by Daniel. The crash was happening because the kvmppc_xive_source_reset_one() function would get called at some point (eg. initializing the LSI table of PHB0) and fail (because XIVE KVM isn't supported on Bostons) without calling error_setg(), which the caller doesn't expect when the patch above is applied. The issue isn't really about a missing call to error_setg() but why do we end up trying to claim an IRQ number in a XIVE KVM device that doesn't exist ? The root cause for this is that we guard calls to the XIVE KVM code with kvm_irqchip_in_kernel(), which might return true when the XICS KVM device is active, even though the XIVE one is not. This series upgrade the guarding code to also check if the device is actually open. A similar cleanup could be performed on XICS. --- Greg Kurz (5): spapr/xive: Fix xive->fd if kvm_create_device() fails spapr/xive: Simplify kvmppc_xive_disconnect() ppc/xive: Introduce dedicated kvm_irqchip_in_kernel() wrappers spapr/xive: Convert KVM device fd checks to assert() spapr: Simplify error handling in spapr_phb_realize() hw/intc/spapr_xive.c | 39 +++++++++++++++++--------- hw/intc/spapr_xive_kvm.c | 64 +++++++++++++++++++------------------------ hw/intc/xive.c | 30 +++++++++++++++----- hw/ppc/spapr_pci.c | 16 +++++------ include/hw/ppc/spapr_xive.h | 1 + include/hw/ppc/xive.h | 2 + 6 files changed, 87 insertions(+), 65 deletions(-) -- Greg