[0/8] kmsxx: Various fixes and improvements

Message

Laurent Pinchart Aug. 6, 2020, 2:17 a.m. UTC

Hi Tomi,

This patch series fixes a few issues in kmsxx, mainly related to support
for additional pixel formats.

Patch 1/8 is a small API extension proposal to expose the card device
minor number, and patch 2/8 is a typo fix in a method name.

The remaining patches add support for additional RGB and YUV formats,
fixing a few issues in the dumb frame buffer class for fully planar
buffers (patches 3/8 and 4/8), and adding support for the new formats in
patches 5/8 to 8/8.

All the new formats have been tested on a Renesas R-Car Gen3 device,
which supports

- PixelFormat.RGB332
- PixelFormat.ARGB4444
- PixelFormat.XRGB4444
- PixelFormat.ARGB1555
- PixelFormat.XRGB1555
- PixelFormat.RGB565
- PixelFormat.BGR888
- PixelFormat.RGB888
- PixelFormat.BGRA8888
- PixelFormat.BGRX8888
- PixelFormat.ARGB8888
- PixelFormat.XRGB8888
- PixelFormat.UYVY
- PixelFormat.YUYV
- PixelFormat.YVYU
- PixelFormat.NV12
- PixelFormat.NV21
- PixelFormat.NV16
- PixelFormat.NV61
- PixelFormat.YUV420
- PixelFormat.YVU420
- PixelFormat.YUV422
- PixelFormat.YVU422
- PixelFormat.YUV444
- PixelFormat.YVU444

Laurent Pinchart (8):
  card: Add a method to retrieve the device minor
  card: Rename has_has_universal_planes to has_universal_planes
  dumbfb: Add support tri- or quadri-planar buffers
  dumbfb: Fix pitch for tri-planar formats
  pykmsbase: Add missing pixel formats
  kms++: Add support for semiplanar YUV422 formats (NV16 and NV61)
  kms++: Add support for the planar YUV formats
  kms++: Add support for missing 8 -and 16-bit RGB formats

 kms++/inc/kms++/card.h              |   5 +-
 kms++/inc/kms++/pixelformats.h      |  14 ++
 kms++/src/card.cpp                  |  11 ++
 kms++/src/dumbframebuffer.cpp       |  23 ++-
 kms++/src/pixelformats.cpp          |  18 +-
 kms++/src/plane.cpp                 |   2 +-
 kms++util/inc/kms++util/color.h     |   1 +
 kms++util/inc/kms++util/kms++util.h |   1 +
 kms++util/src/color.cpp             |   5 +
 kms++util/src/drawing.cpp           | 279 +++++++++++++++++++++++++---
 kms++util/src/testpat.cpp           |  16 +-
 py/pykms/pykmsbase.cpp              |  33 ++++
 utils/kmsprint.cpp                  |   4 +-
 13 files changed, 370 insertions(+), 42 deletions(-)

Comments

Tomi Valkeinen Aug. 6, 2020, 9:33 a.m. UTC | #1

On 06/08/2020 05:17, Laurent Pinchart wrote:
> Hi Tomi,
> 
> This patch series fixes a few issues in kmsxx, mainly related to support
> for additional pixel formats.

Thanks, looks good aside the two comments. And for the one for pixel formats, I think we can go with
what you have, and try to figure out a clean solution later (unless you already have an idea).

 Tomi