Message ID | 20200806191518.593880-6-sagi@grimberg.me (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | blktests: Add support to run nvme tests with tcp/rdma transports | expand |
On 8/6/20 12:15, Sagi Grimberg wrote: > + tcp) > + _have_modules nvmet nvme-core nvme-tcp nvmet-tcp > + _have_configfs > + ;; > Same as previous nvme-core nvmet configfs can use a helper.
>> + tcp) >> + _have_modules nvmet nvme-core nvme-tcp nvmet-tcp >> + _have_configfs >> + ;; >> > Same as previous nvme-core nvmet configfs can use a helper. So for every trtype instead of having: _have_modules nvmet nvme-core <trtype specific> _have_configfs You will have: _have_nvme_fabrics_common _have_modules <trtype specific> Don't see it as an improvement...
On 8/7/20 16:46, Sagi Grimberg wrote: > So for every trtype instead of having: > > _have_modules nvmet nvme-core <trtype specific> > _have_configfs > > You will have: > _have_nvme_fabrics_common > _have_modules <trtype specific> > > Don't see it as an improvement... Okay, we can ignore this.
diff --git a/tests/nvme/rc b/tests/nvme/rc index a2cb0c0add93..69ab7d2f3964 100644 --- a/tests/nvme/rc +++ b/tests/nvme/rc @@ -21,6 +21,10 @@ _nvme_requires() { pci) _have_modules nvme nvme-core ;; + tcp) + _have_modules nvmet nvme-core nvme-tcp nvmet-tcp + _have_configfs + ;; *) SKIP_REASON="unsupported nvme_trtype=${nvme_trtype}" return 1
run with: nvme_trtype=tcp ./check test/nvme Signed-off-by: Sagi Grimberg <sagi@grimberg.me> --- tests/nvme/rc | 4 ++++ 1 file changed, 4 insertions(+)