| Message ID | 20200805134226.1106164-34-mst@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | None | expand |
On Wed, Aug 05, 2020 at 09:44:45AM -0400, Michael S. Tsirkin wrote: > Virtio pmem is modern-only. Use LE accessors for config space. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > --- > drivers/nvdimm/virtio_pmem.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/nvdimm/virtio_pmem.c b/drivers/nvdimm/virtio_pmem.c > index 5e3d07b47e0c..726c7354d465 100644 > --- a/drivers/nvdimm/virtio_pmem.c > +++ b/drivers/nvdimm/virtio_pmem.c > @@ -58,9 +58,9 @@ static int virtio_pmem_probe(struct virtio_device *vdev) > goto out_err; > } > > - virtio_cread(vpmem->vdev, struct virtio_pmem_config, > + virtio_cread_le(vpmem->vdev, struct virtio_pmem_config, > start, &vpmem->start); > - virtio_cread(vpmem->vdev, struct virtio_pmem_config, > + virtio_cread_le(vpmem->vdev, struct virtio_pmem_config, > size, &vpmem->size); FWIW I think squashing patch 15/38 and this patch would have made more sense. Acked-by: Ira Weiny <ira.weiny@intel.com> > > res.start = vpmem->start; > -- > MST >
diff --git a/drivers/nvdimm/virtio_pmem.c b/drivers/nvdimm/virtio_pmem.c index 5e3d07b47e0c..726c7354d465 100644 --- a/drivers/nvdimm/virtio_pmem.c +++ b/drivers/nvdimm/virtio_pmem.c @@ -58,9 +58,9 @@ static int virtio_pmem_probe(struct virtio_device *vdev) goto out_err; } - virtio_cread(vpmem->vdev, struct virtio_pmem_config, + virtio_cread_le(vpmem->vdev, struct virtio_pmem_config, start, &vpmem->start); - virtio_cread(vpmem->vdev, struct virtio_pmem_config, + virtio_cread_le(vpmem->vdev, struct virtio_pmem_config, size, &vpmem->size); res.start = vpmem->start;
Virtio pmem is modern-only. Use LE accessors for config space. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- drivers/nvdimm/virtio_pmem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)