mbox series

[v9,0/8] Make fstests support new behavior of DAX

Message ID 20200806021342.10596-1-yangx.jy@cn.fujitsu.com (mailing list archive)
Headers show
Series Make fstests support new behavior of DAX | expand

Message

Xiao Yang Aug. 6, 2020, 2:13 a.m. UTC 
The new behavior of DAX on xfs/ext4 has been merged into main kernel
so it is time for fstests to support new behavior of DAX.

1) Refactor common functions and take use of them.
2) Move and update xfs/260.
3) Add three new tests to verify some features.

References:
https://lkml.org/lkml/2019/10/20/96
https://lkml.org/lkml/2020/5/28/949

V7->V8:
1) Rebase against the latest xfstests.
2) Factor out _check_s_dax() and _check_xflag().

V8->V9:
1) Squash a new test(generic/608) into the patch set.
2) Add a new combination(without dax option) for all related tests(generic/605,
   generic/606, generic/608).
3) In generic/607, factor out _scratch_mkfs() and export MOUNT_OPTIONS=""
   for a combination(without dax option).

Xiao Yang (8):
  common/rc: Introduce helpers for new dax mount options and FS_XFLAG_DAX
  fstests: Use _require_scratch_dax_mountopt() and _require_dax_iflag()
  generic/223: Don't clear MKFS_OPTION before calling _scratch_mkfs_geom()
  generic/413, xfs/260: Improve format operation for PMD fault testing
  xfs/260: Move and update xfs/260
  generic: Verify if statx() can qurey S_DAX flag on regular file correctly
  generic: Verify the inheritance behavior of FS_XFLAG_DAX flag in various combinations
  generic: Verify how to change the S_DAX flag on an existing file

 common/rc                      | 105 ++++++++++++++++--
 tests/ext4/030                 |   2 +-
 tests/ext4/031                 |   4 +-
 tests/generic/223              |   1 -
 tests/generic/413              |  12 +--
 tests/generic/462              |   2 +-
 tests/{xfs/260 => generic/605} |  79 +++++++-------
 tests/generic/605.out          |   2 +
 tests/generic/606              |  92 ++++++++++++++++
 tests/generic/606.out          |   2 +
 tests/generic/607              | 189 +++++++++++++++++++++++++++++++++
 tests/generic/607.out          |   2 +
 tests/generic/608              | 121 +++++++++++++++++++++
 tests/generic/608.out          |   2 +
 tests/generic/group            |   4 +
 tests/xfs/260.out              |   2 -
 tests/xfs/group                |   1 -
 17 files changed, 559 insertions(+), 63 deletions(-)
 rename tests/{xfs/260 => generic/605} (54%)
 create mode 100644 tests/generic/605.out
 create mode 100644 tests/generic/606
 create mode 100644 tests/generic/606.out
 create mode 100644 tests/generic/607
 create mode 100644 tests/generic/607.out
 create mode 100644 tests/generic/608
 create mode 100644 tests/generic/608.out
 delete mode 100644 tests/xfs/260.out

Comments

Ira Weiny Aug. 7, 2020, 6:14 p.m. UTC | #1 
On Thu, Aug 06, 2020 at 10:13:34AM +0800, Xiao Yang wrote:
> The new behavior of DAX on xfs/ext4 has been merged into main kernel
> so it is time for fstests to support new behavior of DAX.

In case it helps...

I think this series has enough review to be applied.  Further tests/changes can
be applied on top of this...  so I'm going to add

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

For the entire series even though I think Xiao has already put a reviewed by on
all of the individual patches already.

Ira

> 
> 1) Refactor common functions and take use of them.
> 2) Move and update xfs/260.
> 3) Add three new tests to verify some features.
> 
> References:
> https://lkml.org/lkml/2019/10/20/96
> https://lkml.org/lkml/2020/5/28/949
> 
> V7->V8:
> 1) Rebase against the latest xfstests.
> 2) Factor out _check_s_dax() and _check_xflag().
> 
> V8->V9:
> 1) Squash a new test(generic/608) into the patch set.
> 2) Add a new combination(without dax option) for all related tests(generic/605,
>    generic/606, generic/608).
> 3) In generic/607, factor out _scratch_mkfs() and export MOUNT_OPTIONS=""
>    for a combination(without dax option).
> 
> Xiao Yang (8):
>   common/rc: Introduce helpers for new dax mount options and FS_XFLAG_DAX
>   fstests: Use _require_scratch_dax_mountopt() and _require_dax_iflag()
>   generic/223: Don't clear MKFS_OPTION before calling _scratch_mkfs_geom()
>   generic/413, xfs/260: Improve format operation for PMD fault testing
>   xfs/260: Move and update xfs/260
>   generic: Verify if statx() can qurey S_DAX flag on regular file correctly
>   generic: Verify the inheritance behavior of FS_XFLAG_DAX flag in various combinations
>   generic: Verify how to change the S_DAX flag on an existing file
> 
>  common/rc                      | 105 ++++++++++++++++--
>  tests/ext4/030                 |   2 +-
>  tests/ext4/031                 |   4 +-
>  tests/generic/223              |   1 -
>  tests/generic/413              |  12 +--
>  tests/generic/462              |   2 +-
>  tests/{xfs/260 => generic/605} |  79 +++++++-------
>  tests/generic/605.out          |   2 +
>  tests/generic/606              |  92 ++++++++++++++++
>  tests/generic/606.out          |   2 +
>  tests/generic/607              | 189 +++++++++++++++++++++++++++++++++
>  tests/generic/607.out          |   2 +
>  tests/generic/608              | 121 +++++++++++++++++++++
>  tests/generic/608.out          |   2 +
>  tests/generic/group            |   4 +
>  tests/xfs/260.out              |   2 -
>  tests/xfs/group                |   1 -
>  17 files changed, 559 insertions(+), 63 deletions(-)
>  rename tests/{xfs/260 => generic/605} (54%)
>  create mode 100644 tests/generic/605.out
>  create mode 100644 tests/generic/606
>  create mode 100644 tests/generic/606.out
>  create mode 100644 tests/generic/607
>  create mode 100644 tests/generic/607.out
>  create mode 100644 tests/generic/608
>  create mode 100644 tests/generic/608.out
>  delete mode 100644 tests/xfs/260.out
> 
> -- 
> 2.21.0
> 
> 
>
Eryu Guan Aug. 9, 2020, 5:12 p.m. UTC | #2 
On Fri, Aug 07, 2020 at 11:14:39AM -0700, Ira Weiny wrote:
> On Thu, Aug 06, 2020 at 10:13:34AM +0800, Xiao Yang wrote:
> > The new behavior of DAX on xfs/ext4 has been merged into main kernel
> > so it is time for fstests to support new behavior of DAX.
> 
> In case it helps...
> 
> I think this series has enough review to be applied.  Further tests/changes can
> be applied on top of this...  so I'm going to add
> 
> Reviewed-by: Ira Weiny <ira.weiny@intel.com>

Thanks a lot for the reviews! Also many thanks to Darrick for his
review!

> 
> For the entire series even though I think Xiao has already put a reviewed by on
> all of the individual patches already.

Xiao, thank you so much for the great patchset!

Thanks,
Eryu

> 
> Ira
> 
> > 
> > 1) Refactor common functions and take use of them.
> > 2) Move and update xfs/260.
> > 3) Add three new tests to verify some features.
> > 
> > References:
> > https://lkml.org/lkml/2019/10/20/96
> > https://lkml.org/lkml/2020/5/28/949
> > 
> > V7->V8:
> > 1) Rebase against the latest xfstests.
> > 2) Factor out _check_s_dax() and _check_xflag().
> > 
> > V8->V9:
> > 1) Squash a new test(generic/608) into the patch set.
> > 2) Add a new combination(without dax option) for all related tests(generic/605,
> >    generic/606, generic/608).
> > 3) In generic/607, factor out _scratch_mkfs() and export MOUNT_OPTIONS=""
> >    for a combination(without dax option).
> > 
> > Xiao Yang (8):
> >   common/rc: Introduce helpers for new dax mount options and FS_XFLAG_DAX
> >   fstests: Use _require_scratch_dax_mountopt() and _require_dax_iflag()
> >   generic/223: Don't clear MKFS_OPTION before calling _scratch_mkfs_geom()
> >   generic/413, xfs/260: Improve format operation for PMD fault testing
> >   xfs/260: Move and update xfs/260
> >   generic: Verify if statx() can qurey S_DAX flag on regular file correctly
> >   generic: Verify the inheritance behavior of FS_XFLAG_DAX flag in various combinations
> >   generic: Verify how to change the S_DAX flag on an existing file
> > 
> >  common/rc                      | 105 ++++++++++++++++--
> >  tests/ext4/030                 |   2 +-
> >  tests/ext4/031                 |   4 +-
> >  tests/generic/223              |   1 -
> >  tests/generic/413              |  12 +--
> >  tests/generic/462              |   2 +-
> >  tests/{xfs/260 => generic/605} |  79 +++++++-------
> >  tests/generic/605.out          |   2 +
> >  tests/generic/606              |  92 ++++++++++++++++
> >  tests/generic/606.out          |   2 +
> >  tests/generic/607              | 189 +++++++++++++++++++++++++++++++++
> >  tests/generic/607.out          |   2 +
> >  tests/generic/608              | 121 +++++++++++++++++++++
> >  tests/generic/608.out          |   2 +
> >  tests/generic/group            |   4 +
> >  tests/xfs/260.out              |   2 -
> >  tests/xfs/group                |   1 -
> >  17 files changed, 559 insertions(+), 63 deletions(-)
> >  rename tests/{xfs/260 => generic/605} (54%)
> >  create mode 100644 tests/generic/605.out
> >  create mode 100644 tests/generic/606
> >  create mode 100644 tests/generic/606.out
> >  create mode 100644 tests/generic/607
> >  create mode 100644 tests/generic/607.out
> >  create mode 100644 tests/generic/608
> >  create mode 100644 tests/generic/608.out
> >  delete mode 100644 tests/xfs/260.out
> > 
> > -- 
> > 2.21.0
> > 
> > 
> >