| Message ID | 20200803155745.18082-1-kai.heng.feng@canonical.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | conf: USB-Audio: Disable IEC958 on Lenovo ThinkStation P620 | expand |
Hi, > On Aug 3, 2020, at 23:57, Kai-Heng Feng <kai.heng.feng@canonical.com> wrote: > > Both USB audio cards on Lenovo ThinkStation P620 don't support IEC958, > so disable IEC958 accordingly. > > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> Should I use GitHub instead of mailing list for any future alia-lib patch? Kai-Heng > --- > src/conf/cards/USB-Audio.conf | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/conf/cards/USB-Audio.conf b/src/conf/cards/USB-Audio.conf > index 297629f3..9b64af3c 100644 > --- a/src/conf/cards/USB-Audio.conf > +++ b/src/conf/cards/USB-Audio.conf > @@ -63,6 +63,8 @@ USB-Audio.pcm.iec958_device { > "Scarlett 2i4 USB" 999 > "Sennheiser USB headset" 999 > "SWTOR Gaming Headset by Razer" 999 > + "ThinkStation P620 Main" 999 > + "ThinkStation P620 Rear" 999 > "Thunderbolt Dock Audio Headset" 999 > "Thunderbolt Dock Audio Module" 999 > "USB Device 0x46d_0x821" 999 > -- > 2.17.1 >
On Tue, 11 Aug 2020 12:00:54 +0200, Kai-Heng Feng wrote: > > Hi, > > > On Aug 3, 2020, at 23:57, Kai-Heng Feng <kai.heng.feng@canonical.com> wrote: > > > > Both USB audio cards on Lenovo ThinkStation P620 don't support IEC958, > > so disable IEC958 accordingly. > > > > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> > > Should I use GitHub instead of mailing list for any future alia-lib patch? Sorry, I overlooked this since I wasn't on Cc. Applied now. Thanks. Takashi
Hi, > On Aug 11, 2020, at 19:17, Takashi Iwai <tiwai@suse.de> wrote: > > On Tue, 11 Aug 2020 12:00:54 +0200, > Kai-Heng Feng wrote: >> >> Hi, >> >>> On Aug 3, 2020, at 23:57, Kai-Heng Feng <kai.heng.feng@canonical.com> wrote: >>> >>> Both USB audio cards on Lenovo ThinkStation P620 don't support IEC958, >>> so disable IEC958 accordingly. >>> >>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> >> >> Should I use GitHub instead of mailing list for any future alia-lib patch? > > Sorry, I overlooked this since I wasn't on Cc. > Applied now. Thanks. Thanks. Is mailing list or GitHub preferred way? Kai-Heng > > > Takashi
On Wed, 12 Aug 2020 06:00:22 +0200, Kai-Heng Feng wrote: > > Hi, > > > On Aug 11, 2020, at 19:17, Takashi Iwai <tiwai@suse.de> wrote: > > > > On Tue, 11 Aug 2020 12:00:54 +0200, > > Kai-Heng Feng wrote: > >> > >> Hi, > >> > >>> On Aug 3, 2020, at 23:57, Kai-Heng Feng <kai.heng.feng@canonical.com> wrote: > >>> > >>> Both USB audio cards on Lenovo ThinkStation P620 don't support IEC958, > >>> so disable IEC958 accordingly. > >>> > >>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> > >> > >> Should I use GitHub instead of mailing list for any future alia-lib patch? > > > > Sorry, I overlooked this since I wasn't on Cc. > > Applied now. Thanks. > > Thanks. > > Is mailing list or GitHub preferred way? I personally still prefer ML, but it's basically up to you. thanks, Takashi
diff --git a/src/conf/cards/USB-Audio.conf b/src/conf/cards/USB-Audio.conf index 297629f3..9b64af3c 100644 --- a/src/conf/cards/USB-Audio.conf +++ b/src/conf/cards/USB-Audio.conf @@ -63,6 +63,8 @@ USB-Audio.pcm.iec958_device { "Scarlett 2i4 USB" 999 "Sennheiser USB headset" 999 "SWTOR Gaming Headset by Razer" 999 + "ThinkStation P620 Main" 999 + "ThinkStation P620 Rear" 999 "Thunderbolt Dock Audio Headset" 999 "Thunderbolt Dock Audio Module" 999 "USB Device 0x46d_0x821" 999
Both USB audio cards on Lenovo ThinkStation P620 don't support IEC958, so disable IEC958 accordingly. Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> --- src/conf/cards/USB-Audio.conf | 2 ++ 1 file changed, 2 insertions(+)