| Message ID | 20200812124709.4165-2-roger.pau@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | x86/vlapic: implement EOI callbacks | expand |
On 12/08/2020 13:47, Roger Pau Monne wrote: > Change the last parameter of the update_eoi_exit_bitmap helper to be a > set/clear boolean instead of a triggering field. This is already > inline with how the function is implemented, and will allow deciding "in line" > whether an exit is required by the higher layers that call into > update_eoi_exit_bitmap. Note that the current behavior is not changed > by this patch. > > No functional change intended. > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
> From: Roger Pau Monne <roger.pau@citrix.com> > Sent: Wednesday, August 12, 2020 8:47 PM arameter > > Change the last parameter of the update_eoi_exit_bitmap helper to be a > set/clear boolean instead of a triggering field. This is already > inline with how the function is implemented, and will allow deciding > whether an exit is required by the higher layers that call into > update_eoi_exit_bitmap. Note that the current behavior is not changed > by this patch. > > No functional change intended. > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> Reviewed-by: Kevin Tian <kevin.tian@intel.com> > --- > xen/arch/x86/hvm/vmx/vmx.c | 4 ++-- > xen/include/asm-x86/hvm/hvm.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c > index eb54aadfba..1c04a7e3fc 100644 > --- a/xen/arch/x86/hvm/vmx/vmx.c > +++ b/xen/arch/x86/hvm/vmx/vmx.c > @@ -1885,9 +1885,9 @@ static void vmx_set_info_guest(struct vcpu *v) > vmx_vmcs_exit(v); > } > > -static void vmx_update_eoi_exit_bitmap(struct vcpu *v, u8 vector, u8 trig) > +static void vmx_update_eoi_exit_bitmap(struct vcpu *v, uint8_t vector, bool > set) > { > - if ( trig ) > + if ( set ) > vmx_set_eoi_exit_bitmap(v, vector); > else > vmx_clear_eoi_exit_bitmap(v, vector); > diff --git a/xen/include/asm-x86/hvm/hvm.h b/xen/include/asm- > x86/hvm/hvm.h > index 1eb377dd82..be0d8b0a4d 100644 > --- a/xen/include/asm-x86/hvm/hvm.h > +++ b/xen/include/asm-x86/hvm/hvm.h > @@ -192,7 +192,7 @@ struct hvm_function_table { > void (*nhvm_domain_relinquish_resources)(struct domain *d); > > /* Virtual interrupt delivery */ > - void (*update_eoi_exit_bitmap)(struct vcpu *v, u8 vector, u8 trig); > + void (*update_eoi_exit_bitmap)(struct vcpu *v, uint8_t vector, bool set); > void (*process_isr)(int isr, struct vcpu *v); > void (*deliver_posted_intr)(struct vcpu *v, u8 vector); > void (*sync_pir_to_irr)(struct vcpu *v); > -- > 2.28.0
diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index eb54aadfba..1c04a7e3fc 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -1885,9 +1885,9 @@ static void vmx_set_info_guest(struct vcpu *v) vmx_vmcs_exit(v); } -static void vmx_update_eoi_exit_bitmap(struct vcpu *v, u8 vector, u8 trig) +static void vmx_update_eoi_exit_bitmap(struct vcpu *v, uint8_t vector, bool set) { - if ( trig ) + if ( set ) vmx_set_eoi_exit_bitmap(v, vector); else vmx_clear_eoi_exit_bitmap(v, vector); diff --git a/xen/include/asm-x86/hvm/hvm.h b/xen/include/asm-x86/hvm/hvm.h index 1eb377dd82..be0d8b0a4d 100644 --- a/xen/include/asm-x86/hvm/hvm.h +++ b/xen/include/asm-x86/hvm/hvm.h @@ -192,7 +192,7 @@ struct hvm_function_table { void (*nhvm_domain_relinquish_resources)(struct domain *d); /* Virtual interrupt delivery */ - void (*update_eoi_exit_bitmap)(struct vcpu *v, u8 vector, u8 trig); + void (*update_eoi_exit_bitmap)(struct vcpu *v, uint8_t vector, bool set); void (*process_isr)(int isr, struct vcpu *v); void (*deliver_posted_intr)(struct vcpu *v, u8 vector); void (*sync_pir_to_irr)(struct vcpu *v);
Change the last parameter of the update_eoi_exit_bitmap helper to be a set/clear boolean instead of a triggering field. This is already inline with how the function is implemented, and will allow deciding whether an exit is required by the higher layers that call into update_eoi_exit_bitmap. Note that the current behavior is not changed by this patch. No functional change intended. Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> --- xen/arch/x86/hvm/vmx/vmx.c | 4 ++-- xen/include/asm-x86/hvm/hvm.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)