diff mbox series

[1/2] drm/i915: Update TGL and RKL DMC firmware versions

Message ID 20200813200029.25307-1-jose.souza@intel.com (mailing list archive)
State New, archived
Headers show
Series [1/2] drm/i915: Update TGL and RKL DMC firmware versions | expand

Commit Message

Souza, Jose Aug. 13, 2020, 8 p.m. UTC 
Fixes around DC5, DC6 and DC3CO in those new firmwares.

Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/display/intel_csr.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Matt Roper Aug. 15, 2020, 1:31 a.m. UTC | #1 
On Thu, Aug 13, 2020 at 01:00:28PM -0700, José Roberto de Souza wrote:
> Fixes around DC5, DC6 and DC3CO in those new firmwares.
> 
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>

Reviewed-by: Matt Roper <matthew.d.roper@intel.com>

for both patches in this series.


Matt

> ---
>  drivers/gpu/drm/i915/display/intel_csr.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_csr.c b/drivers/gpu/drm/i915/display/intel_csr.c
> index f22a7645c249..d5db16764619 100644
> --- a/drivers/gpu/drm/i915/display/intel_csr.c
> +++ b/drivers/gpu/drm/i915/display/intel_csr.c
> @@ -40,12 +40,12 @@
>  
>  #define GEN12_CSR_MAX_FW_SIZE		ICL_CSR_MAX_FW_SIZE
>  
> -#define RKL_CSR_PATH			"i915/rkl_dmc_ver2_01.bin"
> -#define RKL_CSR_VERSION_REQUIRED	CSR_VERSION(2, 1)
> +#define RKL_CSR_PATH			"i915/rkl_dmc_ver2_02.bin"
> +#define RKL_CSR_VERSION_REQUIRED	CSR_VERSION(2, 2)
>  MODULE_FIRMWARE(RKL_CSR_PATH);
>  
> -#define TGL_CSR_PATH			"i915/tgl_dmc_ver2_06.bin"
> -#define TGL_CSR_VERSION_REQUIRED	CSR_VERSION(2, 6)
> +#define TGL_CSR_PATH			"i915/tgl_dmc_ver2_08.bin"
> +#define TGL_CSR_VERSION_REQUIRED	CSR_VERSION(2, 8)
>  #define TGL_CSR_MAX_FW_SIZE		0x6000
>  MODULE_FIRMWARE(TGL_CSR_PATH);
>  
> -- 
> 2.28.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Souza, Jose Aug. 17, 2020, 7:27 p.m. UTC | #2 
Pushed to dinq, thanks for the review Matt Roper.

On Sat, 2020-08-15 at 00:39 +0000, Patchwork wrote:
> Patch Details
> Series:	series starting with [1/2] drm/i915: Update TGL and RKL DMC firmware versions (rev2)
> URL:	https://patchwork.freedesktop.org/series/80610/
> State:	success
> Details:	https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18360/index.html
> CI Bug Log - changes from CI_DRM_8882_full -> Patchwork_18360_full
> Summary
> SUCCESS
> 
> No regressions found.
> 
> Known issues
> Here are the changes found in Patchwork_18360_full that come from known issues:
> 
> IGT changes
> Issues hit
> igt@gem_exec_whisper@basic-forked:
> 
> shard-glk: PASS -> DMESG-WARN (i915#118 / i915#95)
> igt@gem_mmap_gtt@fault-concurrent:
> 
> shard-skl: PASS -> DMESG-WARN (i915#2165)
> igt@i915_pm_dc@dc5-dpms:
> 
> shard-skl: PASS -> INCOMPLETE (i915#198)
> igt@kms_cursor_crc@pipe-a-cursor-suspend:
> 
> shard-skl: PASS -> INCOMPLETE (i915#300)
> igt@kms_flip@2x-modeset-vs-vblank-race-interruptible@ab-vga1-hdmi-a1:
> 
> shard-hsw: PASS -> DMESG-WARN (i915#1982)
> igt@kms_flip@flip-vs-fences@a-edp1:
> 
> shard-skl: PASS -> DMESG-WARN (i915#1982) +12 similar issues
> igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
> 
> shard-kbl: PASS -> DMESG-WARN (i915#180) +7 similar issues
> igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1:
> 
> shard-skl: PASS -> FAIL (i915#2122) +1 similar issue
> igt@kms_psr@psr2_no_drrs:
> 
> shard-iclb: PASS -> SKIP (fdo#109441) +2 similar issues
> igt@kms_vblank@pipe-c-accuracy-idle:
> 
> shard-glk: PASS -> FAIL (i915#43)
> igt@perf@blocking-parameterized:
> 
> shard-iclb: PASS -> FAIL (i915#1542)
> Possible fixes
> igt@gem_ctx_shared@q-smoketest-all:
> 
> shard-glk: DMESG-WARN (i915#118 / i915#95) -> PASS +1 similar issue
> igt@gem_huc_copy@huc-copy:
> 
> shard-tglb: SKIP (i915#2190) -> PASS
> igt@gem_mmap_gtt@fault-concurrent:
> 
> shard-glk: DMESG-WARN (i915#2165) -> PASS
> igt@gen9_exec_parse@allowed-all:
> 
> shard-apl: DMESG-WARN (i915#1436 / i915#1635 / i915#716) -> PASS
> igt@i915_pm_dc@dc6-dpms:
> 
> shard-iclb: FAIL (i915#454) -> PASS
> igt@i915_selftest@mock@contexts:
> 
> shard-apl: INCOMPLETE (i915#1635 / i915#2278) -> PASS
> igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size:
> 
> shard-skl: DMESG-WARN (i915#1982) -> PASS +9 similar issues
> 
> shard-tglb: DMESG-WARN (i915#1982) -> PASS +1 similar issue
> 
> igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-untiled:
> 
> shard-skl: FAIL (i915#52 / i915#54) -> PASS
> igt@kms_flip@flip-vs-expired-vblank@c-edp1:
> 
> shard-skl: FAIL (i915#79) -> PASS
> igt@kms_hdr@bpc-switch-dpms:
> 
> shard-skl: FAIL (i915#1188) -> PASS +1 similar issue
> igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
> 
> shard-kbl: DMESG-WARN (i915#180) -> PASS +6 similar issues
> igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
> 
> shard-skl: FAIL (fdo#108145 / i915#265) -> PASS
> igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping:
> 
> shard-iclb: DMESG-WARN (i915#1982) -> PASS
> igt@kms_psr2_su@frontbuffer:
> 
> shard-iclb: SKIP (fdo#109642 / fdo#111068) -> PASS +1 similar issue
> igt@kms_psr@psr2_primary_page_flip:
> 
> shard-iclb: SKIP (fdo#109441) -> PASS +1 similar issue
> igt@kms_vblank@pipe-b-ts-continuation-modeset-hang:
> 
> shard-glk: DMESG-WARN (i915#1982) -> PASS +1 similar issue
> igt@prime_busy@after@vecs0:
> 
> shard-hsw: FAIL (i915#2258) -> PASS +1 similar issue
> Warnings
> igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
> shard-apl: DMESG-FAIL (fdo#108145 / i915#1635 / i915#1982) -> FAIL (fdo#108145 / i915#1635 / i915#265)
> Participating hosts (11 -> 11)
> No changes in participating hosts
> 
> Build changes
> Linux: CI_DRM_8882 -> Patchwork_18360
> CI-20190529: 20190529
> CI_DRM_8882: bc285974fbc945765c176218aba7a003b687eea9 @ git://anongit.freedesktop.org/gfx-ci/linux
> IGT_5769: 4e5f76be680b65780204668e302026cf638decc9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> Patchwork_18360: 6ce9a1f5551c2436b26eb54de31a83f94a667552 @ git://anongit.freedesktop.org/gfx-ci/linux
> piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
> 
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_csr.c b/drivers/gpu/drm/i915/display/intel_csr.c
index f22a7645c249..d5db16764619 100644
--- a/drivers/gpu/drm/i915/display/intel_csr.c
+++ b/drivers/gpu/drm/i915/display/intel_csr.c
@@ -40,12 +40,12 @@ 
 
 #define GEN12_CSR_MAX_FW_SIZE		ICL_CSR_MAX_FW_SIZE
 
-#define RKL_CSR_PATH			"i915/rkl_dmc_ver2_01.bin"
-#define RKL_CSR_VERSION_REQUIRED	CSR_VERSION(2, 1)
+#define RKL_CSR_PATH			"i915/rkl_dmc_ver2_02.bin"
+#define RKL_CSR_VERSION_REQUIRED	CSR_VERSION(2, 2)
 MODULE_FIRMWARE(RKL_CSR_PATH);
 
-#define TGL_CSR_PATH			"i915/tgl_dmc_ver2_06.bin"
-#define TGL_CSR_VERSION_REQUIRED	CSR_VERSION(2, 6)
+#define TGL_CSR_PATH			"i915/tgl_dmc_ver2_08.bin"
+#define TGL_CSR_VERSION_REQUIRED	CSR_VERSION(2, 8)
 #define TGL_CSR_MAX_FW_SIZE		0x6000
 MODULE_FIRMWARE(TGL_CSR_PATH);