diff mbox series

[v5,9/9] usb: cdns3: host: add xhci_plat_priv quirk XHCI_SKIP_PHY_INIT

Message ID 20200707074941.28078-10-peter.chen@nxp.com (mailing list archive)
State New, archived
Headers show
Series usb: some PM changes for cdns3 and xhci-plat | expand

Commit Message

Peter Chen July 7, 2020, 7:49 a.m. UTC 
cdns3 manages PHY by own DRD driver, so skip the management by
HCD core.

Signed-off-by: Peter Chen <peter.chen@nxp.com>
---
 drivers/usb/cdns3/host.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Pawel Laszczak Aug. 17, 2020, 4:37 a.m. UTC | #1 
>
>cdns3 manages PHY by own DRD driver, so skip the management by
>HCD core.
>
>Signed-off-by: Peter Chen <peter.chen@nxp.com>
>---
> drivers/usb/cdns3/host.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/usb/cdns3/host.c b/drivers/usb/cdns3/host.c
>index 030d6421abd3..1dfbe23fa089 100644
>--- a/drivers/usb/cdns3/host.c
>+++ b/drivers/usb/cdns3/host.c
>@@ -24,6 +24,7 @@
> #define LPM_2_STB_SWITCH_EN	(1 << 25)
>

Please use BIT(25) 

Reviewed-by: Pawel Laszczak <pawell@cadence.com>

Regards
Pawel

> static const struct xhci_plat_priv xhci_plat_cdns3_xhci = {
>+	.quirks = XHCI_SKIP_PHY_INIT,
> 	.suspend_quirk = xhci_cdns3_suspend_quirk,
> };
>

>--
>2.17.1
diff mbox series

Patch

diff --git a/drivers/usb/cdns3/host.c b/drivers/usb/cdns3/host.c
index 030d6421abd3..1dfbe23fa089 100644
--- a/drivers/usb/cdns3/host.c
+++ b/drivers/usb/cdns3/host.c
@@ -24,6 +24,7 @@ 
 #define LPM_2_STB_SWITCH_EN	(1 << 25)
 
 static const struct xhci_plat_priv xhci_plat_cdns3_xhci = {
+	.quirks = XHCI_SKIP_PHY_INIT,
 	.suspend_quirk = xhci_cdns3_suspend_quirk,
 };