diff mbox series

[2/2] drm/i915/gt: raise logging level of "gpu reset disabled" message

Message ID CA+GA0_tJyx-Xj6ORoBWj8+E8hXftWj4+qDMqvy83W7gQpMZ9oA@mail.gmail.com (mailing list archive)
State New, archived
Headers show
Series [1/2] drm/i915/gt: obey "reset" module parameter | expand

Commit Message

Marcin Ślusarz Aug. 18, 2020, 11:37 a.m. UTC 
From: Marcin Ślusarz <marcin.slusarz@intel.com>

Few lines above there's drm_notice saying that the gpu will be reset.
Printing "gpu reset disabled" using lower logging level makes it
harder to figure out what happened.

Signed-off-by: Marcin Ślusarz <marcin.slusarz@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_reset.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Chris Wilson Aug. 18, 2020, 11:44 a.m. UTC | #1 
Quoting Marcin Ślusarz (2020-08-18 12:37:20)
> From: Marcin Ślusarz <marcin.slusarz@intel.com>
> 
> Few lines above there's drm_notice saying that the gpu will be reset.
> Printing "gpu reset disabled" using lower logging level makes it
> harder to figure out what happened.

It's disabled by user request, and we may do this very very frequently.
If you are wise enough to touch an unsafe module parameter, you get to
keep all the pieces.
-Chris
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c
b/drivers/gpu/drm/i915/gt/intel_reset.c
index f4823ca2d71f..0384315c190d 100644
--- a/drivers/gpu/drm/i915/gt/intel_reset.c
+++ b/drivers/gpu/drm/i915/gt/intel_reset.c
@@ -1042,7 +1042,7 @@  void intel_gt_reset(struct intel_gt *gt,
         if (i915_modparams.reset)
             drm_err(&gt->i915->drm, "GPU reset not supported\n");
         else
-            drm_dbg(&gt->i915->drm, "GPU reset disabled\n");
+            drm_notice(&gt->i915->drm, "GPU reset disabled\n");
         goto error;
     }