mbox series

[0/3] ASoC: da7219: Reorganise device/codec level probe/remove

Message ID cover.1597164865.git.Adam.Thomson.Opensource@diasemi.com (mailing list archive)
Headers show
Series ASoC: da7219: Reorganise device/codec level probe/remove | expand

Message

Adam Thomson Aug. 11, 2020, 4:57 p.m. UTC
This patch set reorganises and fixes device and codec level probe/remove
handling within the driver, to allow clean probe and remove at the codec level.

This set relates to an issue raised by Yong Zhi where a codec level re-probe
would fail due to clks still being registered from the previous instantiation.
In addition some improvements around regulator handling and soft reset have
also been included.

Adam Thomson (3):
  ASoC: da7219: Move required devm_* allocations to device level code
  ASoC: da7219: Move soft reset handling to codec level probe
  ASoC: da7219: Fix clock handling around codec level probe

 sound/soc/codecs/da7219-aad.c |  85 +++++---
 sound/soc/codecs/da7219-aad.h |   3 +
 sound/soc/codecs/da7219.c     | 493 +++++++++++++++++++++++-------------------
 sound/soc/codecs/da7219.h     |   1 +
 4 files changed, 328 insertions(+), 254 deletions(-)

Comments

Zhi, Yong Aug. 18, 2020, 4:38 p.m. UTC | #1
Hi, Adam,

> -----Original Message-----
> From: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
> Sent: Tuesday, August 11, 2020 11:57 AM
> To: Mark Brown <broonie@kernel.org>; Takashi Iwai <tiwai@suse.com>; Liam
> Girdwood <lgirdwood@gmail.com>; Jaroslav Kysela <perex@perex.cz>
> Cc: Zhi, Yong <yong.zhi@intel.com>; Pierre-Louis Bossart <pierre-
> louis.bossart@linux.intel.com>; alsa-devel@alsa-project.org; linux-
> kernel@vger.kernel.org; Support Opensource
> <support.opensource@diasemi.com>
> Subject: [PATCH 0/3] ASoC: da7219: Reorganise device/codec level
> probe/remove
> 
> This patch set reorganises and fixes device and codec level probe/remove
> handling within the driver, to allow clean probe and remove at the codec level.
> 
> This set relates to an issue raised by Yong Zhi where a codec level re-probe
> would fail due to clks still being registered from the previous instantiation.
> In addition some improvements around regulator handling and soft reset have
> also been included.
> 

Just to let you know that I tested this series on the JSL platform, the original issue was resolved, also sanity checked basic use case like plug/unplug and
suspend/resume, no regression found.

thanks,
yong
> Adam Thomson (3):
>   ASoC: da7219: Move required devm_* allocations to device level code
>   ASoC: da7219: Move soft reset handling to codec level probe
>   ASoC: da7219: Fix clock handling around codec level probe
> 
>  sound/soc/codecs/da7219-aad.c |  85 +++++---
>  sound/soc/codecs/da7219-aad.h |   3 +
>  sound/soc/codecs/da7219.c     | 493 +++++++++++++++++++++++-----------------
> --
>  sound/soc/codecs/da7219.h     |   1 +
>  4 files changed, 328 insertions(+), 254 deletions(-)
> 
> --
> 1.9.1
Mark Brown Aug. 18, 2020, 4:55 p.m. UTC | #2
On Tue, 11 Aug 2020 17:57:22 +0100, Adam Thomson wrote:
> This patch set reorganises and fixes device and codec level probe/remove
> handling within the driver, to allow clean probe and remove at the codec level.
> 
> This set relates to an issue raised by Yong Zhi where a codec level re-probe
> would fail due to clks still being registered from the previous instantiation.
> In addition some improvements around regulator handling and soft reset have
> also been included.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/3] ASoC: da7219: Move required devm_* allocations to device level code
      commit: 21f279f34c212e82f0330697394840898908f7a6
[2/3] ASoC: da7219: Move soft reset handling to codec level probe
      commit: aa5b18d1c29023b315073661b74c67f91bf2f27c
[3/3] ASoC: da7219: Fix clock handling around codec level probe
      commit: 78013a1cf2971684775f6956d5666237ac53a1aa

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
Adam Thomson Aug. 18, 2020, 5:16 p.m. UTC | #3
On 18 August 2020 17:39, Zhi, Yong wrote:

> > This patch set reorganises and fixes device and codec level probe/remove
> > handling within the driver, to allow clean probe and remove at the codec level.
> >
> > This set relates to an issue raised by Yong Zhi where a codec level re-probe
> > would fail due to clks still being registered from the previous instantiation.
> > In addition some improvements around regulator handling and soft reset have
> > also been included.
> >
> 
> Just to let you know that I tested this series on the JSL platform, the original issue
> was resolved, also sanity checked basic use case like plug/unplug and
> suspend/resume, no regression found.
> 
> thanks,
> yong

That's great. Many thanks for verifying your side.