diff mbox series

[v1,1/6] dt-bindings: ARM: add bindings for the Meraki MR32

Message ID e276a75d6e631497cfeabec945fe278b7a54057b.1597768760.git.chunkeey@gmail.com (mailing list archive)
State New, archived
Headers show
Series [v1,1/6] dt-bindings: ARM: add bindings for the Meraki MR32 | expand

Commit Message

Christian Lamparter Aug. 18, 2020, 4:39 p.m. UTC
This patch adds the bindings for the Meraki MR32's SoC BCM53016.
Broadcom lists them all under the BCM5301x umbrella on their side:

<https://www.broadcom.com/products/embedded-and-networking-processors/communications/bcm5301x>

"BCM53012 and BCM53016 with dual-core Cortex-A9 CPU at 1 GHz, 256KB L2 cache,
 16-bit DDR2 interface, USB3 integrated switch, GPHYs and packet accelerator".

This patch also adds the "Meraki" vendor. It's wikipedia article states that
<https://en.wikipedia.org/wiki/Cisco_Meraki> Meraki was a start-up, founded
in 2006 as based in part on the MIT Roofnet Project. In 2012 Cisco Systems
bought the whole joint and kept the "Meraki" branding around to this day.

Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
---
 Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml | 2 ++
 Documentation/devicetree/bindings/vendor-prefixes.yaml      | 2 ++
 2 files changed, 4 insertions(+)

Comments

Scott Branden Aug. 18, 2020, 5:45 p.m. UTC | #1
On 2020-08-18 9:39 a.m., Christian Lamparter wrote:
> This patch adds the bindings for the Meraki MR32's SoC BCM53016.
See Documentation/process/submitting-patches.rst

Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
to do frotz", as if you are giving orders to the codebase to change
its behaviour
> Broadcom lists them all under the BCM5301x umbrella on their side:
>
> <https://www.broadcom.com/products/embedded-and-networking-processors/communications/bcm5301x>
>
> "BCM53012 and BCM53016 with dual-core Cortex-A9 CPU at 1 GHz, 256KB L2 cache,
>  16-bit DDR2 interface, USB3 integrated switch, GPHYs and packet accelerator".
>
> This patch also adds the "Meraki" vendor. It's wikipedia article states that
Same here.
> <https://en.wikipedia.org/wiki/Cisco_Meraki> Meraki was a start-up, founded
> in 2006 as based in part on the MIT Roofnet Project. In 2012 Cisco Systems
> bought the whole joint and kept the "Meraki" branding around to this day.
>
> Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
Other than that:
Acked-by: Scott Branden <scott.branden@broadcom.com>
> ---
>  Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml | 2 ++
>  Documentation/devicetree/bindings/vendor-prefixes.yaml      | 2 ++
>  2 files changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml
> index d48313c7ae45..988e0bbb2a62 100644
> --- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml
> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml
> @@ -83,6 +83,8 @@ properties:
>                - brcm,bcm953012er
>                - brcm,bcm953012hr
>                - brcm,bcm953012k
> +              - meraki,mr32
>            - const: brcm,brcm53012
> +          - const: brcm,brcm53016
>            - const: brcm,bcm4708
>  ...
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 9aeab66be85f..12b8b387fe30 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -637,6 +637,8 @@ patternProperties:
>      description: MEMSIC Inc.
>    "^menlo,.*":
>      description: Menlo Systems GmbH
> +  "^meraki,.*":
> +    description: Cisco Meraki, LLC
>    "^merrii,.*":
>      description: Merrii Technology Co., Ltd.
>    "^micrel,.*":
Florian Fainelli Aug. 18, 2020, 7:51 p.m. UTC | #2
On 8/18/2020 9:39 AM, Christian Lamparter wrote:
> This patch adds the bindings for the Meraki MR32's SoC BCM53016.
> Broadcom lists them all under the BCM5301x umbrella on their side:
> 
> <https://www.broadcom.com/products/embedded-and-networking-processors/communications/bcm5301x>
> 
> "BCM53012 and BCM53016 with dual-core Cortex-A9 CPU at 1 GHz, 256KB L2 cache,
>   16-bit DDR2 interface, USB3 integrated switch, GPHYs and packet accelerator".
> 
> This patch also adds the "Meraki" vendor. It's wikipedia article states that
> <https://en.wikipedia.org/wiki/Cisco_Meraki> Meraki was a start-up, founded
> in 2006 as based in part on the MIT Roofnet Project. In 2012 Cisco Systems
> bought the whole joint and kept the "Meraki" branding around to this day.
> 
> Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
> ---
>   Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml | 2 ++
>   Documentation/devicetree/bindings/vendor-prefixes.yaml      | 2 ++

Can you separate out the vendor-prefixes.yaml change from the board 
change? Rob could probably fast track the vendor prefix, while we will 
have to wait for the 5.10 window to merge your changes.

Thanks
Florian Fainelli Aug. 18, 2020, 7:59 p.m. UTC | #3
On 8/18/2020 12:51 PM, Florian Fainelli wrote:
> 
> 
> On 8/18/2020 9:39 AM, Christian Lamparter wrote:
>> This patch adds the bindings for the Meraki MR32's SoC BCM53016.
>> Broadcom lists them all under the BCM5301x umbrella on their side:
>>
>> <https://www.broadcom.com/products/embedded-and-networking-processors/communications/bcm5301x> 
>>
>>
>> "BCM53012 and BCM53016 with dual-core Cortex-A9 CPU at 1 GHz, 256KB L2 
>> cache,
>>   16-bit DDR2 interface, USB3 integrated switch, GPHYs and packet 
>> accelerator".
>>
>> This patch also adds the "Meraki" vendor. It's wikipedia article 
>> states that
>> <https://en.wikipedia.org/wiki/Cisco_Meraki> Meraki was a start-up, 
>> founded
>> in 2006 as based in part on the MIT Roofnet Project. In 2012 Cisco 
>> Systems
>> bought the whole joint and kept the "Meraki" branding around to this day.
>>
>> Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
>> ---
>>   Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml | 2 ++
>>   Documentation/devicetree/bindings/vendor-prefixes.yaml      | 2 ++
> 
> Can you separate out the vendor-prefixes.yaml change from the board 
> change? Rob could probably fast track the vendor prefix, while we will 
> have to wait for the 5.10 window to merge your changes.

Also, please provide a cover-letter such that all patches appear as a 
reply to your cover letter, this makes it easier for threading in mail 
clients, thanks!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml
index d48313c7ae45..988e0bbb2a62 100644
--- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml
+++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml
@@ -83,6 +83,8 @@  properties:
               - brcm,bcm953012er
               - brcm,bcm953012hr
               - brcm,bcm953012k
+              - meraki,mr32
           - const: brcm,brcm53012
+          - const: brcm,brcm53016
           - const: brcm,bcm4708
 ...
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 9aeab66be85f..12b8b387fe30 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -637,6 +637,8 @@  patternProperties:
     description: MEMSIC Inc.
   "^menlo,.*":
     description: Menlo Systems GmbH
+  "^meraki,.*":
+    description: Cisco Meraki, LLC
   "^merrii,.*":
     description: Merrii Technology Co., Ltd.
   "^micrel,.*":