| Message ID | 20200813083925.7830-2-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Pavel Machek |
| Headers | show |
| Series | [4.19.y-cip,1/2] drm: Add drm_atomic_get_old/new_private_obj_state | expand |
Hi! > From: Benjamin Gaignard <benjamin.gaignard@st.com> > > commit bf5d837a0a4ced7cc223befc9e76d4ad30697d27 upstream. > > Few for_each macro set variables that are never used later which led > to generate unused-but-set-variable warnings. > Add (void)(foo) inside the macros to remove these warnings > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> > Link: https://patchwork.freedesktop.org/patch/msgid/20191008124254.2144-1-benjamin.gaignard@st.com > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Thanks for the fixes. Applied and pushed out. Best regards, Pavel
Hi Pavel, > -----Original Message----- > From: Pavel Machek [mailto:pavel@denx.de] > Sent: Friday, August 14, 2020 5:49 AM > To: Biju Das <biju.das.jz@bp.renesas.com> > Cc: cip-dev@lists.cip-project.org; iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ) > <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de>; Chris Paterson <chris.paterson2@renesas.com>; > Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com> > Subject: Re: [PATCH 4.19.y-cip 2/2] drm: atomic helper: fix W=1 warnings > > Hi! > > > From: Benjamin Gaignard <benjamin.gaignard@st.com> > > > > commit bf5d837a0a4ced7cc223befc9e76d4ad30697d27 upstream. > > > > Few for_each macro set variables that are never used later which led > > to generate unused-but-set-variable warnings. > > Add (void)(foo) inside the macros to remove these warnings > > > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> > > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> > > Link: https://patchwork.freedesktop.org/patch/msgid/20191008124254.2144-1-benjamin.gaignard@st.com > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > Thanks for the fixes. Applied and pushed out. This patch doesn't seem to have been pushed yet. Could you push me? > > Best regards, > Pavel Best regards, Nobuhiro > > -- > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#5156): https://lists.cip-project.org/g/cip-dev/message/5156 Mute This Topic: https://lists.cip-project.org/mt/76165489/4520428 Group Owner: cip-dev+owner@lists.cip-project.org Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129116/1171672734/xyzzy [patchwork-cip-dev@patchwork.kernel.org] -=-=-=-=-=-=-=-=-=-=-=-
Hi! > > > commit bf5d837a0a4ced7cc223befc9e76d4ad30697d27 upstream. > > > > > > Few for_each macro set variables that are never used later which led > > > to generate unused-but-set-variable warnings. > > > Add (void)(foo) inside the macros to remove these warnings > > > > > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> > > > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> > > > Link: https://patchwork.freedesktop.org/patch/msgid/20191008124254.2144-1-benjamin.gaignard@st.com > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > > > Thanks for the fixes. Applied and pushed out. > > This patch doesn't seem to have been pushed yet. > Could you push me? Sorry for that, should be fixed now. Best regards, Pavel
diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h index 6329ed4af310..9042fdae9211 100644 --- a/include/drm/drm_atomic.h +++ b/include/drm/drm_atomic.h @@ -662,6 +662,7 @@ void drm_state_dump(struct drm_device *dev, struct drm_printer *p); (__i)++) \ for_each_if ((__state)->connectors[__i].ptr && \ ((connector) = (__state)->connectors[__i].ptr, \ + (void)(connector) /* Only to avoid unused-but-set-variable warning */, \ (old_connector_state) = (__state)->connectors[__i].old_state, \ (new_connector_state) = (__state)->connectors[__i].new_state, 1)) @@ -683,6 +684,7 @@ void drm_state_dump(struct drm_device *dev, struct drm_printer *p); (__i)++) \ for_each_if ((__state)->connectors[__i].ptr && \ ((connector) = (__state)->connectors[__i].ptr, \ + (void)(connector) /* Only to avoid unused-but-set-variable warning */, \ (old_connector_state) = (__state)->connectors[__i].old_state, 1)) /** @@ -703,7 +705,9 @@ void drm_state_dump(struct drm_device *dev, struct drm_printer *p); (__i)++) \ for_each_if ((__state)->connectors[__i].ptr && \ ((connector) = (__state)->connectors[__i].ptr, \ - (new_connector_state) = (__state)->connectors[__i].new_state, 1)) + (void)(connector) /* Only to avoid unused-but-set-variable warning */, \ + (new_connector_state) = (__state)->connectors[__i].new_state, \ + (void)(new_connector_state) /* Only to avoid unused-but-set-variable warning */, 1)) /** * for_each_oldnew_crtc_in_state - iterate over all CRTCs in an atomic update @@ -723,7 +727,9 @@ void drm_state_dump(struct drm_device *dev, struct drm_printer *p); (__i)++) \ for_each_if ((__state)->crtcs[__i].ptr && \ ((crtc) = (__state)->crtcs[__i].ptr, \ + (void)(crtc) /* Only to avoid unused-but-set-variable warning */, \ (old_crtc_state) = (__state)->crtcs[__i].old_state, \ + (void)(old_crtc_state) /* Only to avoid unused-but-set-variable warning */, \ (new_crtc_state) = (__state)->crtcs[__i].new_state, 1)) /** @@ -762,7 +768,9 @@ void drm_state_dump(struct drm_device *dev, struct drm_printer *p); (__i)++) \ for_each_if ((__state)->crtcs[__i].ptr && \ ((crtc) = (__state)->crtcs[__i].ptr, \ - (new_crtc_state) = (__state)->crtcs[__i].new_state, 1)) + (void)(crtc) /* Only to avoid unused-but-set-variable warning */, \ + (new_crtc_state) = (__state)->crtcs[__i].new_state, \ + (void)(new_crtc_state) /* Only to avoid unused-but-set-variable warning */, 1)) /** * for_each_oldnew_plane_in_state - iterate over all planes in an atomic update @@ -782,6 +790,7 @@ void drm_state_dump(struct drm_device *dev, struct drm_printer *p); (__i)++) \ for_each_if ((__state)->planes[__i].ptr && \ ((plane) = (__state)->planes[__i].ptr, \ + (void)(plane) /* Only to avoid unused-but-set-variable warning */, \ (old_plane_state) = (__state)->planes[__i].old_state,\ (new_plane_state) = (__state)->planes[__i].new_state, 1)) @@ -842,7 +851,9 @@ void drm_state_dump(struct drm_device *dev, struct drm_printer *p); (__i)++) \ for_each_if ((__state)->planes[__i].ptr && \ ((plane) = (__state)->planes[__i].ptr, \ - (new_plane_state) = (__state)->planes[__i].new_state, 1)) + (void)(plane) /* Only to avoid unused-but-set-variable warning */, \ + (new_plane_state) = (__state)->planes[__i].new_state, \ + (void)(new_plane_state) /* Only to avoid unused-but-set-variable warning */, 1)) /** * for_each_oldnew_private_obj_in_state - iterate over all private objects in an atomic update