| Message ID | 1597831670-17401-3-git-send-email-mkshah@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Modularize RPMH driver | expand |
Quoting Maulik Shah (2020-08-19 03:07:50) > The _rcuidle tracepoints are removed from RPMH driver which prevented > to compile it as module. Bring back the change to make it module. > > This reverts commit 1f7a3eb785e4a4e196729cd3d5ec97bd5f9f2940. > > Cc: John Stultz <john.stultz@linaro.org> > Cc: Stephen Rothwell <sfr@canb.auug.org.au> > Cc: Todd Kjos <tkjos@google.com> > Cc: Saravana Kannan <saravanak@google.com> > Signed-off-by: Maulik Shah <mkshah@codeaurora.org> > --- Please send the original patch and add your SoB to it. Reverting a patch out of the history works, but doesn't do justice to the authorship of the patch.
Hi, On 8/21/2020 4:42 AM, Stephen Boyd wrote: > Quoting Maulik Shah (2020-08-19 03:07:50) >> The _rcuidle tracepoints are removed from RPMH driver which prevented >> to compile it as module. Bring back the change to make it module. >> >> This reverts commit 1f7a3eb785e4a4e196729cd3d5ec97bd5f9f2940. >> >> Cc: John Stultz <john.stultz@linaro.org> >> Cc: Stephen Rothwell <sfr@canb.auug.org.au> >> Cc: Todd Kjos <tkjos@google.com> >> Cc: Saravana Kannan <saravanak@google.com> >> Signed-off-by: Maulik Shah <mkshah@codeaurora.org> >> --- > Please send the original patch and add your SoB to it. Reverting a patch > out of the history works, but doesn't do justice to the authorship of > the patch. Sure, i will re-send the original patch in v2 instead of doing revert's revert. Thanks, Maulik
diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig index 3dc3e3d..892bdc7 100644 --- a/drivers/soc/qcom/Kconfig +++ b/drivers/soc/qcom/Kconfig @@ -92,7 +92,7 @@ config QCOM_RMTFS_MEM Say y here if you intend to boot the modem remoteproc. config QCOM_RPMH - bool "Qualcomm RPM-Hardened (RPMH) Communication" + tristate "Qualcomm RPM-Hardened (RPMH) Communication" depends on ARCH_QCOM || COMPILE_TEST help Support for communication with the hardened-RPM blocks in diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c index fabe390d..5fce87c 100644 --- a/drivers/soc/qcom/rpmh-rsc.c +++ b/drivers/soc/qcom/rpmh-rsc.c @@ -13,6 +13,7 @@ #include <linux/iopoll.h> #include <linux/kernel.h> #include <linux/list.h> +#include <linux/module.h> #include <linux/of.h> #include <linux/of_irq.h> #include <linux/of_platform.h> @@ -1025,6 +1026,7 @@ static const struct of_device_id rpmh_drv_match[] = { { .compatible = "qcom,rpmh-rsc", }, { } }; +MODULE_DEVICE_TABLE(of, rpmh_drv_match); static struct platform_driver rpmh_driver = { .probe = rpmh_rsc_probe, @@ -1040,3 +1042,6 @@ static int __init rpmh_driver_init(void) return platform_driver_register(&rpmh_driver); } arch_initcall(rpmh_driver_init); + +MODULE_DESCRIPTION("Qualcomm Technologies, Inc. RPMh Driver"); +MODULE_LICENSE("GPL v2");
The _rcuidle tracepoints are removed from RPMH driver which prevented to compile it as module. Bring back the change to make it module. This reverts commit 1f7a3eb785e4a4e196729cd3d5ec97bd5f9f2940. Cc: John Stultz <john.stultz@linaro.org> Cc: Stephen Rothwell <sfr@canb.auug.org.au> Cc: Todd Kjos <tkjos@google.com> Cc: Saravana Kannan <saravanak@google.com> Signed-off-by: Maulik Shah <mkshah@codeaurora.org> --- drivers/soc/qcom/Kconfig | 2 +- drivers/soc/qcom/rpmh-rsc.c | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-)