| Message ID | pull.411.git.1597655273.gitgitgadget@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Optionally skip linking/copying the built-ins | expand |
Hi, On Mon, 17 Aug 2020, Johannes Schindelin wrote: > The dashed form of the built-ins is so passé. > > Incidentally, this also handles the .pdb issue in MSVC's install Makefile > target that Peff pointed out in the context of the "slimming down" patch > series > [https://lore.kernel.org/git/20200813145719.GA891370@coredump.intra.peff.net/] > . > > This addresses https://github.com/gitgitgadget/git/issues/406 Please note that this GitGitGadget run did not work as intended. The intention of https://github.com/gitgitgadget/gitgitgadget/pull/296 was to use the actual author in the `From:` headers of the sent emails, with GitGitGadget mentioned in the `Sender:` header, but apparently this did not work, and I will be reverting that PR for the time being. In short: please do not apply these patches as-are, unless adjusting the author email to match my email address. Thank you, Dscho > > Johannes Schindelin (3): > msvc: copy the correct `.pdb` files in the Makefile target `install` > Optionally skip linking/copying the built-ins > ci: stop linking built-ins to the dashed versions > > Makefile | 69 +++++++++++++++++++++------------------ > ci/run-build-and-tests.sh | 2 +- > 2 files changed, 39 insertions(+), 32 deletions(-) > > > base-commit: b6a658bd00c9c29e07f833cabfc0ef12224e277a > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-411%2Fdscho%2Foptionally-skip-dashed-built-ins-v1 > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-411/dscho/optionally-skip-dashed-built-ins-v1 > Pull-Request: https://github.com/gitgitgadget/git/pull/411 > -- > gitgitgadget > >
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: >> This addresses https://github.com/gitgitgadget/git/issues/406 > > Please note that this GitGitGadget run did not work as intended. The > intention of https://github.com/gitgitgadget/gitgitgadget/pull/296 was to > use the actual author in the `From:` headers of the sent emails, with > GitGitGadget mentioned in the `Sender:` header, but apparently this did > not work, and I will be reverting that PR for the time being. It is close ;-) The author name is correctly on "From:" but not the address.
Hi Junio, On Mon, 17 Aug 2020, Junio C Hamano wrote: > Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > > >> This addresses https://github.com/gitgitgadget/git/issues/406 > > > > Please note that this GitGitGadget run did not work as intended. The > > intention of https://github.com/gitgitgadget/gitgitgadget/pull/296 was to > > use the actual author in the `From:` headers of the sent emails, with > > GitGitGadget mentioned in the `Sender:` header, but apparently this did > > not work, and I will be reverting that PR for the time being. > > It is close ;-) > > The author name is correctly on "From:" but not the address. Yes, but the problem seems to be insurmountable, as I _think_ it is to prevent spammers from successfully sending "from abitrary email addresses". GMail adds an `X-Google-Original-From:` header with the original `From:` header, and drops the `Sender:` header. There _might_ be other SMTP servers out there that might allow us to do this for GitGitGadget, but I am wary of undermining anti-spam measures that way. Ciao, Dscho
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: >> It is close ;-) >> >> The author name is correctly on "From:" but not the address. > > Yes, but the problem seems to be insurmountable, as I _think_ it is to > prevent spammers from successfully sending "from abitrary email > addresses". At least, even with only the name correction, the threads were easier to locate. Perhaps you can leave the in-body From: in to help "git am" but keep the half-successful attempt to give the human readable name to humans who are reading in their MUA? Thanks.
Hi Junio, On Mon, 24 Aug 2020, Junio C Hamano wrote: > Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > > >> It is close ;-) > >> > >> The author name is correctly on "From:" but not the address. > > > > Yes, but the problem seems to be insurmountable, as I _think_ it is to > > prevent spammers from successfully sending "from abitrary email > > addresses". > > At least, even with only the name correction, the threads were > easier to locate. Perhaps you can leave the in-body From: in to > help "git am" but keep the half-successful attempt to give the human > readable name to humans who are reading in their MUA? But if all you're interested in is the part before the actual email address, isn't "Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>" almost identical to "Johannes Schindelin <gitgitgadget@gmail.com>"? Sorry, I seem to be slow understanding you :-( Ciao, Dscho
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > But if all you're interested in is the part before the actual email > address, isn't "Johannes Schindelin via GitGitGadget > <gitgitgadget@gmail.com>" almost identical to "Johannes Schindelin > <gitgitgadget@gmail.com>"? Here is what I often see in my MUA. O [ 75: Johannes Schindelin ] Re: [PATCH v2 3/3] ci: stop linking bu... OA [ 20: Johannes Schindelin ] pw/add-p-allowed-options-fix, was Re: ... O [ 106: Johannes Schindelin via] [PATCH] git-gui: accommodate for inten... O [ 66: Johannes Schindelin via] [PATCH] mingw: improve performance of ... The "via ..." part may change its length depending on how long the real real name is, but it is irritating and more importantly conveys harmful information, as I am trying to be as neutral as I can when reviewing patches no matteer how they are delivered.