| Message ID | 20200726012557.38282-1-samuel@sholland.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Allwinner A64 digital audio codec fixes | expand |
On Sat, 25 Jul 2020 20:25:50 -0500, Samuel Holland wrote: > This series fixes a couple of issues with the digital audio codec in the > Allwinner A64 SoC: > 1) Left/right channels were swapped when playing/recording audio > 2) DAPM topology was wrong, breaking some kcontrols > > This is the minimum set of changes necessary to fix these issues in a > backward-compatible way. For that reason, some DAPM widgets still have > incorrect or confusing names; those and other issues will be fixed in > later patch sets. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/7] ASoC: dt-bindings: Add a new compatible for the A64 codec commit: cef305d4eb0733f25215793ed30b056a7db9bb62 [2/7] ASoC: sun8i-codec: Fix DAPM to match the hardware topology commit: 90cac932976e93b17203b4216ba83bdcd68e0ed0 [3/7] ASoC: sun8i-codec: Add missing mixer routes commit: e47d2dcd88fc3e6837f8aa0060ce820ec9001e26 [4/7] ASoC: sun8i-codec: Add a quirk for LRCK inversion commit: 7518805fb636308909a6a7953e9fdb194abb15f8 [5/7] ARM: dts: sun8i: a33: Update codec widget names (no commit info) [6/7] arm64: dts: allwinner: a64: Update codec widget names (no commit info) [7/7] arm64: dts: allwinner: a64: Update the audio codec compatible (no commit info) All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
Hi Mark, On Tue, Aug 18, 2020 at 05:54:50PM +0100, Mark Brown wrote: > On Sat, 25 Jul 2020 20:25:50 -0500, Samuel Holland wrote: > > This series fixes a couple of issues with the digital audio codec in the > > Allwinner A64 SoC: > > 1) Left/right channels were swapped when playing/recording audio > > 2) DAPM topology was wrong, breaking some kcontrols > > > > This is the minimum set of changes necessary to fix these issues in a > > backward-compatible way. For that reason, some DAPM widgets still have > > incorrect or confusing names; those and other issues will be fixed in > > later patch sets. > > > > [...] > > Applied to > > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next > > Thanks! > > [1/7] ASoC: dt-bindings: Add a new compatible for the A64 codec > commit: cef305d4eb0733f25215793ed30b056a7db9bb62 > [2/7] ASoC: sun8i-codec: Fix DAPM to match the hardware topology > commit: 90cac932976e93b17203b4216ba83bdcd68e0ed0 > [3/7] ASoC: sun8i-codec: Add missing mixer routes > commit: e47d2dcd88fc3e6837f8aa0060ce820ec9001e26 > [4/7] ASoC: sun8i-codec: Add a quirk for LRCK inversion > commit: 7518805fb636308909a6a7953e9fdb194abb15f8 > [5/7] ARM: dts: sun8i: a33: Update codec widget names > (no commit info) > [6/7] arm64: dts: allwinner: a64: Update codec widget names > (no commit info) > [7/7] arm64: dts: allwinner: a64: Update the audio codec compatible > (no commit info) Ideally we should get the DT patches through arm-soc, can you drop the patches 5 to 7? Thanks! Maxime
On Mon, Aug 24, 2020 at 04:03:34PM +0200, Maxime Ripard wrote: > > [5/7] ARM: dts: sun8i: a33: Update codec widget names > > (no commit info) > > [6/7] arm64: dts: allwinner: a64: Update codec widget names > > (no commit info) > > [7/7] arm64: dts: allwinner: a64: Update the audio codec compatible > > (no commit info) > Ideally we should get the DT patches through arm-soc, can you drop the > patches 5 to 7? When it says "no commit info" that means the patch wasn't applied.
On Tue, Aug 25, 2020 at 04:36:52PM +0100, Mark Brown wrote: > On Mon, Aug 24, 2020 at 04:03:34PM +0200, Maxime Ripard wrote: > > > > [5/7] ARM: dts: sun8i: a33: Update codec widget names > > > (no commit info) > > > [6/7] arm64: dts: allwinner: a64: Update codec widget names > > > (no commit info) > > > [7/7] arm64: dts: allwinner: a64: Update the audio codec compatible > > > (no commit info) > > > Ideally we should get the DT patches through arm-soc, can you drop the > > patches 5 to 7? > > When it says "no commit info" that means the patch wasn't applied. My bad, thanks :) Maxime
On Sat, Jul 25, 2020 at 08:25:50PM -0500, Samuel Holland wrote: > This series fixes a couple of issues with the digital audio codec in the > Allwinner A64 SoC: > 1) Left/right channels were swapped when playing/recording audio > 2) DAPM topology was wrong, breaking some kcontrols > > This is the minimum set of changes necessary to fix these issues in a > backward-compatible way. For that reason, some DAPM widgets still have > incorrect or confusing names; those and other issues will be fixed in > later patch sets. > > Samuel Holland (7): > ASoC: dt-bindings: Add a new compatible for the A64 codec > ASoC: sun8i-codec: Fix DAPM to match the hardware topology > ASoC: sun8i-codec: Add missing mixer routes > ASoC: sun8i-codec: Add a quirk for LRCK inversion > ARM: dts: sun8i: a33: Update codec widget names > arm64: dts: allwinner: a64: Update codec widget names > arm64: dts: allwinner: a64: Update the audio codec compatible Applied patcehs 5-7 Maxime
This caught my eye and brought up an issue I've been wondering about for some time: On Fri, 28 Aug 2020, Maxime Ripard wrote: > On Sat, Jul 25, 2020 at 08:25:50PM -0500, Samuel Holland wrote: > > ... some DAPM widgets still have incorrect or confusing names; those > > and other issues will be fixed in later patch sets. As a general and firm rule in the Linux kernel when it comes to upgrades and fixes is "We do not break userspace". Which means that for instance an application must not stop working after a kernel upgrade due to some API changing. So does this mean that the name of an ALSA control, once it's in the mainline kernel, can never be changed, for whatever reason? Or devicetree properties, does the same apply there? Say a property as a confusing name, is it possible to change it at all? Or are these things open to debate, depending on the severity and consequences etc? /Ricard