mbox series

[0/7] Allwinner A64 digital audio codec fixes

Message ID 20200726012557.38282-1-samuel@sholland.org (mailing list archive)
Headers show
Series Allwinner A64 digital audio codec fixes | expand

Message

Samuel Holland July 26, 2020, 1:25 a.m. UTC
This series fixes a couple of issues with the digital audio codec in the
Allwinner A64 SoC:
  1) Left/right channels were swapped when playing/recording audio
  2) DAPM topology was wrong, breaking some kcontrols

This is the minimum set of changes necessary to fix these issues in a
backward-compatible way. For that reason, some DAPM widgets still have
incorrect or confusing names; those and other issues will be fixed in
later patch sets.

Samuel Holland (7):
  ASoC: dt-bindings: Add a new compatible for the A64 codec
  ASoC: sun8i-codec: Fix DAPM to match the hardware topology
  ASoC: sun8i-codec: Add missing mixer routes
  ASoC: sun8i-codec: Add a quirk for LRCK inversion
  ARM: dts: sun8i: a33: Update codec widget names
  arm64: dts: allwinner: a64: Update codec widget names
  arm64: dts: allwinner: a64: Update the audio codec compatible

 .../sound/allwinner,sun8i-a33-codec.yaml      |   6 +-
 arch/arm/boot/dts/sun8i-a33-olinuxino.dts     |   4 +-
 arch/arm/boot/dts/sun8i-a33.dtsi              |   4 +-
 .../dts/allwinner/sun50i-a64-bananapi-m64.dts |   8 +-
 .../dts/allwinner/sun50i-a64-orangepi-win.dts |   8 +-
 .../boot/dts/allwinner/sun50i-a64-pine64.dts  |   8 +-
 .../dts/allwinner/sun50i-a64-pinebook.dts     |   8 +-
 .../dts/allwinner/sun50i-a64-pinephone.dtsi   |   8 +-
 .../boot/dts/allwinner/sun50i-a64-pinetab.dts |   8 +-
 .../allwinner/sun50i-a64-sopine-baseboard.dts |   8 +-
 .../boot/dts/allwinner/sun50i-a64-teres-i.dts |   8 +-
 arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi |  11 +-
 sound/soc/sunxi/sun8i-codec.c                 | 137 ++++++++++++++----
 13 files changed, 155 insertions(+), 71 deletions(-)

Comments

Mark Brown Aug. 18, 2020, 4:54 p.m. UTC | #1
On Sat, 25 Jul 2020 20:25:50 -0500, Samuel Holland wrote:
> This series fixes a couple of issues with the digital audio codec in the
> Allwinner A64 SoC:
>   1) Left/right channels were swapped when playing/recording audio
>   2) DAPM topology was wrong, breaking some kcontrols
> 
> This is the minimum set of changes necessary to fix these issues in a
> backward-compatible way. For that reason, some DAPM widgets still have
> incorrect or confusing names; those and other issues will be fixed in
> later patch sets.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/7] ASoC: dt-bindings: Add a new compatible for the A64 codec
      commit: cef305d4eb0733f25215793ed30b056a7db9bb62
[2/7] ASoC: sun8i-codec: Fix DAPM to match the hardware topology
      commit: 90cac932976e93b17203b4216ba83bdcd68e0ed0
[3/7] ASoC: sun8i-codec: Add missing mixer routes
      commit: e47d2dcd88fc3e6837f8aa0060ce820ec9001e26
[4/7] ASoC: sun8i-codec: Add a quirk for LRCK inversion
      commit: 7518805fb636308909a6a7953e9fdb194abb15f8
[5/7] ARM: dts: sun8i: a33: Update codec widget names
      (no commit info)
[6/7] arm64: dts: allwinner: a64: Update codec widget names
      (no commit info)
[7/7] arm64: dts: allwinner: a64: Update the audio codec compatible
      (no commit info)

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
Maxime Ripard Aug. 24, 2020, 2:03 p.m. UTC | #2
Hi Mark,

On Tue, Aug 18, 2020 at 05:54:50PM +0100, Mark Brown wrote:
> On Sat, 25 Jul 2020 20:25:50 -0500, Samuel Holland wrote:
> > This series fixes a couple of issues with the digital audio codec in the
> > Allwinner A64 SoC:
> >   1) Left/right channels were swapped when playing/recording audio
> >   2) DAPM topology was wrong, breaking some kcontrols
> > 
> > This is the minimum set of changes necessary to fix these issues in a
> > backward-compatible way. For that reason, some DAPM widgets still have
> > incorrect or confusing names; those and other issues will be fixed in
> > later patch sets.
> > 
> > [...]
> 
> Applied to
> 
>    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
> 
> Thanks!
> 
> [1/7] ASoC: dt-bindings: Add a new compatible for the A64 codec
>       commit: cef305d4eb0733f25215793ed30b056a7db9bb62
> [2/7] ASoC: sun8i-codec: Fix DAPM to match the hardware topology
>       commit: 90cac932976e93b17203b4216ba83bdcd68e0ed0
> [3/7] ASoC: sun8i-codec: Add missing mixer routes
>       commit: e47d2dcd88fc3e6837f8aa0060ce820ec9001e26
> [4/7] ASoC: sun8i-codec: Add a quirk for LRCK inversion
>       commit: 7518805fb636308909a6a7953e9fdb194abb15f8
> [5/7] ARM: dts: sun8i: a33: Update codec widget names
>       (no commit info)
> [6/7] arm64: dts: allwinner: a64: Update codec widget names
>       (no commit info)
> [7/7] arm64: dts: allwinner: a64: Update the audio codec compatible
>       (no commit info)

Ideally we should get the DT patches through arm-soc, can you drop the
patches 5 to 7?

Thanks!
Maxime
Mark Brown Aug. 25, 2020, 3:36 p.m. UTC | #3
On Mon, Aug 24, 2020 at 04:03:34PM +0200, Maxime Ripard wrote:

> > [5/7] ARM: dts: sun8i: a33: Update codec widget names
> >       (no commit info)
> > [6/7] arm64: dts: allwinner: a64: Update codec widget names
> >       (no commit info)
> > [7/7] arm64: dts: allwinner: a64: Update the audio codec compatible
> >       (no commit info)

> Ideally we should get the DT patches through arm-soc, can you drop the
> patches 5 to 7?

When it says "no commit info" that means the patch wasn't applied.
Maxime Ripard Aug. 28, 2020, 10:08 a.m. UTC | #4
On Tue, Aug 25, 2020 at 04:36:52PM +0100, Mark Brown wrote:
> On Mon, Aug 24, 2020 at 04:03:34PM +0200, Maxime Ripard wrote:
> 
> > > [5/7] ARM: dts: sun8i: a33: Update codec widget names
> > >       (no commit info)
> > > [6/7] arm64: dts: allwinner: a64: Update codec widget names
> > >       (no commit info)
> > > [7/7] arm64: dts: allwinner: a64: Update the audio codec compatible
> > >       (no commit info)
> 
> > Ideally we should get the DT patches through arm-soc, can you drop the
> > patches 5 to 7?
> 
> When it says "no commit info" that means the patch wasn't applied.

My bad, thanks :)

Maxime
Maxime Ripard Aug. 28, 2020, 10:49 a.m. UTC | #5
On Sat, Jul 25, 2020 at 08:25:50PM -0500, Samuel Holland wrote:
> This series fixes a couple of issues with the digital audio codec in the
> Allwinner A64 SoC:
>   1) Left/right channels were swapped when playing/recording audio
>   2) DAPM topology was wrong, breaking some kcontrols
> 
> This is the minimum set of changes necessary to fix these issues in a
> backward-compatible way. For that reason, some DAPM widgets still have
> incorrect or confusing names; those and other issues will be fixed in
> later patch sets.
> 
> Samuel Holland (7):
>   ASoC: dt-bindings: Add a new compatible for the A64 codec
>   ASoC: sun8i-codec: Fix DAPM to match the hardware topology
>   ASoC: sun8i-codec: Add missing mixer routes
>   ASoC: sun8i-codec: Add a quirk for LRCK inversion
>   ARM: dts: sun8i: a33: Update codec widget names
>   arm64: dts: allwinner: a64: Update codec widget names
>   arm64: dts: allwinner: a64: Update the audio codec compatible

Applied patcehs 5-7

Maxime