| Message ID | 20200814160241.7915-11-pannengyuan@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fix some error memleaks | expand |
On Fri, Aug 14, 2020 at 12:02:39PM -0400, Pan Nengyuan wrote: > local_err is not initialized to NULL, it will cause a assert error as below: > qemu/util/error.c:59: error_setv: Assertion `*errp == NULL' failed. > > Fixes: c6447510690 > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com> > --- > Cc: Kevin Wolf <kwolf@redhat.com> > Cc: Max Reitz <mreitz@redhat.com> > Cc: Aarushi Mehta <mehta.aaru20@gmail.com> > Cc: qemu-block@nongnu.org > --- > block/file-posix.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> Thanks, Stefano > > diff --git a/block/file-posix.c b/block/file-posix.c > index 9a00d4190a..697a7d9eea 100644 > --- a/block/file-posix.c > +++ b/block/file-posix.c > @@ -2113,7 +2113,7 @@ static void raw_aio_attach_aio_context(BlockDriverState *bs, > #endif > #ifdef CONFIG_LINUX_IO_URING > if (s->use_linux_io_uring) { > - Error *local_err; > + Error *local_err = NULL; > if (!aio_setup_linux_io_uring(new_context, &local_err)) { > error_reportf_err(local_err, "Unable to use linux io_uring, " > "falling back to thread pool: "); > -- > 2.18.2 > >
Am 14.08.2020 um 18:02 hat Pan Nengyuan geschrieben: > local_err is not initialized to NULL, it will cause a assert error as below: > qemu/util/error.c:59: error_setv: Assertion `*errp == NULL' failed. > > Fixes: c6447510690 > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com> Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Pan Nengyuan <pannengyuan@huawei.com> 于2020年8月14日周五 下午6:32写道： > > local_err is not initialized to NULL, it will cause a assert error as below: > qemu/util/error.c:59: error_setv: Assertion `*errp == NULL' failed. > > Fixes: c6447510690 > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com> Reviewed-by: Li Qiang <liq3ea@gmail.com> > --- > Cc: Kevin Wolf <kwolf@redhat.com> > Cc: Max Reitz <mreitz@redhat.com> > Cc: Aarushi Mehta <mehta.aaru20@gmail.com> > Cc: qemu-block@nongnu.org > --- > block/file-posix.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/file-posix.c b/block/file-posix.c > index 9a00d4190a..697a7d9eea 100644 > --- a/block/file-posix.c > +++ b/block/file-posix.c > @@ -2113,7 +2113,7 @@ static void raw_aio_attach_aio_context(BlockDriverState *bs, > #endif > #ifdef CONFIG_LINUX_IO_URING > if (s->use_linux_io_uring) { > - Error *local_err; > + Error *local_err = NULL; > if (!aio_setup_linux_io_uring(new_context, &local_err)) { > error_reportf_err(local_err, "Unable to use linux io_uring, " > "falling back to thread pool: "); > -- > 2.18.2 > >
diff --git a/block/file-posix.c b/block/file-posix.c index 9a00d4190a..697a7d9eea 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -2113,7 +2113,7 @@ static void raw_aio_attach_aio_context(BlockDriverState *bs, #endif #ifdef CONFIG_LINUX_IO_URING if (s->use_linux_io_uring) { - Error *local_err; + Error *local_err = NULL; if (!aio_setup_linux_io_uring(new_context, &local_err)) { error_reportf_err(local_err, "Unable to use linux io_uring, " "falling back to thread pool: ");
local_err is not initialized to NULL, it will cause a assert error as below: qemu/util/error.c:59: error_setv: Assertion `*errp == NULL' failed. Fixes: c6447510690 Reported-by: Euler Robot <euler.robot@huawei.com> Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com> --- Cc: Kevin Wolf <kwolf@redhat.com> Cc: Max Reitz <mreitz@redhat.com> Cc: Aarushi Mehta <mehta.aaru20@gmail.com> Cc: qemu-block@nongnu.org --- block/file-posix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)