| Message ID | 20200814160241.7915-4-pannengyuan@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fix some error memleaks | expand |
On Fri, 14 Aug 2020 12:02:32 -0400 Pan Nengyuan <pannengyuan@huawei.com> wrote: > Missing g_error_free in QEMU_Elf_init() error path. Fix that. > > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com> > --- > Cc: Viktor Prutyanov <viktor.prutyanov@phystech.edu> > --- > contrib/elf2dmp/qemu_elf.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/contrib/elf2dmp/qemu_elf.c b/contrib/elf2dmp/qemu_elf.c > index 0db7816586..b601b6d7ba 100644 > --- a/contrib/elf2dmp/qemu_elf.c > +++ b/contrib/elf2dmp/qemu_elf.c > @@ -126,6 +126,7 @@ int QEMU_Elf_init(QEMU_Elf *qe, const char > *filename) qe->gmf = g_mapped_file_new(filename, TRUE, &gerr); > if (gerr) { > eprintf("Failed to map ELF dump file \'%s\'\n", filename); > + g_error_free(gerr); > return 1; > } > Reviewed-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Pan Nengyuan <pannengyuan@huawei.com> 于2020年8月14日周五 下午6:28写道： > > Missing g_error_free in QEMU_Elf_init() error path. Fix that. > > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com> Reviewed-by: Li Qiang <liq3ea@gmail.com> > --- > Cc: Viktor Prutyanov <viktor.prutyanov@phystech.edu> > --- > contrib/elf2dmp/qemu_elf.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/contrib/elf2dmp/qemu_elf.c b/contrib/elf2dmp/qemu_elf.c > index 0db7816586..b601b6d7ba 100644 > --- a/contrib/elf2dmp/qemu_elf.c > +++ b/contrib/elf2dmp/qemu_elf.c > @@ -126,6 +126,7 @@ int QEMU_Elf_init(QEMU_Elf *qe, const char *filename) > qe->gmf = g_mapped_file_new(filename, TRUE, &gerr); > if (gerr) { > eprintf("Failed to map ELF dump file \'%s\'\n", filename); > + g_error_free(gerr); > return 1; > } > > -- > 2.18.2 > >
diff --git a/contrib/elf2dmp/qemu_elf.c b/contrib/elf2dmp/qemu_elf.c index 0db7816586..b601b6d7ba 100644 --- a/contrib/elf2dmp/qemu_elf.c +++ b/contrib/elf2dmp/qemu_elf.c @@ -126,6 +126,7 @@ int QEMU_Elf_init(QEMU_Elf *qe, const char *filename) qe->gmf = g_mapped_file_new(filename, TRUE, &gerr); if (gerr) { eprintf("Failed to map ELF dump file \'%s\'\n", filename); + g_error_free(gerr); return 1; }
Missing g_error_free in QEMU_Elf_init() error path. Fix that. Reported-by: Euler Robot <euler.robot@huawei.com> Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com> --- Cc: Viktor Prutyanov <viktor.prutyanov@phystech.edu> --- contrib/elf2dmp/qemu_elf.c | 1 + 1 file changed, 1 insertion(+)