mbox series

[4.19.y-cip,00/10] Add support for [H]SCIF/SDHI/I2C/RWDT/MSIOF

Message ID 20200826112132.4090-1-biju.das.jz@bp.renesas.com (mailing list archive)
Headers show
Series Add support for [H]SCIF/SDHI/I2C/RWDT/MSIOF | expand

Message

Biju Das Aug. 26, 2020, 11:21 a.m. UTC
Add RZ/G2H SoC support for [H]SCIF/SDHI/I2C/RWDT/MSIOF on 4.19.y-cip kernel.

All the patches in this series are cherry-piced from ML, except [1] which is 
a new patch similar to the workdone for other similar SoC's

[1] mmc: renesas_sdhi_internal_dmac: Add r8a774e1 support

This patch series depend on [2]
[2] https://patchwork.kernel.org/project/cip-dev/list/?series=338235

Biju Das (1):
  mmc: renesas_sdhi_internal_dmac: Add r8a774e1 support

Lad Prabhakar (9):
  arm64: dts: renesas: r8a774e1: Add SCIF and HSCIF nodes
  arm64: dts: renesas: r8a774e1: Add SDHI nodes
  dt-bindings: i2c: renesas,i2c: Document r8a774e1 support
  dt-bindings: i2c: renesas,iic: Document r8a774e1 support
  arm64: dts: renesas: r8a774e1: Add I2C and IIC-DVFS support
  spi: renesas,sh-msiof: Add r8a774e1 support
  arm64: dts: renesas: r8a774e1: Add MSIOF nodes
  dt-bindings: watchdog: renesas,wdt: Document r8a774e1 support
  arm64: dts: renesas: r8a774e1: Add RWDT node

 .../devicetree/bindings/i2c/renesas,i2c.txt   |   1 +
 .../devicetree/bindings/i2c/renesas,iic.txt   |   1 +
 .../devicetree/bindings/spi/sh-msiof.txt      |   1 +
 .../bindings/watchdog/renesas,wdt.txt         |   1 +
 arch/arm64/boot/dts/renesas/r8a774e1.dtsi     | 390 +++++++++++++++++-
 drivers/mmc/host/renesas_sdhi_internal_dmac.c |   1 +
 6 files changed, 386 insertions(+), 9 deletions(-)

Comments

Pavel Machek Aug. 26, 2020, 9:46 p.m. UTC | #1
Hi!

> Add RZ/G2H SoC support for [H]SCIF/SDHI/I2C/RWDT/MSIOF on 4.19.y-cip kernel.
> 
> All the patches in this series are cherry-piced from ML, except [1] which is 
> a new patch similar to the workdone for other similar SoC's

Series looks good to me. (But gitlab testing does not seem to work,
and it would be good to test it before applying).

Best regards,
								Pavel
Biju Das Aug. 27, 2020, 6:42 a.m. UTC | #2
Hi Pavel,

Thanks for the feedback.

> Subject: Re: [PATCH 4.19.y-cip 00/10] Add support for
> [H]SCIF/SDHI/I2C/RWDT/MSIOF
>
> Hi!
>
> > Add RZ/G2H SoC support for [H]SCIF/SDHI/I2C/RWDT/MSIOF on 4.19.y-cip
> kernel.
> >
> > All the patches in this series are cherry-piced from ML, except [1]
> > which is a new patch similar to the workdone for other similar SoC's
>
> Series looks good to me. (But gitlab testing does not seem to work, and it
> would be good to test it before applying).

I am  not sure about the failure.  If it is related to testing on RZ/G2H board, then

I guess  RZ/G2H boards have enabled watchdog in u-boot with VLP 1.0.4.  So our RZ/G2H boards have enabled watchdog in u-boot.

The timeout is 60seconds. So if watchdog is not enabled in kernel or  Watchdog is enabled and there is no watchdog daemon, it will reboot after 60seconds.

In current case, watchdog is enabled by this series. So If you apply this series, then next thing you need to make sure is watchdog daemon is
running or stop the watchdog

or

For cip testing, we should disable watchdog in u-boot.

Cheers,
Biju




Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#5281): https://lists.cip-project.org/g/cip-dev/message/5281
Mute This Topic: https://lists.cip-project.org/mt/76426354/4520428
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129116/1171672734/xyzzy  [patchwork-cip-dev@patchwork.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
Pavel Machek Aug. 27, 2020, 7 a.m. UTC | #3
Hi!

> Thanks for the feedback.
> 
> > Subject: Re: [PATCH 4.19.y-cip 00/10] Add support for
> > [H]SCIF/SDHI/I2C/RWDT/MSIOF
> >
> > Hi!
> >
> > > Add RZ/G2H SoC support for [H]SCIF/SDHI/I2C/RWDT/MSIOF on 4.19.y-cip
> > kernel.
> > >
> > > All the patches in this series are cherry-piced from ML, except [1]
> > > which is a new patch similar to the workdone for other similar SoC's
> >
> > Series looks good to me. (But gitlab testing does not seem to work, and it
> > would be good to test it before applying).
> 
> I am  not sure about the failure.  If it is related to testing on RZ/G2H board, then

No, it is definitely not related to your boards. Nothing ever
builds... it can't be your fault or fault of your board, but it just
prevents testing :-(.

Best regards,
								Pavel
Biju Das Aug. 27, 2020, 7:06 a.m. UTC | #4
Hi Pavel,

Thanks for the feedback.

> Subject: Re: [PATCH 4.19.y-cip 00/10] Add support for
> [H]SCIF/SDHI/I2C/RWDT/MSIOF
>
> Hi!
>
> > Thanks for the feedback.
> >
> > > Subject: Re: [PATCH 4.19.y-cip 00/10] Add support for
> > > [H]SCIF/SDHI/I2C/RWDT/MSIOF
> > >
> > > Hi!
> > >
> > > > Add RZ/G2H SoC support for [H]SCIF/SDHI/I2C/RWDT/MSIOF on
> > > > 4.19.y-cip
> > > kernel.
> > > >
> > > > All the patches in this series are cherry-piced from ML, except
> > > > [1] which is a new patch similar to the workdone for other similar
> > > > SoC's
> > >
> > > Series looks good to me. (But gitlab testing does not seem to work,
> > > and it would be good to test it before applying).
> >
> > I am  not sure about the failure.  If it is related to testing on
> > RZ/G2H board, then
>
> No, it is definitely not related to your boards. Nothing ever builds... it can't be
> your fault or fault of your board, but it just prevents testing :-(.

I have applied the entire series and it builds fine in my environment with linux-4.19.y-cip(4.19.138-cip32).
What is the build issue related to gitlab testing?

Cheers,
Biju


Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#5282): https://lists.cip-project.org/g/cip-dev/message/5282
Mute This Topic: https://lists.cip-project.org/mt/76426354/4520428
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129116/1171672734/xyzzy  [patchwork-cip-dev@patchwork.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
Nobuhiro Iwamatsu Aug. 27, 2020, 7:09 a.m. UTC | #5
Hi,

> -----Original Message-----
> From: Biju Das [mailto:biju.das.jz@bp.renesas.com]
> Sent: Thursday, August 27, 2020 4:07 PM
> To: Pavel Machek <pavel@denx.de>
> Cc: Chris Paterson <Chris.Paterson2@renesas.com>; cip-dev@lists.cip-project.org; iwamatsu nobuhiro(岩松 信洋 □S
> WC◯ACT) <nobuhiro1.iwamatsu@toshiba.co.jp>; Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Subject: RE: [PATCH 4.19.y-cip 00/10] Add support for [H]SCIF/SDHI/I2C/RWDT/MSIOF
> 
> Hi Pavel,
> 
> Thanks for the feedback.
> 
> > Subject: Re: [PATCH 4.19.y-cip 00/10] Add support for
> > [H]SCIF/SDHI/I2C/RWDT/MSIOF
> >
> > Hi!
> >
> > > Thanks for the feedback.
> > >
> > > > Subject: Re: [PATCH 4.19.y-cip 00/10] Add support for
> > > > [H]SCIF/SDHI/I2C/RWDT/MSIOF
> > > >
> > > > Hi!
> > > >
> > > > > Add RZ/G2H SoC support for [H]SCIF/SDHI/I2C/RWDT/MSIOF on
> > > > > 4.19.y-cip
> > > > kernel.
> > > > >
> > > > > All the patches in this series are cherry-piced from ML, except
> > > > > [1] which is a new patch similar to the workdone for other similar
> > > > > SoC's
> > > >
> > > > Series looks good to me. (But gitlab testing does not seem to work,
> > > > and it would be good to test it before applying).
> > >
> > > I am  not sure about the failure.  If it is related to testing on
> > > RZ/G2H board, then
> >
> > No, it is definitely not related to your boards. Nothing ever builds... it can't be
> > your fault or fault of your board, but it just prevents testing :-(.
> 
> I have applied the entire series and it builds fine in my environment with linux-4.19.y-cip(4.19.138-cip32).
> What is the build issue related to gitlab testing?
> 
As I write other mail, this seems to be a issue in the environment that runs gitlab runner.

> Cheers,
> Biju
> 

Best regards,
  Nobuhiro

> 
> Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office:
> Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708
> USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#5277): https://lists.cip-project.org/g/cip-dev/message/5277
Mute This Topic: https://lists.cip-project.org/mt/76426354/4520428
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129116/1171672734/xyzzy  [patchwork-cip-dev@patchwork.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
Biju Das Aug. 27, 2020, 7:12 a.m. UTC | #6
Hi Nobuhiro,

Thanks for the feedback.

> Subject: RE: [PATCH 4.19.y-cip 00/10] Add support for
> [H]SCIF/SDHI/I2C/RWDT/MSIOF
>
> Hi,
>
> > -----Original Message-----
> > From: Biju Das [mailto:biju.das.jz@bp.renesas.com]
> > Sent: Thursday, August 27, 2020 4:07 PM
> > To: Pavel Machek <pavel@denx.de>
> > Cc: Chris Paterson <Chris.Paterson2@renesas.com>;
> > cip-dev@lists.cip-project.org; iwamatsu nobuhiro(岩松 信洋 □S
> > WC◯ACT) <nobuhiro1.iwamatsu@toshiba.co.jp>; Prabhakar
> Mahadev Lad
> > <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > Subject: RE: [PATCH 4.19.y-cip 00/10] Add support for
> > [H]SCIF/SDHI/I2C/RWDT/MSIOF
> >
> > Hi Pavel,
> >
> > Thanks for the feedback.
> >
> > > Subject: Re: [PATCH 4.19.y-cip 00/10] Add support for
> > > [H]SCIF/SDHI/I2C/RWDT/MSIOF
> > >
> > > Hi!
> > >
> > > > Thanks for the feedback.
> > > >
> > > > > Subject: Re: [PATCH 4.19.y-cip 00/10] Add support for
> > > > > [H]SCIF/SDHI/I2C/RWDT/MSIOF
> > > > >
> > > > > Hi!
> > > > >
> > > > > > Add RZ/G2H SoC support for [H]SCIF/SDHI/I2C/RWDT/MSIOF on
> > > > > > 4.19.y-cip
> > > > > kernel.
> > > > > >
> > > > > > All the patches in this series are cherry-piced from ML,
> > > > > > except [1] which is a new patch similar to the workdone for
> > > > > > other similar SoC's
> > > > >
> > > > > Series looks good to me. (But gitlab testing does not seem to
> > > > > work, and it would be good to test it before applying).
> > > >
> > > > I am  not sure about the failure.  If it is related to testing on
> > > > RZ/G2H board, then
> > >
> > > No, it is definitely not related to your boards. Nothing ever
> > > builds... it can't be your fault or fault of your board, but it just prevents
> testing :-(.
> >
> > I have applied the entire series and it builds fine in my environment with
> linux-4.19.y-cip(4.19.138-cip32).
> > What is the build issue related to gitlab testing?
> >
> As I write other mail, this seems to be a issue in the environment that runs
> gitlab runner.

Ok.

Cheers,
Biju


Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#5283): https://lists.cip-project.org/g/cip-dev/message/5283
Mute This Topic: https://lists.cip-project.org/mt/76426354/4520428
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129116/1171672734/xyzzy  [patchwork-cip-dev@patchwork.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
Nobuhiro Iwamatsu Aug. 27, 2020, 7:14 a.m. UTC | #7
Hi,

> -----Original Message-----
> From: Biju Das [mailto:biju.das.jz@bp.renesas.com]
> Sent: Wednesday, August 26, 2020 8:21 PM
> To: cip-dev@lists.cip-project.org; iwamatsu nobuhiro(岩松 信洋 □SWC◯ACT)
> <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de>
> Cc: Chris Paterson <chris.paterson2@renesas.com>; Biju Das <biju.das.jz@bp.renesas.com>; Prabhakar Mahadev Lad
> <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Subject: [PATCH 4.19.y-cip 00/10] Add support for [H]SCIF/SDHI/I2C/RWDT/MSIOF
> 
> Add RZ/G2H SoC support for [H]SCIF/SDHI/I2C/RWDT/MSIOF on 4.19.y-cip kernel.
> 
> All the patches in this series are cherry-piced from ML, except [1] which is
> a new patch similar to the workdone for other similar SoC's
> 
> [1] mmc: renesas_sdhi_internal_dmac: Add r8a774e1 support
> 
> This patch series depend on [2]
> [2] https://patchwork.kernel.org/project/cip-dev/list/?series=338235
> 
> Biju Das (1):
>   mmc: renesas_sdhi_internal_dmac: Add r8a774e1 support
> 
> Lad Prabhakar (9):
>   arm64: dts: renesas: r8a774e1: Add SCIF and HSCIF nodes
>   arm64: dts: renesas: r8a774e1: Add SDHI nodes
>   dt-bindings: i2c: renesas,i2c: Document r8a774e1 support
>   dt-bindings: i2c: renesas,iic: Document r8a774e1 support
>   arm64: dts: renesas: r8a774e1: Add I2C and IIC-DVFS support
>   spi: renesas,sh-msiof: Add r8a774e1 support
>   arm64: dts: renesas: r8a774e1: Add MSIOF nodes
>   dt-bindings: watchdog: renesas,wdt: Document r8a774e1 support
>   arm64: dts: renesas: r8a774e1: Add RWDT node
> 
>  .../devicetree/bindings/i2c/renesas,i2c.txt   |   1 +
>  .../devicetree/bindings/i2c/renesas,iic.txt   |   1 +
>  .../devicetree/bindings/spi/sh-msiof.txt      |   1 +
>  .../bindings/watchdog/renesas,wdt.txt         |   1 +
>  arch/arm64/boot/dts/renesas/r8a774e1.dtsi     | 390 +++++++++++++++++-
>  drivers/mmc/host/renesas_sdhi_internal_dmac.c |   1 +
>  6 files changed, 386 insertions(+), 9 deletions(-)
> 	

I reviwed this patch series, looks good to me.

Best regards,
  Nobuhiro
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#5278): https://lists.cip-project.org/g/cip-dev/message/5278
Mute This Topic: https://lists.cip-project.org/mt/76426354/4520428
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129116/1171672734/xyzzy  [patchwork-cip-dev@patchwork.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
Pavel Machek Aug. 28, 2020, 6:59 p.m. UTC | #8
Hi!

> Add RZ/G2H SoC support for [H]SCIF/SDHI/I2C/RWDT/MSIOF on 4.19.y-cip kernel.
> 
> All the patches in this series are cherry-piced from ML, except [1] which is 
> a new patch similar to the workdone for other similar SoC's

Thanks, applied and pushed out.

Best regards,
									Pavel