| Message ID | 20200827065144.17683-2-lokeshvutla@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: Initial support for Texas Instrument's J7200 Platform | expand |
On 12:21-20200827, Lokesh Vutla wrote: > Convert TI K3 Board/SoC bindings to DT schema format. > > Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> > --- > .../devicetree/bindings/arm/ti/k3.txt | 26 ---------------- > .../devicetree/bindings/arm/ti/k3.yaml | 31 +++++++++++++++++++ > MAINTAINERS | 2 +- > 3 files changed, 32 insertions(+), 27 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/arm/ti/k3.txt > create mode 100644 Documentation/devicetree/bindings/arm/ti/k3.yaml Thanks for doing this, but I have a problem with dbs_check and dtbs W=2 build warnings on existing dts files that this exposes further.. Do you mind pulling this patch out of this j7200 series ? I would rather us cleanup the warnings a bit as well, and deal with yaml conversion seperate from j7200 bindings? We will need Rob's ack anyways, I would rather we look at things independently.
Hi Nishanth, On 28/08/20 6:11 am, Nishanth Menon wrote: > On 12:21-20200827, Lokesh Vutla wrote: >> Convert TI K3 Board/SoC bindings to DT schema format. >> >> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> >> --- >> .../devicetree/bindings/arm/ti/k3.txt | 26 ---------------- >> .../devicetree/bindings/arm/ti/k3.yaml | 31 +++++++++++++++++++ >> MAINTAINERS | 2 +- >> 3 files changed, 32 insertions(+), 27 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/arm/ti/k3.txt >> create mode 100644 Documentation/devicetree/bindings/arm/ti/k3.yaml > > > Thanks for doing this, but I have a problem with dbs_check and dtbs > W=2 build warnings on existing dts files that this exposes further.. IMHO, that should not block the conversion to yaml bindings. May I know the problem you are seeing? > Do you mind pulling this patch out of this j7200 series ? I would > rather us cleanup the warnings a bit as well, and deal with yaml > conversion seperate from j7200 bindings? Ill wait for Rob's view on this. He already asked to convert it during J721e binding update. Not sure we would like to delay any further. Thanks and regards, Lokesh > > We will need Rob's ack anyways, I would rather we look at things > independently. >
Hi Nishanth, On 8/27/20 10:14 PM, Lokesh Vutla wrote: > Hi Nishanth, > > On 28/08/20 6:11 am, Nishanth Menon wrote: >> On 12:21-20200827, Lokesh Vutla wrote: >>> Convert TI K3 Board/SoC bindings to DT schema format. >>> >>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> >>> --- >>> .../devicetree/bindings/arm/ti/k3.txt | 26 ---------------- >>> .../devicetree/bindings/arm/ti/k3.yaml | 31 +++++++++++++++++++ >>> MAINTAINERS | 2 +- >>> 3 files changed, 32 insertions(+), 27 deletions(-) >>> delete mode 100644 Documentation/devicetree/bindings/arm/ti/k3.txt >>> create mode 100644 Documentation/devicetree/bindings/arm/ti/k3.yaml >> >> >> Thanks for doing this, but I have a problem with dbs_check and dtbs >> W=2 build warnings on existing dts files that this exposes further.. > > IMHO, that should not block the conversion to yaml bindings. May I know the > problem you are seeing? Agree with Lokesh here. This should neither increase or decrease the existing warnings present. FWIW, both dt_bindings_check and dtbs_check with the DT_SCHEMA_FILES set to k3.yaml is clean. And the J7200 dts files are clean even without any DT_SCHEMA_FILES specified. It is going to take sometime before the existing dtbs_check warnings are cleaned up on all the K3 dts files, and that has to do with the pre-existing bindings files in text and no yaml equivalent for them. regards Suman > >> Do you mind pulling this patch out of this j7200 series ? I would >> rather us cleanup the warnings a bit as well, and deal with yaml >> conversion seperate from j7200 bindings? > > Ill wait for Rob's view on this. He already asked to convert it during J721e > binding update. Not sure we would like to delay any further. > > Thanks and regards, > Lokesh > >> >> We will need Rob's ack anyways, I would rather we look at things >> independently. >>
On 08:44-20200828, Lokesh Vutla wrote: > Hi Nishanth, > > On 28/08/20 6:11 am, Nishanth Menon wrote: > > On 12:21-20200827, Lokesh Vutla wrote: > >> Convert TI K3 Board/SoC bindings to DT schema format. > >> > >> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> > >> --- > >> .../devicetree/bindings/arm/ti/k3.txt | 26 ---------------- > >> .../devicetree/bindings/arm/ti/k3.yaml | 31 +++++++++++++++++++ > >> MAINTAINERS | 2 +- > >> 3 files changed, 32 insertions(+), 27 deletions(-) > >> delete mode 100644 Documentation/devicetree/bindings/arm/ti/k3.txt > >> create mode 100644 Documentation/devicetree/bindings/arm/ti/k3.yaml > > > > > > Thanks for doing this, but I have a problem with dbs_check and dtbs > > W=2 build warnings on existing dts files that this exposes further.. > > IMHO, that should not block the conversion to yaml bindings. May I know the > problem you are seeing? Things are starting to literally bitrot and I saw Rob's[1] attempt to try and clean up the cruft of warnings we had introduced. we should fix all that up before introducing new platforms. I am going to see how much cleanup I can do today, but will help if more folks pitch in. > > > Do you mind pulling this patch out of this j7200 series ? I would > > rather us cleanup the warnings a bit as well, and deal with yaml > > conversion seperate from j7200 bindings? > > Ill wait for Rob's view on this. He already asked to convert it during J721e > binding update. Not sure we would like to delay any further. > Sure. [1] https://lore.kernel.org/linux-arm-kernel/CAL_JsqLqVdyKkVKJP0EG7s7m4A=r-+DjY+X4kVs9boFfPoHsfw@mail.gmail.com/#r
Hi Rob, On 27/08/20 12:21 pm, Lokesh Vutla wrote: > Convert TI K3 Board/SoC bindings to DT schema format. > > Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> Do you have any comments on this patch? Thanks and regards, Lokesh > --- > .../devicetree/bindings/arm/ti/k3.txt | 26 ---------------- > .../devicetree/bindings/arm/ti/k3.yaml | 31 +++++++++++++++++++ > MAINTAINERS | 2 +- > 3 files changed, 32 insertions(+), 27 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/arm/ti/k3.txt > create mode 100644 Documentation/devicetree/bindings/arm/ti/k3.yaml > > diff --git a/Documentation/devicetree/bindings/arm/ti/k3.txt b/Documentation/devicetree/bindings/arm/ti/k3.txt > deleted file mode 100644 > index 333e7256126a..000000000000 > --- a/Documentation/devicetree/bindings/arm/ti/k3.txt > +++ /dev/null > @@ -1,26 +0,0 @@ > -Texas Instruments K3 Multicore SoC architecture device tree bindings > --------------------------------------------------------------------- > - > -Platforms based on Texas Instruments K3 Multicore SoC architecture > -shall follow the following scheme: > - > -SoCs > ----- > - > -Each device tree root node must specify which exact SoC in K3 Multicore SoC > -architecture it uses, using one of the following compatible values: > - > -- AM654 > - compatible = "ti,am654"; > - > -- J721E > - compatible = "ti,j721e"; > - > -Boards > ------- > - > -In addition, each device tree root node must specify which one or more > -of the following board-specific compatible values: > - > -- AM654 EVM > - compatible = "ti,am654-evm", "ti,am654"; > diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml > new file mode 100644 > index 000000000000..c5e3e4aeda8e > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml > @@ -0,0 +1,31 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/ti/k3.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments K3 Multicore SoC architecture device tree bindings > + > +maintainers: > + - Nishanth Menon <nm@ti.com> > + > +description: | > + Platforms based on Texas Instruments K3 Multicore SoC architecture > + shall have the following properties. > + > +properties: > + $nodename: > + const: '/' > + compatible: > + oneOf: > + > + - description: K3 AM654 SoC > + items: > + - enum: > + - ti,am654-evm > + - const: ti,am654 > + > + - description: K3 J721E SoC > + items: > + - const: ti,j721e > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index 3b186ade3597..40d31bb7ecf4 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2636,7 +2636,7 @@ M: Tero Kristo <t-kristo@ti.com> > M: Nishanth Menon <nm@ti.com> > L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) > S: Supported > -F: Documentation/devicetree/bindings/arm/ti/k3.txt > +F: Documentation/devicetree/bindings/arm/ti/k3.yaml > F: arch/arm64/boot/dts/ti/Makefile > F: arch/arm64/boot/dts/ti/k3-* > F: include/dt-bindings/pinctrl/k3.h >
On 08:44-20200828, Lokesh Vutla wrote: > Hi Nishanth, > > On 28/08/20 6:11 am, Nishanth Menon wrote: > > On 12:21-20200827, Lokesh Vutla wrote: > >> Convert TI K3 Board/SoC bindings to DT schema format. > >> > >> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> > >> --- > >> .../devicetree/bindings/arm/ti/k3.txt | 26 ---------------- > >> .../devicetree/bindings/arm/ti/k3.yaml | 31 +++++++++++++++++++ > >> MAINTAINERS | 2 +- > >> 3 files changed, 32 insertions(+), 27 deletions(-) > >> delete mode 100644 Documentation/devicetree/bindings/arm/ti/k3.txt > >> create mode 100644 Documentation/devicetree/bindings/arm/ti/k3.yaml > > > > > > Thanks for doing this, but I have a problem with dbs_check and dtbs > > W=2 build warnings on existing dts files that this exposes further.. > > IMHO, that should not block the conversion to yaml bindings. May I know the > problem you are seeing? > > > Do you mind pulling this patch out of this j7200 series ? I would > > rather us cleanup the warnings a bit as well, and deal with yaml > > conversion seperate from j7200 bindings? > I just wanted to follow up on this thread as well.. [1] attempts stage 1 of cleanup, and we can follow up cleanup in parallel. So if Rob acks the binding, we can carry on based on the window it fits in. [1] https://lore.kernel.org/linux-arm-kernel/20200903130015.21361-1-nm@ti.com/
diff --git a/Documentation/devicetree/bindings/arm/ti/k3.txt b/Documentation/devicetree/bindings/arm/ti/k3.txt deleted file mode 100644 index 333e7256126a..000000000000 --- a/Documentation/devicetree/bindings/arm/ti/k3.txt +++ /dev/null @@ -1,26 +0,0 @@ -Texas Instruments K3 Multicore SoC architecture device tree bindings --------------------------------------------------------------------- - -Platforms based on Texas Instruments K3 Multicore SoC architecture -shall follow the following scheme: - -SoCs ----- - -Each device tree root node must specify which exact SoC in K3 Multicore SoC -architecture it uses, using one of the following compatible values: - -- AM654 - compatible = "ti,am654"; - -- J721E - compatible = "ti,j721e"; - -Boards ------- - -In addition, each device tree root node must specify which one or more -of the following board-specific compatible values: - -- AM654 EVM - compatible = "ti,am654-evm", "ti,am654"; diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml new file mode 100644 index 000000000000..c5e3e4aeda8e --- /dev/null +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml @@ -0,0 +1,31 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/arm/ti/k3.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Texas Instruments K3 Multicore SoC architecture device tree bindings + +maintainers: + - Nishanth Menon <nm@ti.com> + +description: | + Platforms based on Texas Instruments K3 Multicore SoC architecture + shall have the following properties. + +properties: + $nodename: + const: '/' + compatible: + oneOf: + + - description: K3 AM654 SoC + items: + - enum: + - ti,am654-evm + - const: ti,am654 + + - description: K3 J721E SoC + items: + - const: ti,j721e +... diff --git a/MAINTAINERS b/MAINTAINERS index 3b186ade3597..40d31bb7ecf4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2636,7 +2636,7 @@ M: Tero Kristo <t-kristo@ti.com> M: Nishanth Menon <nm@ti.com> L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) S: Supported -F: Documentation/devicetree/bindings/arm/ti/k3.txt +F: Documentation/devicetree/bindings/arm/ti/k3.yaml F: arch/arm64/boot/dts/ti/Makefile F: arch/arm64/boot/dts/ti/k3-* F: include/dt-bindings/pinctrl/k3.h
Convert TI K3 Board/SoC bindings to DT schema format. Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> --- .../devicetree/bindings/arm/ti/k3.txt | 26 ---------------- .../devicetree/bindings/arm/ti/k3.yaml | 31 +++++++++++++++++++ MAINTAINERS | 2 +- 3 files changed, 32 insertions(+), 27 deletions(-) delete mode 100644 Documentation/devicetree/bindings/arm/ti/k3.txt create mode 100644 Documentation/devicetree/bindings/arm/ti/k3.yaml