| Message ID | 20200827190400.12608-1-rcampbell@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | bfe18a0900f1188e323d3f2c3cd2d6dfe2d0789c |
| Headers | show |
| Series | mm/test: use the new SKIP() macro | expand |
On Thu, Aug 27, 2020 at 12:04:00PM -0700, Ralph Campbell wrote: > Some tests might not be able to be run if resources like huge pages are > not available. Mark these tests as skipped instead of simply passing. > > Signed-off-by: Ralph Campbell <rcampbell@nvidia.com> > --- > > This applies to linux-mm and is for Andrew Morton's tree. > > tools/testing/selftests/vm/hmm-tests.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Jason Gunthorpe <jgg@nvidia.com> Jason
diff --git a/tools/testing/selftests/vm/hmm-tests.c b/tools/testing/selftests/vm/hmm-tests.c index 93fc5cadce61..0a28a6a29581 100644 --- a/tools/testing/selftests/vm/hmm-tests.c +++ b/tools/testing/selftests/vm/hmm-tests.c @@ -680,7 +680,7 @@ TEST_F(hmm, anon_write_hugetlbfs) n = gethugepagesizes(pagesizes, 4); if (n <= 0) - return; + SKIP(return, "Huge page size could not be determined"); for (idx = 0; --n > 0; ) { if (pagesizes[n] < pagesizes[idx]) idx = n; @@ -694,7 +694,7 @@ TEST_F(hmm, anon_write_hugetlbfs) buffer->ptr = get_hugepage_region(size, GHR_STRICT); if (buffer->ptr == NULL) { free(buffer); - return; + SKIP(return, "Huge page could not be allocated"); } buffer->fd = -1;
Some tests might not be able to be run if resources like huge pages are not available. Mark these tests as skipped instead of simply passing. Signed-off-by: Ralph Campbell <rcampbell@nvidia.com> --- This applies to linux-mm and is for Andrew Morton's tree. tools/testing/selftests/vm/hmm-tests.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)