diff mbox series

[2/2] drm: panel: simple: Add AM-1280800N3TZQW-T00H

Message ID 20200828155938.328982-2-jagan@amarulasolutions.com (mailing list archive)
State New, archived
Headers show
Series [1/2] dt-bindings: display: simple: Add AM-1280800N3TZQW-T00H | expand

Commit Message

Jagan Teki Aug. 28, 2020, 3:59 p.m. UTC 
Add Ampire, AM-1280800N3TZQW-T00H 10.1" TFT LCD panel timings.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

Comments

kernel test robot Aug. 28, 2020, 5:54 p.m. UTC | #1 
Hi Jagan,

I love your patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on drm-intel/for-linux-next drm-tip/drm-tip linus/master v5.9-rc2 next-20200828]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jagan-Teki/dt-bindings-display-simple-Add-AM-1280800N3TZQW-T00H/20200829-000037
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: i386-randconfig-m021-20200828 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/panel/panel-simple.c:623:3: error: 'const struct drm_display_mode' has no member named 'vrefresh'
     623 |  .vrefresh = 60,
         |   ^~~~~~~~

# https://github.com/0day-ci/linux/commit/dfa982c527d827dca7aa86fc2b58228ff404bc05
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jagan-Teki/dt-bindings-display-simple-Add-AM-1280800N3TZQW-T00H/20200829-000037
git checkout dfa982c527d827dca7aa86fc2b58228ff404bc05
vim +623 drivers/gpu/drm/panel/panel-simple.c

   612	
   613	static const struct drm_display_mode ampire_am_1280800n3tzqw_t00h_mode = {
   614		.clock = 71100,
   615		.hdisplay = 1280,
   616		.hsync_start = 1280 + 40,
   617		.hsync_end = 1280 + 40 + 80,
   618		.htotal = 1280 + 40 + 80 + 40,
   619		.vdisplay = 800,
   620		.vsync_start = 800 + 3,
   621		.vsync_end = 800 + 3 + 10,
   622		.vtotal = 800 + 3 + 10 + 10,
 > 623		.vrefresh = 60,
   624		.flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
   625	};
   626	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Sam Ravnborg Aug. 28, 2020, 6:03 p.m. UTC | #2 
Hi Jagan.

On Fri, Aug 28, 2020 at 09:29:38PM +0530, Jagan Teki wrote:
> Add Ampire, AM-1280800N3TZQW-T00H 10.1" TFT LCD panel timings.
> 
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index b6ecd1552132..c988fe8094f8 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -592,6 +592,31 @@ static void panel_simple_shutdown(struct device *dev)
>  	drm_panel_unprepare(&panel->base);
>  }
>  
> +static const struct drm_display_mode ampire_am_1280800n3tzqw_t00h_mode = {
> +	.clock = 71100,
> +	.hdisplay = 1280,
> +	.hsync_start = 1280 + 40,
> +	.hsync_end = 1280 + 40 + 80,
> +	.htotal = 1280 + 40 + 80 + 40,
> +	.vdisplay = 800,
> +	.vsync_start = 800 + 3,
> +	.vsync_end = 800 + 3 + 10,
> +	.vtotal = 800 + 3 + 10 + 10,
> +	.vrefresh = 60,
No longer preset - delete.

> +	.flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
> +};
> +
> +static const struct panel_desc ampire_am_1280800n3tzqw_t00h = {
> +	.modes = &ampire_am_1280800n3tzqw_t00h_mode,
> +	.num_modes = 1,
> +	.bpc = 6,
> +	.size = {
> +		.width = 217,
> +		.height = 136,
> +	},
> +	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
> +};
.connector_type is mandatory today.
And based on connector type you may need to specify .bus_flags.

	Sam

> +
>  static const struct drm_display_mode ampire_am_480272h3tmqw_t01h_mode = {
>  	.clock = 9000,
>  	.hdisplay = 480,
> @@ -3637,6 +3662,9 @@ static const struct panel_desc arm_rtsm = {
>  
>  static const struct of_device_id platform_of_match[] = {
>  	{
> +		.compatible = "ampire,am-1280800n3tzqw-t00h",
> +		.data = &ampire_am_1280800n3tzqw_t00h,
> +	}, {
>  		.compatible = "ampire,am-480272h3tmqw-t01h",
>  		.data = &ampire_am_480272h3tmqw_t01h,
>  	}, {
> -- 
> 2.25.1
kernel test robot Aug. 28, 2020, 8:18 p.m. UTC | #3 
Hi Jagan,

I love your patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on drm-intel/for-linux-next drm-tip/drm-tip linus/master v5.9-rc2 next-20200828]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jagan-Teki/dt-bindings-display-simple-Add-AM-1280800N3TZQW-T00H/20200829-000037
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: x86_64-randconfig-a003-20200828 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c10e63677f5d20f18010f8f68c631ddc97546f7d)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/panel/panel-simple.c:623:3: error: field designator 'vrefresh' does not refer to any field in type 'const struct drm_display_mode'
           .vrefresh = 60,
            ^
   1 error generated.

# https://github.com/0day-ci/linux/commit/dfa982c527d827dca7aa86fc2b58228ff404bc05
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jagan-Teki/dt-bindings-display-simple-Add-AM-1280800N3TZQW-T00H/20200829-000037
git checkout dfa982c527d827dca7aa86fc2b58228ff404bc05
vim +623 drivers/gpu/drm/panel/panel-simple.c

   612	
   613	static const struct drm_display_mode ampire_am_1280800n3tzqw_t00h_mode = {
   614		.clock = 71100,
   615		.hdisplay = 1280,
   616		.hsync_start = 1280 + 40,
   617		.hsync_end = 1280 + 40 + 80,
   618		.htotal = 1280 + 40 + 80 + 40,
   619		.vdisplay = 800,
   620		.vsync_start = 800 + 3,
   621		.vsync_end = 800 + 3 + 10,
   622		.vtotal = 800 + 3 + 10 + 10,
 > 623		.vrefresh = 60,
   624		.flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
   625	};
   626	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
diff mbox series

Patch

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index b6ecd1552132..c988fe8094f8 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -592,6 +592,31 @@  static void panel_simple_shutdown(struct device *dev)
 	drm_panel_unprepare(&panel->base);
 }
 
+static const struct drm_display_mode ampire_am_1280800n3tzqw_t00h_mode = {
+	.clock = 71100,
+	.hdisplay = 1280,
+	.hsync_start = 1280 + 40,
+	.hsync_end = 1280 + 40 + 80,
+	.htotal = 1280 + 40 + 80 + 40,
+	.vdisplay = 800,
+	.vsync_start = 800 + 3,
+	.vsync_end = 800 + 3 + 10,
+	.vtotal = 800 + 3 + 10 + 10,
+	.vrefresh = 60,
+	.flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
+};
+
+static const struct panel_desc ampire_am_1280800n3tzqw_t00h = {
+	.modes = &ampire_am_1280800n3tzqw_t00h_mode,
+	.num_modes = 1,
+	.bpc = 6,
+	.size = {
+		.width = 217,
+		.height = 136,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+};
+
 static const struct drm_display_mode ampire_am_480272h3tmqw_t01h_mode = {
 	.clock = 9000,
 	.hdisplay = 480,
@@ -3637,6 +3662,9 @@  static const struct panel_desc arm_rtsm = {
 
 static const struct of_device_id platform_of_match[] = {
 	{
+		.compatible = "ampire,am-1280800n3tzqw-t00h",
+		.data = &ampire_am_1280800n3tzqw_t00h,
+	}, {
 		.compatible = "ampire,am-480272h3tmqw-t01h",
 		.data = &ampire_am_480272h3tmqw_t01h,
 	}, {