Message ID | 7a3dd5a2-5787-adf3-d525-c203f9910ec4@infradead.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | fs/xattr.c: fix kernel-doc warnings for setxattr & removexattr | expand |
On Sun, 30 Aug 2020 17:30:08 -0700 Randy Dunlap <rdunlap@infradead.org> wrote: > From: Randy Dunlap <rdunlap@infradead.org> > > Fix kernel-doc warnings in fs/xattr.c: > > ../fs/xattr.c:251: warning: Function parameter or member 'dentry' not described in '__vfs_setxattr_locked' > ../fs/xattr.c:251: warning: Function parameter or member 'name' not described in '__vfs_setxattr_locked' > ../fs/xattr.c:251: warning: Function parameter or member 'value' not described in '__vfs_setxattr_locked' > ../fs/xattr.c:251: warning: Function parameter or member 'size' not described in '__vfs_setxattr_locked' > ../fs/xattr.c:251: warning: Function parameter or member 'flags' not described in '__vfs_setxattr_locked' > ../fs/xattr.c:251: warning: Function parameter or member 'delegated_inode' not described in '__vfs_setxattr_locked' > ../fs/xattr.c:458: warning: Function parameter or member 'dentry' not described in '__vfs_removexattr_locked' > ../fs/xattr.c:458: warning: Function parameter or member 'name' not described in '__vfs_removexattr_locked' > ../fs/xattr.c:458: warning: Function parameter or member 'delegated_inode' not described in '__vfs_removexattr_locked' > > Fixes: 08b5d5014a27 ("xattr: break delegations in {set,remove}xattr") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: stable@vger.kernel.org # v4.9+ hm, are kerneldoc warning fixes -stable material?
On 8/30/20 6:32 PM, Andrew Morton wrote: > On Sun, 30 Aug 2020 17:30:08 -0700 Randy Dunlap <rdunlap@infradead.org> wrote: > >> From: Randy Dunlap <rdunlap@infradead.org> >> >> Fix kernel-doc warnings in fs/xattr.c: >> >> ../fs/xattr.c:251: warning: Function parameter or member 'dentry' not described in '__vfs_setxattr_locked' >> ../fs/xattr.c:251: warning: Function parameter or member 'name' not described in '__vfs_setxattr_locked' >> ../fs/xattr.c:251: warning: Function parameter or member 'value' not described in '__vfs_setxattr_locked' >> ../fs/xattr.c:251: warning: Function parameter or member 'size' not described in '__vfs_setxattr_locked' >> ../fs/xattr.c:251: warning: Function parameter or member 'flags' not described in '__vfs_setxattr_locked' >> ../fs/xattr.c:251: warning: Function parameter or member 'delegated_inode' not described in '__vfs_setxattr_locked' >> ../fs/xattr.c:458: warning: Function parameter or member 'dentry' not described in '__vfs_removexattr_locked' >> ../fs/xattr.c:458: warning: Function parameter or member 'name' not described in '__vfs_removexattr_locked' >> ../fs/xattr.c:458: warning: Function parameter or member 'delegated_inode' not described in '__vfs_removexattr_locked' >> >> Fixes: 08b5d5014a27 ("xattr: break delegations in {set,remove}xattr") >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >> Cc: stable@vger.kernel.org # v4.9+ > > hm, are kerneldoc warning fixes -stable material? > I don't know. I only added that because the commit that it fixes had that Cc: line also. From my (just now) reading of stable-kernel-rules.rst, the answer is No.
--- lnx-59-rc3.orig/fs/xattr.c +++ lnx-59-rc3/fs/xattr.c @@ -232,15 +232,15 @@ int __vfs_setxattr_noperm(struct dentry } /** - * __vfs_setxattr_locked: set an extended attribute while holding the inode + * __vfs_setxattr_locked - set an extended attribute while holding the inode * lock * - * @dentry - object to perform setxattr on - * @name - xattr name to set - * @value - value to set @name to - * @size - size of @value - * @flags - flags to pass into filesystem operations - * @delegated_inode - on return, will contain an inode pointer that + * @dentry: object to perform setxattr on + * @name: xattr name to set + * @value: value to set @name to + * @size: size of @value + * @flags: flags to pass into filesystem operations + * @delegated_inode: on return, will contain an inode pointer that * a delegation was broken on, NULL if none. */ int @@ -443,12 +443,12 @@ __vfs_removexattr(struct dentry *dentry, EXPORT_SYMBOL(__vfs_removexattr); /** - * __vfs_removexattr_locked: set an extended attribute while holding the inode + * __vfs_removexattr_locked - set an extended attribute while holding the inode * lock * - * @dentry - object to perform setxattr on - * @name - name of xattr to remove - * @delegated_inode - on return, will contain an inode pointer that + * @dentry: object to perform setxattr on + * @name: name of xattr to remove + * @delegated_inode: on return, will contain an inode pointer that * a delegation was broken on, NULL if none. */ int