diff mbox series

[v2,3/3] crypto: sun4i-ss - add the V3s variant of SS

Message ID 20200831073101.3608-4-m.cerveny@computer.org (mailing list archive)
State New, archived
Headers show
Series crypto: sun4i-ss: add support for V3s | expand

Commit Message

Martin Cerveny Aug. 31, 2020, 7:31 a.m. UTC
Like A33 "sun4i-ss" has a difference, it give SHA1 digest
directly in BE. So add new compatible.

Tested-by: Martin Cerveny <m.cerveny@computer.org>
Signed-off-by: Martin Cerveny <m.cerveny@computer.org>
---
 drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Corentin Labbe Aug. 31, 2020, 11:50 a.m. UTC | #1
On Mon, Aug 31, 2020 at 09:31:01AM +0200, Martin Cerveny wrote:
> Like A33 "sun4i-ss" has a difference, it give SHA1 digest
> directly in BE. So add new compatible.
> 
> Tested-by: Martin Cerveny <m.cerveny@computer.org>
> Signed-off-by: Martin Cerveny <m.cerveny@computer.org>
> ---
>  drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 

Your commit message is wrong, "sun4i-ss" has no difference, but V3S yes.
Your other patch has the same problem.

Otherwise you could add:
Acked-by: Corentin Labbe <clabbe.montjoie@gmail.com>

Regards
diff mbox series

Patch

diff --git a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c b/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c
index a2b67f7f8..d24496cac 100644
--- a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c
+++ b/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c
@@ -31,6 +31,10 @@  static const struct ss_variant ss_a33_variant = {
 	.sha1_in_be = true,
 };
 
+static const struct ss_variant ss_v3s_variant = {
+	.sha1_in_be = true,
+};
+
 static struct sun4i_ss_alg_template ss_algs[] = {
 {       .type = CRYPTO_ALG_TYPE_AHASH,
 	.mode = SS_OP_MD5,
@@ -505,6 +509,9 @@  static const struct of_device_id a20ss_crypto_of_match_table[] = {
 	{ .compatible = "allwinner,sun8i-a33-crypto",
 	  .data = &ss_a33_variant
 	},
+	{ .compatible = "allwinner,sun8i-v3s-crypto",
+	  .data = &ss_v3s_variant
+	},
 	{}
 };
 MODULE_DEVICE_TABLE(of, a20ss_crypto_of_match_table);