| Message ID | 1598903558-9691-4-git-send-email-skomatineni@nvidia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | IMX274 fixes and power on and off implementation | expand |
Hi Sowjanya, On Mon, Aug 31, 2020 at 12:52:37PM -0700, Sowjanya Komatineni wrote: > Clock and supplies are external to IMX274 sensor and are dependent > on camera module design. > > So, this patch moves them to required properties. > > Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> > --- > Documentation/devicetree/bindings/media/i2c/imx274.txt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/imx274.txt b/Documentation/devicetree/bindings/media/i2c/imx274.txt > index d0a5c899..b43bed6 100644 > --- a/Documentation/devicetree/bindings/media/i2c/imx274.txt > +++ b/Documentation/devicetree/bindings/media/i2c/imx274.txt > @@ -10,15 +10,15 @@ at 1440 Mbps. > Required Properties: > - compatible: value should be "sony,imx274" for imx274 sensor > - reg: I2C bus address of the device > - > -Optional Properties: > -- reset-gpios: Sensor reset GPIO > - clocks: Reference to the input clock. > - clock-names: Should be "inck". > - vana-supply: Sensor 2.8v analog supply. > - vdig-supply: Sensor 1.8v digital core supply. > - vddl-supply: Sensor digital IO 1.2v supply. If these have been optional in the past I don't think we can start requiring them now. The framework will just give the driver a dummy regulator if one isn't found. > > +Optional Properties: > +- reset-gpios: Sensor reset GPIO > + > The imx274 device node should contain one 'port' child node with > an 'endpoint' subnode. For further reading on port node refer to > Documentation/devicetree/bindings/media/video-interfaces.txt.
Hi Sowjanya, On Mon, Aug 31, 2020 at 12:52:37PM -0700, Sowjanya Komatineni wrote: > Clock and supplies are external to IMX274 sensor and are dependent > on camera module design. > > So, this patch moves them to required properties. > > Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> One more comment. Jacopo has been working on converting this to YAML format. Could you rebase your patch on his? I believe he's still working on some changes. The subject is "[PATCH v3] dt-bindings: media: imx274: Convert to json-schema".
On 8/31/20 1:17 PM, Sakari Ailus wrote: > Hi Sowjanya, > > On Mon, Aug 31, 2020 at 12:52:37PM -0700, Sowjanya Komatineni wrote: >> Clock and supplies are external to IMX274 sensor and are dependent >> on camera module design. >> >> So, this patch moves them to required properties. >> >> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> >> --- >> Documentation/devicetree/bindings/media/i2c/imx274.txt | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/media/i2c/imx274.txt b/Documentation/devicetree/bindings/media/i2c/imx274.txt >> index d0a5c899..b43bed6 100644 >> --- a/Documentation/devicetree/bindings/media/i2c/imx274.txt >> +++ b/Documentation/devicetree/bindings/media/i2c/imx274.txt >> @@ -10,15 +10,15 @@ at 1440 Mbps. >> Required Properties: >> - compatible: value should be "sony,imx274" for imx274 sensor >> - reg: I2C bus address of the device >> - >> -Optional Properties: >> -- reset-gpios: Sensor reset GPIO >> - clocks: Reference to the input clock. >> - clock-names: Should be "inck". >> - vana-supply: Sensor 2.8v analog supply. >> - vdig-supply: Sensor 1.8v digital core supply. >> - vddl-supply: Sensor digital IO 1.2v supply. > If these have been optional in the past I don't think we can start > requiring them now. > > The framework will just give the driver a dummy regulator if one isn't > found. These were added recently with my patches. So I hope should be ok to make them required as they are external to sensor > >> >> +Optional Properties: >> +- reset-gpios: Sensor reset GPIO >> + >> The imx274 device node should contain one 'port' child node with >> an 'endpoint' subnode. For further reading on port node refer to >> Documentation/devicetree/bindings/media/video-interfaces.txt.
On Mon, Aug 31, 2020 at 01:37:21PM -0700, Sowjanya Komatineni wrote: > > On 8/31/20 1:17 PM, Sakari Ailus wrote: > > Hi Sowjanya, > > > > On Mon, Aug 31, 2020 at 12:52:37PM -0700, Sowjanya Komatineni wrote: > > > Clock and supplies are external to IMX274 sensor and are dependent > > > on camera module design. > > > > > > So, this patch moves them to required properties. > > > > > > Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> > > > --- > > > Documentation/devicetree/bindings/media/i2c/imx274.txt | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/imx274.txt b/Documentation/devicetree/bindings/media/i2c/imx274.txt > > > index d0a5c899..b43bed6 100644 > > > --- a/Documentation/devicetree/bindings/media/i2c/imx274.txt > > > +++ b/Documentation/devicetree/bindings/media/i2c/imx274.txt > > > @@ -10,15 +10,15 @@ at 1440 Mbps. > > > Required Properties: > > > - compatible: value should be "sony,imx274" for imx274 sensor > > > - reg: I2C bus address of the device > > > - > > > -Optional Properties: > > > -- reset-gpios: Sensor reset GPIO > > > - clocks: Reference to the input clock. > > > - clock-names: Should be "inck". > > > - vana-supply: Sensor 2.8v analog supply. > > > - vdig-supply: Sensor 1.8v digital core supply. > > > - vddl-supply: Sensor digital IO 1.2v supply. > > If these have been optional in the past I don't think we can start > > requiring them now. > > > > The framework will just give the driver a dummy regulator if one isn't > > found. > These were added recently with my patches. So I hope should be ok to make > them required as they are external to sensor The bindings were added back in 2017, so they're not really recent.
On 8/31/20 1:37 PM, Sowjanya Komatineni wrote: > > On 8/31/20 1:17 PM, Sakari Ailus wrote: >> Hi Sowjanya, >> >> On Mon, Aug 31, 2020 at 12:52:37PM -0700, Sowjanya Komatineni wrote: >>> Clock and supplies are external to IMX274 sensor and are dependent >>> on camera module design. >>> >>> So, this patch moves them to required properties. >>> >>> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> >>> --- >>> Documentation/devicetree/bindings/media/i2c/imx274.txt | 6 +++--- >>> 1 file changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/media/i2c/imx274.txt >>> b/Documentation/devicetree/bindings/media/i2c/imx274.txt >>> index d0a5c899..b43bed6 100644 >>> --- a/Documentation/devicetree/bindings/media/i2c/imx274.txt >>> +++ b/Documentation/devicetree/bindings/media/i2c/imx274.txt >>> @@ -10,15 +10,15 @@ at 1440 Mbps. >>> Required Properties: >>> - compatible: value should be "sony,imx274" for imx274 sensor >>> - reg: I2C bus address of the device >>> - >>> -Optional Properties: >>> -- reset-gpios: Sensor reset GPIO >>> - clocks: Reference to the input clock. >>> - clock-names: Should be "inck". >>> - vana-supply: Sensor 2.8v analog supply. >>> - vdig-supply: Sensor 1.8v digital core supply. >>> - vddl-supply: Sensor digital IO 1.2v supply. >> If these have been optional in the past I don't think we can start >> requiring them now. >> >> The framework will just give the driver a dummy regulator if one isn't >> found. > These were added recently with my patches. So I hope should be ok to > make them required as they are external to sensor Also made them required as they are external to sensor and also to use bulk_enable/disable APIs, devm_regulator_bulk_get() does not use OPTIONAL_GET. >> >>> +Optional Properties: >>> +- reset-gpios: Sensor reset GPIO >>> + >>> The imx274 device node should contain one 'port' child node with >>> an 'endpoint' subnode. For further reading on port node refer to >>> Documentation/devicetree/bindings/media/video-interfaces.txt.
On 8/31/20 1:26 PM, Sakari Ailus wrote: > Hi Sowjanya, > > On Mon, Aug 31, 2020 at 12:52:37PM -0700, Sowjanya Komatineni wrote: >> Clock and supplies are external to IMX274 sensor and are dependent >> on camera module design. >> >> So, this patch moves them to required properties. >> >> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> > One more comment. > > Jacopo has been working on converting this to YAML format. Could you rebase > your patch on his? I believe he's still working on some changes. The > subject is "[PATCH v3] dt-bindings: media: imx274: Convert to json-schema". Sure, will keep them as optional and will rebase dt-bindings on json-schema patch
diff --git a/Documentation/devicetree/bindings/media/i2c/imx274.txt b/Documentation/devicetree/bindings/media/i2c/imx274.txt index d0a5c899..b43bed6 100644 --- a/Documentation/devicetree/bindings/media/i2c/imx274.txt +++ b/Documentation/devicetree/bindings/media/i2c/imx274.txt @@ -10,15 +10,15 @@ at 1440 Mbps. Required Properties: - compatible: value should be "sony,imx274" for imx274 sensor - reg: I2C bus address of the device - -Optional Properties: -- reset-gpios: Sensor reset GPIO - clocks: Reference to the input clock. - clock-names: Should be "inck". - vana-supply: Sensor 2.8v analog supply. - vdig-supply: Sensor 1.8v digital core supply. - vddl-supply: Sensor digital IO 1.2v supply. +Optional Properties: +- reset-gpios: Sensor reset GPIO + The imx274 device node should contain one 'port' child node with an 'endpoint' subnode. For further reading on port node refer to Documentation/devicetree/bindings/media/video-interfaces.txt.
Clock and supplies are external to IMX274 sensor and are dependent on camera module design. So, this patch moves them to required properties. Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> --- Documentation/devicetree/bindings/media/i2c/imx274.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)